-
Notifications
You must be signed in to change notification settings - Fork 58
DoD for feature
Julien Déramond edited this page Dec 16, 2021
·
19 revisions
First draft:
- Should match specs (eg. either the Web UI Kit or any pattern from the WAI — or both…)
- Docs added:
- including the "Sass" part using
scss-docsshortcode - in Cheatsheet / Cheatsheet RTL examples
- in /about/overview/#custom-components if it is a new Orange custom component
- in /gettings-started/introduction/#components if it is a new Orange custom component that requires JavaScript (and Popper)
- in /customize/overview#csps-and-embedded-svgs if it is a new Orange custom component that includes embedded SVGs in our CSS
- including the "Sass" part using
- Check (and fix) RTL version
- Run linters
- Run compilers
- Tests added for JS-side
- Run tests
- Cross-browser test:
- Firefox ESR
- Latest Edge, Chrome, Firefox, Safari
- iOS Safari
- Chrome & Firefox on Android
- Clean up the branch using
rebase -i - Commited with
feat(…): …message - Mention it in Migration Guide (if
back-from-v4): renamed variables, changes in markup requirement, etc.