Skip to content

Commit 06e6ce8

Browse files
committed
Review: Update checkbox item and switch item previews with padding and divider
1 parent d30625d commit 06e6ce8

File tree

2 files changed

+10
-2
lines changed

2 files changed

+10
-2
lines changed

core/src/main/java/com/orange/ouds/core/component/OudsCheckboxItem.kt

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ package com.orange.ouds.core.component
1515
import androidx.compose.foundation.interaction.Interaction
1616
import androidx.compose.foundation.interaction.MutableInteractionSource
1717
import androidx.compose.foundation.isSystemInDarkTheme
18+
import androidx.compose.foundation.layout.padding
1819
import androidx.compose.foundation.selection.triStateToggleable
1920
import androidx.compose.material.icons.Icons
2021
import androidx.compose.material.icons.filled.Call
@@ -28,6 +29,7 @@ import androidx.compose.ui.state.ToggleableState
2829
import androidx.compose.ui.tooling.preview.Preview
2930
import androidx.compose.ui.tooling.preview.PreviewLightDark
3031
import androidx.compose.ui.tooling.preview.PreviewParameter
32+
import androidx.compose.ui.unit.dp
3133
import com.orange.ouds.core.component.common.OudsError
3234
import com.orange.ouds.core.extensions.collectInteractionStateAsState
3335
import com.orange.ouds.core.utilities.LoremIpsumText
@@ -330,11 +332,13 @@ internal fun PreviewOudsCheckboxItemConstrainedMaxWidth(@PreviewParameter(OudsCo
330332
@Composable
331333
internal fun PreviewOudsCheckboxItemConstrainedMaxWidth(theme: OudsThemeContract, constrainedMaxWidth: Boolean) = OudsPreview(theme = theme) {
332334
OudsCheckboxItem(
335+
modifier = Modifier.padding(all = 10.dp),
333336
checked = true,
334337
label = "Label",
335338
onCheckedChange = {},
336339
icon = OudsControlItemIcon(imageVector = Icons.Filled.Call),
337-
constrainedMaxWidth = constrainedMaxWidth
340+
constrainedMaxWidth = constrainedMaxWidth,
341+
divider = true
338342
)
339343
}
340344

core/src/main/java/com/orange/ouds/core/component/OudsSwitchItem.kt

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ package com.orange.ouds.core.component
1515
import androidx.compose.foundation.interaction.Interaction
1616
import androidx.compose.foundation.interaction.MutableInteractionSource
1717
import androidx.compose.foundation.isSystemInDarkTheme
18+
import androidx.compose.foundation.layout.padding
1819
import androidx.compose.foundation.selection.toggleable
1920
import androidx.compose.material.icons.Icons
2021
import androidx.compose.material.icons.filled.Call
@@ -27,6 +28,7 @@ import androidx.compose.ui.semantics.semantics
2728
import androidx.compose.ui.tooling.preview.Preview
2829
import androidx.compose.ui.tooling.preview.PreviewLightDark
2930
import androidx.compose.ui.tooling.preview.PreviewParameter
31+
import androidx.compose.ui.unit.dp
3032
import com.orange.ouds.core.component.common.OudsError
3133
import com.orange.ouds.core.extensions.collectInteractionStateAsState
3234
import com.orange.ouds.core.utilities.LoremIpsumText
@@ -215,11 +217,13 @@ internal fun PreviewOudsSwitchItemConstrainedMaxWidth(@PreviewParameter(OudsCont
215217
@Composable
216218
internal fun PreviewOudsSwitchItemConstrainedMaxWidth(theme: OudsThemeContract, constrainedMaxWidth: Boolean) = OudsPreview(theme = theme) {
217219
OudsSwitchItem(
220+
modifier = Modifier.padding(all = 10.dp),
218221
checked = true,
219222
label = "Label",
220223
onCheckedChange = {},
221224
icon = OudsControlItemIcon(imageVector = Icons.Filled.Call),
222-
constrainedMaxWidth = constrainedMaxWidth
225+
constrainedMaxWidth = constrainedMaxWidth,
226+
divider = true
223227
)
224228
}
225229

0 commit comments

Comments
 (0)