Skip to content

Commit f5fd3de

Browse files
fix(OudsInputTag): wrong accessible hint (#1069)
* Add onClickLabel on OudsInputTag * Update Arabic wording * Update wording key --------- Co-authored-by: Pauline Auvray <[email protected]>
1 parent e7a3385 commit f5fd3de

File tree

4 files changed

+9
-0
lines changed

4 files changed

+9
-0
lines changed

core/src/main/java/com/orange/ouds/core/component/OudsInputTag.kt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,11 +36,13 @@ import androidx.compose.ui.Modifier
3636
import androidx.compose.ui.graphics.Color
3737
import androidx.compose.ui.platform.LocalConfiguration
3838
import androidx.compose.ui.res.painterResource
39+
import androidx.compose.ui.res.stringResource
3940
import androidx.compose.ui.semantics.Role
4041
import androidx.compose.ui.text.style.LineHeightStyle
4142
import androidx.compose.ui.tooling.preview.PreviewLightDark
4243
import androidx.compose.ui.unit.Dp
4344
import androidx.compose.ui.unit.dp
45+
import com.orange.ouds.core.R
4446
import com.orange.ouds.core.component.common.outerBorder
4547
import com.orange.ouds.core.extensions.InteractionState
4648
import com.orange.ouds.core.extensions.collectInteractionStateAsState
@@ -141,6 +143,7 @@ fun OudsInputTag(
141143
interactionSource = interactionSource,
142144
indication = InteractionValuesIndication(contentColor, backgroundColor, borderColor, borderWidth),
143145
onClick = onClick,
146+
onClickLabel = stringResource(R.string.core_inputTag_remove_a11y),
144147
role = Role.Button
145148
)
146149
.padding(vertical = tagTokens.spacePaddingBlockDefault.value)

core/src/main/res/values-ar/strings.xml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,8 @@
1313
<resources>
1414
<string name="core_common_loading_a11y">جاري التحميل</string>
1515

16+
<string name="core_inputTag_remove_a11y">يزيل</string>
17+
1618
<string name="core_topAppBar_backNavigationIcon_a11y">رجوع</string>
1719
<string name="core_topAppBar_closeNavigationIcon_a11y">إغلاق</string>
1820
<string name="core_topAppBar_menuNavigationIcon_a11y">القائمة</string>

core/src/main/res/values-fr/strings.xml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,8 @@
1313
<resources>
1414
<string name="core_common_loading_a11y">Chargement</string>
1515

16+
<string name="core_inputTag_remove_a11y">Supprimer</string>
17+
1618
<string name="core_topAppBar_backNavigationIcon_a11y">Retour</string>
1719
<string name="core_topAppBar_closeNavigationIcon_a11y">Fermer</string>
1820
<string name="core_topAppBar_menuNavigationIcon_a11y">Menu</string>

core/src/main/res/values/strings.xml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,8 @@
1313
<resources>
1414
<string name="core_common_loading_a11y">Loading</string>
1515

16+
<string name="core_inputTag_remove_a11y">Remove</string>
17+
1618
<string name="core_topAppBar_backNavigationIcon_a11y">Back</string>
1719
<string name="core_topAppBar_closeNavigationIcon_a11y">Close</string>
1820
<string name="core_topAppBar_menuNavigationIcon_a11y">Menu</string>

0 commit comments

Comments
 (0)