Skip to content

Commit e66b87a

Browse files
Fix deprecated mc call, add more logging on CI failure (#555)
* Tear down existing containers in CI & wait for buckets * Print logs on failure * Actually print logs * Post all available logs * Typo * Add `FOLLOW_LOGS` variable to print everything via `just logs` * Use updated `mc` command Per: minio/minio#21327 (comment) * Remove debug lines
1 parent 65089cb commit e66b87a

File tree

3 files changed

+7
-2
lines changed

3 files changed

+7
-2
lines changed

.github/workflows/pull_request.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,3 +32,7 @@ jobs:
3232
with:
3333
name: playwright-traces
3434
path: build/test-results/
35+
- if: ${{ failure() }}
36+
name: Print logs
37+
run: |
38+
FOLLOW_LOGS='' just logs

docker-compose.dev.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ services:
3131
entrypoint: >
3232
/bin/sh -c "
3333
sleep 5;
34-
/usr/bin/mc config host add myminio http://minio:9000 minio ${MINIO_ROOT_PASSWORD};
34+
/usr/bin/mc alias set myminio http://minio:9000 minio ${MINIO_ROOT_PASSWORD};
3535
/usr/bin/mc mb myminio/${S3_BUCKET_NAME};
3636
/usr/bin/mc anonymous set public myminio/${S3_BUCKET_NAME};
3737
exit 0;

justfile

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ COMPOSE_FILE := "--file=docker-compose.yml" + (
66
DC := "docker compose " + COMPOSE_FILE
77
RUN := DC + " run --rm"
88
RUN_WEB := RUN + " web"
9+
FOLLOW_LOGS := env("FOLLOW_LOGS", "-f")
910
set dotenv-load := false
1011
# Force just to hand down positional arguments so quoted arguments with spaces are
1112
# handled appropriately
@@ -42,7 +43,7 @@ down *args:
4243

4344
# Attach logs to all (or the specified) services
4445
logs *args:
45-
{{ DC }} logs -f {{ args }}
46+
{{ DC }} logs {{ FOLLOW_LOGS }} {{ args }}
4647

4748
# Pull all docker images
4849
pull:

0 commit comments

Comments
 (0)