#8525: Upgrading client-side libraries (#8848)

Co-authored-by: HermesSbicego-Laser <hermes.sbicego@laser-group.com>
Co-authored-by: Alessandro Agostini <alessandro.agostini@laser-group.com>

Author: 3 people

src/Gulpfile.js

@@ -1,11 +1,8 @@
-var fs = require("fs"),
-    glob = require("glob"),
+var glob = require("glob"),
     path = require("path-posix"),
     merge = require("merge-stream"),
     gulp = require("gulp"),
     gulpif = require("gulp-if"),
-    print = require("gulp-print"),
-    debug = require("gulp-debug"),
     newer = require("gulp-newer"),
     plumber = require("gulp-plumber"),
     sourcemaps = require("gulp-sourcemaps"),
@@ -63,7 +60,7 @@ gulp.task("watch", function () {
                 else
                     console.log("Asset file '" + event.path + "' was " + event.type + ", rebuilding asset group.");
                 var doRebuild = true;
-                var task = createAssetGroupTask(assetGroup, doRebuild);
+                createAssetGroupTask(assetGroup, doRebuild);
             });
         }
         createWatcher();
@@ -150,7 +147,8 @@ function buildCssPipeline(assetGroup, doConcat, doRebuild) {
             newer({
                 dest: doConcat ? assetGroup.outputPath : assetGroup.outputDir,
                 ext: doConcat ? null : ".css",
-                extra: assetGroup.manifestPath // Force a rebuild of this asset group is the asset manifest file itself is newer than the output(s).
+                // Force a rebuild of this asset group is the asset manifest file itself is newer than the output(s).
+                extra: assetGroup.manifestPath
             })
         ))
         .pipe(plumber())
@@ -184,7 +182,8 @@ function buildCssPipeline(assetGroup, doConcat, doRebuild) {
             newer({
                 dest: doConcat ? assetGroup.outputPath : assetGroup.outputDir,
                 ext: doConcat ? null : ".css",
-                extra: assetGroup.manifestPath // Force a rebuild of this asset group is the asset manifest file itself is newer than the output(s).
+                // Force a rebuild of this asset group is the asset manifest file itself is newer than the output(s).
+                extra: assetGroup.manifestPath
             })
         ))
         .pipe(plumber())
@@ -197,11 +196,7 @@ function buildCssPipeline(assetGroup, doConcat, doRebuild) {
         .pipe(postcss([
             autoprefixer({ browsers: ["last 2 versions"] })
         ]))
-        .pipe(header(
-            "/*\n" +
-            "** NOTE: This file is generated by Gulp and should not be edited directly!\n" +
-            "** Any changes made directly to this file will be overwritten next time its asset group is processed by Gulp.\n" +
-            "*/\n\n"))
+        .pipe(header(getOutputFileHeader()))
         .pipe(gulpif(generateSourceMaps, sourcemaps.write()))
         .pipe(eol())
         .pipe(rename(function (path) {
@@ -224,25 +219,23 @@ function buildJsPipeline(assetGroup, doConcat, doRebuild) {
         generateSourceMaps = false;
     var typeScriptOptions = { allowJs: true, noImplicitAny: true, noEmitOnError: true, module: 'amd' };
     if (assetGroup.typeScriptOptions)
-        typeScriptOptions = Object.assign(typeScriptOptions, assetGroup.typeScriptOptions); // Merge override options from asset group if any.
+        // Merge override options from asset group if any.
+        typeScriptOptions = Object.assign(typeScriptOptions, assetGroup.typeScriptOptions);
     if (doConcat)
         typeScriptOptions.outFile = assetGroup.outputFileName;
     return gulp.src(assetGroup.inputPaths)
         .pipe(gulpif(!doRebuild,
             newer({
                 dest: doConcat ? assetGroup.outputPath : assetGroup.outputDir,
                 ext: doConcat ? null : ".js",
-                extra: assetGroup.manifestPath // Force a rebuild of this asset group is the asset manifest file itself is newer than the output(s).
+                // Force a rebuild of this asset group is the asset manifest file itself is newer than the output(s).
+                extra: assetGroup.manifestPath
             })
         ))
         .pipe(plumber())
         .pipe(gulpif(generateSourceMaps, sourcemaps.init()))
-        .pipe(typescript(typeScriptOptions))
-        .pipe(header(
-            "/*\n" +
-            "** NOTE: This file is generated by Gulp and should not be edited directly!\n" +
-            "** Any changes made directly to this file will be overwritten next time its asset group is processed by Gulp.\n" +
-            "*/\n\n"))
+        .pipe(typescript(typeScriptOptions)) // TypeScript doesn't support JavaScript modules.
+        .pipe(header(getOutputFileHeader()))
         .pipe(gulpif(generateSourceMaps, sourcemaps.write()))
         .pipe(eol())
         .pipe(rename(function (path) {
@@ -260,3 +253,12 @@ function buildJsPipeline(assetGroup, doConcat, doRebuild) {
         }))
         .pipe(gulp.dest(assetGroup.outputDir));
 }
+
+function getOutputFileHeader() {
+    return (
+        "/*\n" +
+        "** NOTE: This file is generated by Gulp and should not be edited directly!\n" +
+        "** Any changes made directly to this file will be overwritten next time its asset group is processed by Gulp.\n" +
+        "*/\n\n"
+    );
+}