InvalidOperationException thrown from OrchardCore.ContentTypes.LuceneRecipeEventHandler

[DotCat1985]

Hi,
When I install a recipe on OC 2.1.5, I receive the following exception, even if OrchardCore.Search.Lucene module is disabled.

2025-02-17 21:38:03||0HNAFIBSFG850:00000001|OrchardCore.Recipes.Services.RecipeExecutor|Error|IRecipeEventHandler thrown from OrchardCore.ContentTypes.LuceneRecipeEventHandler by InvalidOperationException
System.InvalidOperationException: The node already has a parent.
at System.Text.Json.ThrowHelper.ThrowInvalidOperationException_NodeAlreadyHasParent()
at System.Text.Json.Nodes.JsonNode.AssignParent(JsonNode parent)
at System.Text.Json.Nodes.JsonObject.SetItem(String propertyName, JsonNode value)
at OrchardCore.ContentTypes.LuceneRecipeEventHandler.RecipeStepExecutingAsync(RecipeExecutionContext context)
at OrchardCore.Recipes.Services.RecipeExecutor.<>c.b__8_1(IRecipeEventHandler handler, RecipeExecutionContext recipeStep)
at OrchardCore.Modules.InvokeExtensions.InvokeAsync[TEvents,T1](IEnumerable1 events, Func3 dispatch, T1 arg1, ILogger logger)

How could I solve this issue?

[Piedone]

Can you tell more about your recipe?

LuceneRecipeEventHandler is always enabled with the Content Types module because it fixes an older mistake (it'll be removed in future versions).

[DotCat1985]

Here is the recipe. The exception occurs when I setup this recipe (I use OrchardCore 2.1.6).

{
  "name": "WEBSITE",
  "displayName": "WEBSITE",
  "website": "[js: base_url()]",
  "issetuprecipe": true,
  "tags": [
    ...
  ],
  "variables": {
    ...
  },
  "steps": [
    {
      "name": "feature",
      "disable": [
        "OrchardCore.Deployment.Remote",
        "OrchardCore.DynamicCache",
        "OrchardCore.Feeds",
        "OrchardCore.Search.Lucene",
        "OrchardCore.Markdown",
        "OrchardCore.Queries",
        "OrchardCore.Taxonomies",
        "OrchardCore.MiniProfiler",
        "DotCat.OrchardCore.Liquid"
      ],
      "enable": [
        // SaaS
        "OrchardCore.HomeRoute",
        "OrchardCore.Admin",
        "OrchardCore.Diagnostics",
        "OrchardCore.Features",
        "OrchardCore.Navigation",
        "OrchardCore.Recipes",
        "OrchardCore.Resources",
        "OrchardCore.Roles",
        "OrchardCore.Settings",
        "OrchardCore.Themes",
        "OrchardCore.Users",
        // Content Management
        "OrchardCore.AdminMenu",
        "OrchardCore.Html",
        "OrchardCore.ContentFields",
        "OrchardCore.Contents",
        "OrchardCore.ContentTypes",
        "OrchardCore.CustomSettings",
        "OrchardCore.Flows",
        "OrchardCore.Forms",
        "OrchardCore.Indexing",
        "OrchardCore.Layers",
        "OrchardCore.Lists",
        "OrchardCore.Liquid",
        "OrchardCore.Media",
        "OrchardCore.Menu",
        "OrchardCore.Scripting",
        "OrchardCore.Title",
        "OrchardCore.Templates",
        "OrchardCore.Widgets",
        "OrchardCore.Workflows.Http",
        "OrchardCore.ContentLocalization.ContentCulturePicker",
        "OrchardCore.ContentLocalization.Sitemaps",
        "OrchardCore.Deployment",
        "OrchardCore.HealthChecks",
        "OrchardCore.Https",
        "OrchardCore.ResponseCompression",
        "OrchardCore.ReCaptcha.Users",
        "OrchardCore.Seo",
        "OrchardCore.BackgroundTasks",
        "OrchardCore.PublishLater",
        "OrchardCore.Tenants",
        "OrchardCore.Email.Smtp",
        "OrchardCore.Users",
        "OrchardCore.Users.ResetPassword",
        "OrchardCore.UrlRewriting",
        "OrchardCore.AuditTrail",
        // External modules

        // Custom modules
        "DotCat.OrchardCore.CustomCultureProvider",
        "DotCat.OrchardCore.Carousel",
        "DotCat.OrchardCore.FileManager",
        "DotCat.OrchardCore.Liquid.TryItEditor",
        "DotCat.OrchardCore.Matomo",
        "DotCat.OrchardCore.MediaPlayer",
        "DotCat.OrchardCore.ReCaptcha",
        "DotCat.OrchardCore.Scripting",
        "DotCat.OrchardCore.BackgroundTasks",
        "DotCat.OrchardCore.Themes.Shared",
        // Themes
        "Bulky",
        "TheAdmin",
        "SafeMode",
        // Recipe module
        "WebSite"
      ]
    },
    {
      "name": "themes",
      "admin": "TheAdmin",
      "site": "Bulky"
    },
    {
      "name": "ContentDefinition",
      "ContentTypes": [
        ...
      ],
      "ContentParts": [
        ...
      ]
    },
    {
      "name": "content",
      "Data": [
        ...
      ]
    },
    {
      "name": "layers",
      "Layers": [
        ...
      ]
    },
    
    {
      "name": "media",
      "Files": [
        ...
      ]
    },
    {
      "name": "WorkflowType",
      "data": [
        ...
      ]
    },
    {
      "name": "Sitemaps",
      "data": [
        ...
      ]
    },
    {
      "name": "UrlRewriting",
      "Rules": [
        ...
      ]
    },
    {
      "name": "Settings",
      ...
      
    },
    {
      "name": "Roles",
      "Roles": [
        ...
      ]
    }
  ]
}

[Piedone]

What's in the ContentDefinition step? That's what this fails on. You can check it out and look for hints here:

OrchardCore/src/OrchardCore.Modules/OrchardCore.ContentTypes/Recipes/LuceneRecipeEventHandler.cs

Lines 25 to 70 in a266cf9

	if (context.Name == "ReplaceContentDefinition" || context.Name == "ContentDefinition")
	{
	var step = context.Step.ToObject<ContentDefinitionStepModel>();
	foreach (var contentType in step.ContentTypes)
	{
	foreach (var partDefinition in contentType.ContentTypePartDefinitionRecords)
	{
	if (partDefinition.Settings != null)
	{
	if (partDefinition.Settings.TryGetPropertyValue("ContentIndexSettings", out var existingPartSettings) &&
	!partDefinition.Settings.ContainsKey("LuceneContentIndexSettings"))
	{
	partDefinition.Settings.Add("LuceneContentIndexSettings", existingPartSettings);
	}
	partDefinition.Settings.Remove("ContentIndexSettings");
	}
	}
	}
	foreach (var partDefinition in step.ContentParts)
	{
	if (partDefinition.Settings != null)
	{
	if (partDefinition.Settings.TryGetPropertyValue("ContentIndexSettings", out var existingPartSettings))
	{
	partDefinition.Settings["LuceneContentIndexSettings"] = existingPartSettings;
	}
	partDefinition.Settings.Remove("ContentIndexSettings");
	foreach (var fieldDefinition in partDefinition.ContentPartFieldDefinitionRecords)
	{
	if (fieldDefinition.Settings != null)
	{
	if (fieldDefinition.Settings.TryGetPropertyValue("ContentIndexSettings", out var existingFieldSettings))
	{
	fieldDefinition.Settings["LuceneContentIndexSettings"] = existingFieldSettings;
	}
	fieldDefinition.Settings.Remove("ContentIndexSettings");
	}
	}
	}
	}

[DotCat1985]

I solved my issue by checking the CustomSettings and the ContentDefinition steps.
Thank you for support!