MediaField - Attached - return model error if file does not exist

[PiemP]

I'm having a problem these days with the MediaField using the Attached editor. Sometimes files fail to upload, and the code logs an error in the logging file..

OrchardCore/src/OrchardCore.Modules/OrchardCore.Media/Services/AttachedMediaFieldFileService.cs

Lines 98 to 102 in d3b2e0f

	if (fileInfo == null)
	{
	_logger.LogError("A file with the path '{Path}' does not exist.", item.Path);
	return;
	}

I would like to change this behavior and return an AggregateException that can contains one or more FileNotFoundException. I could then intercept this in MediaFieldDisplayDriver and return a model error that asks the user to re-upload the file(s).

Would this be an acceptable change?
Thank you.

[Piedone]

I'd say that throwing an exception when the file fails to upload would be a good change, yes (since it's clearly an error). But can you find out why the files fail to upload?

[PiemP]

I've observed that I'm doing a couple of application pool recycles per week (and sometimes I do recycles when I release a fix), and I'm also using a very long session timeout. Since users have to insert a lot of data and sometimes they don't have all the data when they perform this operation, I suspect this might be the source of the problem, but I'm not completely sure. In order to understand if there are other causes, I'll have to investigate the code further.

[Piedone]

Sorry, I'm not really following.

[PiemP]

A user starts editing a content item and uploads a file. If they don't have all the data required to submit the content item and leave the page open, the file can be lost. This happens if the server is restarted or the application pool is recycled for any reason before the user completes the submission. When the user returns to finish editing the content item, the uploaded file is no longer available.

[Piedone]

Oh I see. This is because temp files are cleaned up on tenant start:

OrchardCore/src/OrchardCore.Modules/OrchardCore.Media/Services/TempDirCleanerService.cs

Line 25 in f3bac6b

public override async Task ActivatedAsync()

[PiemP]

yes, is the only hypothesis that i have for now. I have open a PR #18263.

[PiemP]

fixed by #18263