Skip to content

Media Gallery Vue 3 #14256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 113 commits into
base: main
Choose a base branch
from
Draft

Media Gallery Vue 3 #14256

wants to merge 113 commits into from

Conversation

Skrypt
Copy link
Contributor

@Skrypt Skrypt commented Sep 1, 2023 •
edited
Loading

Work in progress.

The goal here is first to migrate all the components and SFC to Vue 3. We cannot use new Vue with Vue 3 so some components will need to be refactored.

Also, the components dynamic loading methods need to be removed in favor of using a wrapping component with props simply. Favor usage of Vite with Vue 3 apps/components.

Tasks

  • Migrate Media Library to Vue 3
  • Migrate MediaField Media Picker to Vue 3
  • Make Media Library (standalone) by using a different modal than the Bootstrap one. https://vue-final-modal.org/
  • Make Media Library (standalone) by using display Flex and Grid simply instead of using Bootstrap classes for styling.
  • Check if it MediaApplication constraining extensions based on the first instantiated media field #15569 is fixed by this; if yes, close it.
  • Check for other Media issues that might be fixed by this.
  • Make thumbnail view optional
  • Add a Swagger/OpenApi module for Media Gallery ApiController
  • Normalize API requests responses. Make use of ProducesResponseType in Api controller.
  • Add SignalR notifier. Which means we need to have a SignalR client implementation.
  • Upgrade Azure Blob storage to latest

Fixes #7110.

Optional

Consider refactoring upload bits by using Uppy instead of JQuery FileUpload as it is now archived and old.

See:

https://uppy.io/
https://tus.io/
https://github.com/tusdotnet/tusdotnet
https://www.ietf.org/archive/id/draft-tus-httpbis-resumable-uploads-protocol-00.html

agriffard and others added 14 commits March 21, 2022 19:05
@agriffard
Vue 3.2.31
09804ae
@Skrypt
Merge branch 'main' into skrypt/vue3.2.31
f2765b3 
# Conflicts:
#	src/docs/resources/libraries/README.md
@Skrypt
Merge branch 'main' into skrypt/vue3.2.31
71e5e0f 
# Conflicts:
#	src/OrchardCore.Modules/OrchardCore.Resources/package-lock.json
#	src/OrchardCore.Modules/OrchardCore.Resources/package.json
@Skrypt
wip
1d93b9b
@Skrypt
Merge branch 'main' into skrypt/vue3.2.31
ba2180f 
# Conflicts:
#	src/OrchardCore.Modules/OrchardCore.Media/wwwroot/Scripts/media.js
#	src/OrchardCore.Modules/OrchardCore.Media/wwwroot/Scripts/media.min.js
#	src/OrchardCore.Modules/OrchardCore.Resources/package-lock.json
#	src/OrchardCore.Modules/OrchardCore.Resources/package.json
@Skrypt
Automate npm install for new MediaApp
a31d76d
@Skrypt
Merge branch 'main' into skrypt/vue3.2.31
7cabb99 
# Conflicts:
#	src/OrchardCore.Modules/OrchardCore.Media/wwwroot/Scripts/media.js
#	src/OrchardCore.Modules/OrchardCore.Resources/package-lock.json
#	src/OrchardCore.Modules/OrchardCore.Resources/package.json
#	src/OrchardCore.Modules/OrchardCore.Resources/wwwroot/Scripts/trumbowyg-plugins.js
#	src/OrchardCore.Modules/OrchardCore.Resources/wwwroot/Scripts/trumbowyg-plugins.min.js
#	src/OrchardCore.Modules/OrchardCore.Resources/wwwroot/Styles/trumbowyg-plugins.css
#	src/OrchardCore.Modules/OrchardCore.Resources/wwwroot/Styles/trumbowyg-plugins.min.css
#	src/docs/resources/libraries/README.md
@Skrypt
Fix gulp build
d17cb87
@Skrypt
Clean assets
99a26fc
@Skrypt
Merge branch 'main' into skrypt/vue3.2.31
c371d38 
# Conflicts:
#	src/OrchardCore.Modules/OrchardCore.Media/wwwroot/Scripts/media.js
#	src/OrchardCore.Modules/OrchardCore.Media/wwwroot/Scripts/media.min.js
@Skrypt
Reproducible builds
4f1d1db
@Skrypt
Reproducible builds (trumbowyg)
3f4b857
@Skrypt
Move jquery-ui and vue 2 to vendor folder
4ac65cb
@Skrypt
Merge branch 'main' into skrypt/vue3.2.31
680af63
@Skrypt Skrypt mentioned this pull request Sep 1, 2023
Closed
@Skrypt Skrypt added this to the 1.x milestone Sep 1, 2023
@Skrypt Skrypt self-assigned this Sep 1, 2023
@github-actions GitHub Actions
Copy link
Contributor

This pull request has merge conflicts. Please resolve those before requesting a review.

@Skrypt
Merge branch 'main' into skrypt/vue-3
2be146d 
# Conflicts:
#	yarn.lock
@Piedone Piedone mentioned this pull request Feb 25, 2025
Merged
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 3, 2025

This pull request has merge conflicts. Please resolve those before requesting a review.

@Skrypt Skrypt modified the milestones: 2.x, 3.x Mar 3, 2025
Skrypt added 6 commits March 3, 2025 18:05
@Skrypt
Merge branch 'main' into skrypt/vue-3
b3c40e0 
# Conflicts:
#	.scripts/assets-manager/package.json
#	src/OrchardCore.Modules/OrchardCore.Resources/Assets.json
#	src/OrchardCore.Modules/OrchardCore.Resources/ResourceManagementOptionsConfiguration.cs
#	src/OrchardCore.Modules/OrchardCore.Resources/wwwroot/Scripts/nouislider/nouislider.min.css
#	src/OrchardCore.Modules/OrchardCore.Resources/wwwroot/Scripts/nouislider/nouislider.min.js
#	src/OrchardCore.Modules/OrchardCore.Resources/wwwroot/Scripts/nouislider/nouislider.min.mjs
#	src/OrchardCore.Modules/OrchardCore.Resources/wwwroot/Scripts/nouislider/nouislider.mjs
#	src/OrchardCore.Modules/OrchardCore.Resources/wwwroot/Scripts/vue-multiselect.min.js
#	src/OrchardCore.Modules/OrchardCore.Resources/wwwroot/Vendor/jquery-ui-1.12.1/jquery-ui-i18n.js
#	yarn.lock
@Skrypt
revert some changes
6de7ae2
@Skrypt
update assets
349fa8d
@Skrypt
yarn clean
2ee3906
@Skrypt
revert file add
ba1b255
@Skrypt
revert
3996273
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 8, 2025

This pull request has merge conflicts. Please resolve those before requesting a review.

@Skrypt Skrypt changed the title Vue 3 Media Gallery Vue 3 Jun 11, 2025
@Skrypt Skrypt mentioned this pull request Jun 11, 2025
Open
@github-actions GitHub Actions
Copy link
Contributor

This pull request has merge conflicts. Please resolve those before requesting a review.

@sebastienros sebastienros mentioned this pull request Aug 28, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Skrypt Skrypt

Labels
merge conflict
Projects
None yet
Milestone
3.x
Development

Successfully merging this pull request may close these issues.

Upgrade Vue to 3.0
5 participants
@Skrypt @Piedone @MikeAlhayek @deanmarcussen @agriffard