clean up: remove delta-dump related configs / args

Author: Essoz

mldaikon/collect_trace.py

@@ -359,24 +359,6 @@ def is_path_md_output_dir(output_dir: str) -> bool:
         default="hash",
         help="The format for dumping tensors. Choose from 'hash'(default), 'stats' or 'full'.",
     )
-    parser.add_argument(
-        "--delta-dump",
-        type=bool,
-        default=proxy_config.delta_dump_config["delta_dump"],
-        help="Only dump the changed part of the object",
-    )
-    parser.add_argument(
-        "--delta-dump-meta-var",
-        type=bool,
-        default=proxy_config.delta_dump_config["delta_dump_meta_var"],
-        help="Only dump the changed part of the meta_var",
-    )
-    parser.add_argument(
-        "--delta-dump-attributes",
-        type=bool,
-        default=proxy_config.delta_dump_config["delta_dump_attributes"],
-        help="Only dump the changed part of the attribute",
-    )
     parser.add_argument(
         "--enable-C-level-observer",
         type=bool,
@@ -444,20 +426,12 @@ def is_path_md_output_dir(output_dir: str) -> bool:
         # set the chosen one to True
         tensor_dump_format[f"dump_tensor_{args.tensor_dump_format}"] = True
 
-    # set up delta_dump_config
-    delta_dump_config: dict[str, int | bool] = {}
-    for configs in ["delta_dump", "delta_dump_meta_var", "delta_dump_attributes"]:
-        if proxy_config.delta_dump_config[configs] != getattr(args, configs):
-            delta_dump_config[configs] = getattr(args, configs)
-            print(f"Setting {configs} to {getattr(args, configs)}")
-
     auto_observer_config = proxy_config.auto_observer_config
     # call into the instrumentor
     adjusted_proxy_config: list[dict] = [
         auto_observer_config,  # Ziming: add auto_observer_config for proxy_wrapper
         proxy_basic_config,  # Ziming: add proxy_basic_config for proxy_wrapper
         tensor_dump_format,  # Ziming: add tensor_dump_format for proxy_wrapper
-        delta_dump_config,  # Ziming: add delta_dump_config for proxy_wrapper
     ]
 
     # if args.disable_scan_proxy_in_args:

mldaikon/instrumentor/source_file.py

@@ -327,7 +327,6 @@ def instrument_model_tracker_proxy(
     auto_observer_config: dict[str, int | bool | str] = adjusted_proxy_config[0]
     proxy_basic_config: dict[str, int | bool | str] = adjusted_proxy_config[1]
     tensor_dump_format: dict[str, int | bool | str] = adjusted_proxy_config[2]
-    delta_dump_config: dict[str, int | bool | str] = adjusted_proxy_config[3]
 
     ## proxy configs
     proxy_start_code = ""
@@ -348,11 +347,7 @@ def instrument_model_tracker_proxy(
 from mldaikon.proxy_wrapper.proxy_config import tensor_dump_format
 tensor_dump_format.update({tensor_dump_format})
 """
-    if delta_dump_config:
-        proxy_start_code += f"""
-from mldaikon.proxy_wrapper.proxy_config import delta_dump_config
-delta_dump_config.update({delta_dump_config})
-"""
+
     proxy_start_code += """
 from mldaikon.proxy_wrapper.proxy import Proxy
 """

mldaikon/proxy_wrapper/dumper.py

@@ -5,11 +5,7 @@
 from mldaikon.instrumentor.tracer import TraceLineType
 from mldaikon.instrumentor.tracer import get_meta_vars as tracer_get_meta_vars
 from mldaikon.proxy_wrapper.proxy_basics import is_proxied
-from mldaikon.proxy_wrapper.proxy_config import delta_dump_config, primitive_types
-
-delta_dump = delta_dump_config["delta_dump"]
-delta_dump_attributes = delta_dump_config["delta_dump_attributes"]
-delta_dump_meta_var = delta_dump_config["delta_dump_meta_var"]
+from mldaikon.proxy_wrapper.proxy_config import primitive_types
 
 
 class Singleton(type):
@@ -87,60 +83,14 @@ def dump_attributes(obj, value):
         value = obj_dict["_obj"]
 
     result = convert_var_to_dict(value)
-
-    if delta_dump and delta_dump_attributes:
-        # if they have common keys, only dump when old value is different from the new value
-        old_value = obj.__dict__.get("old_value", {})
-        # store the old value of the attribute
-        store_old_value(obj, result)
-        if old_value is not None:
-            result = {
-                key: value
-                for key, value in result.items()
-                if key not in old_value or old_value[key] != value
-            }
     return result
 
 
 def get_meta_vars(obj):
     all_meta_vars = tracer_get_meta_vars()
 
-    if delta_dump and delta_dump_meta_var:
-        # if they have common keys, only dump when old value is different from the new value
-        old_value = obj.__dict__.get("old_meta_vars", {})
-        # store the old value of the meta_var
-        store_old_value_meta_var(obj, meta_vars=all_meta_vars)
-        if old_value is not None:
-            all_meta_vars = {
-                key: value
-                for key, value in all_meta_vars.items()
-                if key not in old_value or old_value[key] != value
-            }
     return all_meta_vars
 
 
 def concat_dicts(dict1, dict2):
     return {**dict1, **dict2}
-
-
-def store_old_value(obj, result):
-    # set the current snapshot as the "old_value" attribute of the object
-    if delta_dump:
-        obj_dict = obj.__dict__
-        assert is_proxied(obj), "The object is not a proxied object"
-        if delta_dump_attributes:
-            import copy
-
-            obj_dict["old_value"] = copy.deepcopy(result)
-
-
-def store_old_value_meta_var(obj, meta_vars=None):
-    # save the current meta_var of the function stack
-    if delta_dump:
-        obj_dict = obj.__dict__
-        assert is_proxied(obj), "The object is not a proxied object"
-        if delta_dump_meta_var:
-            if meta_vars is None:
-                obj_dict["old_meta_vars"] = get_meta_vars(obj)
-            else:
-                obj_dict["old_meta_vars"] = meta_vars

mldaikon/proxy_wrapper/proxy_config.py

@@ -3,11 +3,6 @@
 proxy_log_dir = "proxy_log.json"  # FIXME: ad-hoc
 debug_mode = False
 
-delta_dump_config = {
-    "delta_dump": False,  # only dump the changed part of the object (if this is set to be False, we would dump the whole object no matter what values delta_dump_meta_var and delta_dump_attribute are)
-    "delta_dump_meta_var": True,  # only dump the changed part of the meta_var
-    "delta_dump_attributes": True,  # only dump the changed part of the attribute
-}
 tensor_dump_format = {
     "dump_tensor_hash": True,  # dump the hash of the tensor
     "dump_tensor_stats": False,  # dump the statistics of tensor {min, max, mean, shape}