fixup dupe bug causing functionality

Author: Oribuin

src/main/java/xyz/oribuin/eternaltags/gui/PluginMenu.java

@@ -342,7 +342,7 @@ public final void searchTags(Player player, BaseGui gui) {
                 event -> {
                     event.setCancelled(true);
                     String message = event.getMessage().toLowerCase();
-                    this.sync(() -> MenuProvider.get(TagsGUI.class).open(player, tag -> tag.getId().contains(message) || tag.getName().contains(message)
+                    this.sync(() -> MenuProvider.get(TagsGUI.class).open(event.getPlayer(), tag -> tag.getId().contains(message) || tag.getName().contains(message)
                     ));
                 },
                 60,

src/main/java/xyz/oribuin/eternaltags/gui/menu/FavouritesGUI.java

@@ -169,14 +169,14 @@ private void addTags(@NotNull BaseGui gui, @NotNull Player player) {
                 // Make sure the player has permission to use the tag
                 if (!this.manager.canUseTag(player, tag)) {
                     this.locale.sendMessage(player, "no-permission");
-                    gui.close(player);
+                    this.close(gui, player);
                     return;
                 }
 
                 // Run the tag actions
                 if (!tagActions.isEmpty()) {
                     this.runActions(tagActions, event, this.getTagPlaceholders(tag, player));
-                    gui.close(player);
+                    this.close(gui, player);
                     return;
                 }
 
@@ -189,7 +189,7 @@ private void addTags(@NotNull BaseGui gui, @NotNull Player player) {
 
                 // Set the tag
                 this.setTag(player, tag);
-                gui.close(player);
+                this.close(gui, player);
             };
 
             // If the tag is already in the cache, use that instead of creating a new one.

src/main/java/xyz/oribuin/eternaltags/gui/menu/TagsGUI.java

@@ -188,15 +188,15 @@ private void addTags(@NotNull BaseGui gui, @NotNull Player player, @Nullable Pre
             paginatedGui.clearPageItems();
 
         Map<ClickType, List<Action>> tagActions = this.getTagActions();
-        Sound tagSound = TagsUtils.getEnum(Sound.class, this.config.getString("tag-item.sound", ""));
+//        Sound tagSound = TagsUtils.getEnum(Sound.class, this.config.getString("tag-item.sound", ""));
 
         this.getTags(player, filter).forEach(tag -> {
             GuiAction<InventoryClickEvent> action = event -> {
 
                 // Check if the player has permission to use the tag
                 if (!this.manager.canUseTag(player, tag)) {
                     this.locale.sendMessage(player, "no-permission");
-                    gui.close(player);
+                    this.close(gui, player);
                     return;
                 }
 
@@ -207,9 +207,9 @@ private void addTags(@NotNull BaseGui gui, @NotNull Player player, @Nullable Pre
                 }
 
                 // Play the sound if it's not null
-                if (tagSound != null) {
-                    player.playSound(player.getLocation(), tagSound, 75, 1);
-                }
+//                if (tagSound != null) {
+//                    player.playSound(player.getLocation(), tagSound, 75, 1);
+//                }
 
                 // If the player is shift clicking, toggle the favourite status of the tag
                 if (event.isShiftClick()) {
@@ -220,7 +220,7 @@ private void addTags(@NotNull BaseGui gui, @NotNull Player player, @Nullable Pre
 
                 // Set the tag if the player is not shift clicking
                 this.setTag(player, tag);
-                gui.close(player);
+                this.close(gui, player);
             };
 
             // If the tag is already in the cache, use that instead of creating a new one.