Add tests

Author: shahthepro

contracts/test/strategies/crosschain/_crosschain-helpers.js

@@ -147,18 +147,27 @@ const encodeCCTPMessage = (
   return `0x${versionStr}${sourceDomainStr}${empty18Bytes}${senderStr}${recipientStr}${empty20Bytes}${messageBodyStr}`;
 };
 
-const encodeBurnMessageBody = (sender, recipient, amount, hookData) => {
+const encodeBurnMessageBody = (
+  sender,
+  recipient,
+  burnToken,
+  amount,
+  hookData
+) => {
   const senderEncoded = ethers.utils.defaultAbiCoder
     .encode(["address"], [sender])
     .slice(2);
   const recipientEncoded = ethers.utils.defaultAbiCoder
     .encode(["address"], [recipient])
     .slice(2);
+  const burnTokenEncoded = ethers.utils.defaultAbiCoder
+    .encode(["address"], [burnToken])
+    .slice(2);
   const amountEncoded = ethers.utils.defaultAbiCoder
     .encode(["uint256"], [amount])
     .slice(2);
   const encodedHookData = hookData.slice(2);
-  return `0x00000001${empty16Bytes}${recipientEncoded}${amountEncoded}${senderEncoded}${empty16Bytes.repeat(
+  return `0x00000001${burnTokenEncoded}${recipientEncoded}${amountEncoded}${senderEncoded}${empty16Bytes.repeat(
     3
   )}${encodedHookData}`;
 };

contracts/test/strategies/crosschain/crosschain-master-strategy.mainnet.fork-test.js

@@ -316,6 +316,7 @@ describe("ForkTest: CrossChainMasterStrategy", function () {
       const burnPayload = encodeBurnMessageBody(
         crossChainMasterStrategy.address,
         crossChainMasterStrategy.address,
+        addresses.base.USDC,
         usdcUnits("2342"),
         balancePayload
       );
@@ -493,5 +494,57 @@ describe("ForkTest: CrossChainMasterStrategy", function () {
         await crossChainMasterStrategy.remoteStrategyBalance();
       expect(remoteStrategyBalanceAfter).to.eq(remoteStrategyBalanceBefore);
     });
+
+    it("Should revert if the burn token is not peer USDC", async function () {
+      const { crossChainMasterStrategy, strategist } = fixture;
+
+      if (await crossChainMasterStrategy.isTransferPending()) {
+        // Skip if there's a pending transfer
+        console.log(
+          "Skipping balance check message fork test because there's a pending transfer"
+        );
+        return;
+      }
+
+      // set an arbitrary remote strategy balance
+      await setRemoteStrategyBalance(
+        crossChainMasterStrategy,
+        usdcUnits("123456")
+      );
+
+      const lastNonce = (
+        await crossChainMasterStrategy.lastTransferNonce()
+      ).toNumber();
+
+      // Replace transmitter to mock transmitter
+      await replaceMessageTransmitter();
+
+      // Build check balance payload
+      const balancePayload = encodeBalanceCheckMessageBody(
+        lastNonce,
+        usdcUnits("12345"),
+        true // withdrawal confirmation
+      );
+      const burnPayload = encodeBurnMessageBody(
+        crossChainMasterStrategy.address,
+        crossChainMasterStrategy.address,
+        addresses.mainnet.WETH, // Not peer USDC
+        usdcUnits("2342"),
+        balancePayload
+      );
+      const message = encodeCCTPMessage(
+        6,
+        addresses.CCTPTokenMessengerV2,
+        addresses.CCTPTokenMessengerV2,
+        burnPayload
+      );
+
+      // Relay the message with fake attestation
+      const tx = crossChainMasterStrategy
+        .connect(strategist)
+        .relay(message, "0x");
+
+      await expect(tx).to.be.revertedWith("Invalid burn token");
+    });
   });
 });

contracts/test/strategies/crosschain/crosschain-remote-strategy.base.fork-test.js

@@ -143,6 +143,7 @@ describe("ForkTest: CrossChainRemoteStrategy", function () {
     const burnPayload = encodeBurnMessageBody(
       crossChainRemoteStrategy.address,
       crossChainRemoteStrategy.address,
+      addresses.mainnet.USDC,
       depositAmount,
       depositPayload
     );
@@ -246,4 +247,40 @@ describe("ForkTest: CrossChainRemoteStrategy", function () {
     );
     expect(balanceAfter).to.approxEqual(expectedBalance);
   });
+
+  it("Should revert if the burn token is not peer USDC", async function () {
+    const { crossChainRemoteStrategy, strategist } = fixture;
+
+    const nonceBefore = await crossChainRemoteStrategy.lastTransferNonce();
+
+    const depositAmount = usdcUnits("1234.56");
+
+    // Replace transmitter to mock transmitter
+    await replaceMessageTransmitter();
+
+    const nextNonce = nonceBefore.toNumber() + 1;
+
+    // Build deposit message
+    const depositPayload = encodeDepositMessageBody(nextNonce, depositAmount);
+    const burnPayload = encodeBurnMessageBody(
+      crossChainRemoteStrategy.address,
+      crossChainRemoteStrategy.address,
+      addresses.base.WETH, // Not peer USDC
+      depositAmount,
+      depositPayload
+    );
+    const message = encodeCCTPMessage(
+      0,
+      addresses.CCTPTokenMessengerV2,
+      addresses.CCTPTokenMessengerV2,
+      burnPayload
+    );
+
+    // Relay the message
+    const tx = crossChainRemoteStrategy
+      .connect(strategist)
+      .relay(message, "0x");
+
+    await expect(tx).to.be.revertedWith("Invalid burn token");
+  });
 });