fix issues: discord retry, event state dedup, missing abi, config alert error handling, initial rule load req

Author: apexearth

src/alert-config/config-loader.ts

@@ -138,16 +138,22 @@ export const getAlertRules = async (): Promise<AlertRule[]> => {
 
 /**
  * Refresh alert rules periodically. Changes take effect without redeploy.
+ * First load must succeed or the process exits — we can't run without rules.
  */
 const refreshRulesIfStale = async (): Promise<void> => {
   if (Date.now() - lastRuleRefresh < REFRESH_INTERVAL_MS) return
   if (!process.env.ALERT_CONFIG_DB_URL) return
+  const isFirstLoad = lastRuleRefresh === 0
   try {
     cachedRules = await loadRules()
     lastRuleRefresh = Date.now()
     console.log(`Alert config: loaded ${cachedRules.length} rules`)
   } catch (err) {
-    console.error('Failed to load alert rules:', err)
+    if (isFirstLoad) {
+      console.error('FATAL: Failed to load alert rules on startup:', err)
+      process.exit(1)
+    }
+    console.error('Failed to refresh alert rules (using cached):', err)
   }
 }
 

src/notify/discord.ts

@@ -60,7 +60,7 @@ export const sendMessage = async (topic: Topic, message: WebhookMessageCreateOpt
     await clients[topic]?.send(message)
   } catch (err) {
     if (retries > 0) {
-      await sendMessage(topic, message, retries - 1)
+      return await sendMessage(topic, message, retries - 1)
     }
     throw err
   }

src/notify/event/event.ts

@@ -64,8 +64,10 @@ export const registerDiscordRenderer = <const T extends EventArgs>(
 export const useEventState = (ctx: Context) => {
   const state = useProcessorState(ctx, 'eventState', {
     eventsHandled: new Set<string>(),
-    isEventHandled: (log: Log) => state.eventsHandled.has(log.topics[0]),
-    markEventHandled: (log: Log) => state.eventsHandled.add(log.topics[0]),
+    isEventHandled: (log: Log) =>
+      state.eventsHandled.has(`${log.block.height}:${log.transactionIndex}:${log.logIndex}`),
+    markEventHandled: (log: Log) =>
+      state.eventsHandled.add(`${log.block.height}:${log.transactionIndex}:${log.logIndex}`),
   })[0]
   return state
 }

src/processors/config-alert.ts

@@ -87,23 +87,23 @@ export const createConfigAlertProcessor = async (chainId: number) => {
 
             // Find the ABI event for notification
             const abiEvent = abiRegistry.getEvent(topic0)
-            if (!abiEvent) continue
-
             const eventInfo = abiRegistry.getEventInfo(topic0)
             const eventName = eventInfo?.name ?? topic0.slice(0, 10)
 
+            if (!abiEvent) {
+              console.warn(`ConfigAlert: No ABI for topic0 ${topic0} (rule ${rule.id}), sending raw notification`)
+            }
+
             await notifyForEvent({
               ctx,
               name: rule.displayName ?? rule.topic,
               eventName,
               block,
               log,
-              event: abiEvent,
+              event: abiEvent ?? { topic: topic0, decode: () => undefined },
               topic: rule.topic,
               severity: rule.severity === 'low' ? undefined : rule.severity,
               notifyTarget: rule.notifyTargets ?? undefined,
-            }).catch((e) => {
-              console.error('ConfigAlert: Error notifying for event', eventName, e)
             })
           }
         }