Skip to content

Commit a898e92

Browse files
Fix missing error
1 parent bcbeecd commit a898e92

File tree

1 file changed

+17
-26
lines changed

1 file changed

+17
-26
lines changed

src/commands/protocols/publish/publish-finalization-command.js

Lines changed: 17 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -182,45 +182,36 @@ class PublishFinalizationCommand extends Command {
182182
assertion,
183183
ual,
184184
) {
185-
try {
186-
if (merkleRoot !== cachedMerkleRoot) {
187-
const errorMessage = `Invalid Merkle Root for Knowledge Collection: ${ual}. Received value from blockchain: ${merkleRoot}, Cached value from publish operation: ${cachedMerkleRoot}`;
188-
189-
this.logger.error(`Command error (${this.errorType}): ${errorMessage}`);
185+
if (merkleRoot !== cachedMerkleRoot) {
186+
const errorMessage = `Invalid Merkle Root for Knowledge Collection: ${ual}. Received value from blockchain: ${merkleRoot}, Cached value from publish operation: ${cachedMerkleRoot}`;
190187

191-
this.operationIdService.emitChangeEvent(
192-
OPERATION_ID_STATUS.FAILED,
193-
operationId,
194-
blockchain,
195-
);
196-
}
188+
this.logger.error(`Command error (${this.errorType}): ${errorMessage}`);
197189

198-
const calculatedAssertionSize = this.dataService.calculateAssertionSize(
199-
assertion.public ?? assertion,
190+
this.operationIdService.emitChangeEvent(
191+
OPERATION_ID_STATUS.FAILED,
192+
operationId,
193+
blockchain,
200194
);
201195

202-
if (byteSize.toString() !== calculatedAssertionSize.toString()) {
203-
const errorMessage = `Invalid Assertion Size for Knowledge Collection: ${ual}. Received value from blockchain: ${byteSize}, Calculated value: ${calculatedAssertionSize}`;
196+
throw new Error(errorMessage);
197+
}
204198

205-
this.logger.error(`Command error (${this.errorType}): ${errorMessage}`);
199+
const calculatedAssertionSize = this.dataService.calculateAssertionSize(
200+
assertion.public ?? assertion,
201+
);
206202

207-
this.operationIdService.emitChangeEvent(
208-
OPERATION_ID_STATUS.FAILED,
209-
operationId,
210-
blockchain,
211-
);
203+
if (byteSize.toString() !== calculatedAssertionSize.toString()) {
204+
const errorMessage = `Invalid Assertion Size for Knowledge Collection: ${ual}. Received value from blockchain: ${byteSize}, Calculated value: ${calculatedAssertionSize}`;
212205

213-
throw new Error(errorMessage);
214-
}
215-
} catch (e) {
216-
this.logger.error(`Command error (${this.errorType}): ${e.message}`);
206+
this.logger.error(`Command error (${this.errorType}): ${errorMessage}`);
217207

218208
this.operationIdService.emitChangeEvent(
219209
OPERATION_ID_STATUS.FAILED,
220210
operationId,
221211
blockchain,
222212
);
223-
throw e;
213+
214+
throw new Error(errorMessage);
224215
}
225216
}
226217

0 commit comments

Comments
 (0)