Merge pull request #4010 from OriginTrail/fix/proofing-service-to-number-issue

Remove unneeded toNumber

Author: Mihajlo-Pavlovic

src/modules/repository/implementation/sequelize/repositories/random-sampling-challenge-repository.js

@@ -41,7 +41,7 @@ class RandomSamplingChallengeRepository {
             where: {
                 blockchainId,
             },
-            order: [['createdAt', 'DESC']], // Should this be camel case ?
+            order: [['createdAt', 'DESC']],
         });
     }
 

src/service/proofing-service.js

@@ -153,12 +153,12 @@ class ProofingService {
                                 'PROOF_CHALANGE_FINALIZED',
                                 this.generateOperationId(
                                     blockchainId,
-                                    latestChallenge.epoch.toNumber(),
-                                    latestChallenge.activeProofPeriodStartBlock.toNumber(),
+                                    latestChallenge.epoch,
+                                    latestChallenge.activeProofPeriodStartBlock,
                                 ),
                                 blockchainId,
-                                latestChallenge.epoch.toNumber(),
-                                latestChallenge.activeProofPeriodStartBlock.toNumber(),
+                                latestChallenge.epoch,
+                                latestChallenge.activeProofPeriodStartBlock,
                             );
                         } else {
                             this.logger.info(
@@ -190,12 +190,12 @@ class ProofingService {
                     'PROOF_ASSERTION_FETCHED',
                     this.generateOperationId(
                         blockchainId,
-                        latestChallenge.epoch.toNumber(),
-                        latestChallenge.activeProofPeriodStartBlock.toNumber(),
+                        latestChallenge.epoch,
+                        latestChallenge.activeProofPeriodStartBlock,
                     ),
                     blockchainId,
-                    latestChallenge.epoch.toNumber(),
-                    latestChallenge.activeProofPeriodStartBlock.toNumber(),
+                    latestChallenge.epoch,
+                    latestChallenge.activeProofPeriodStartBlock,
                 );
 
                 if (data.public.length === 0) {
@@ -246,12 +246,12 @@ class ProofingService {
                 'PROOF_ASSERTION_FETCHED',
                 this.generateOperationId(
                     blockchainId,
-                    newChallenge.epoch.toNumber(),
-                    newChallenge.activeProofPeriodStartBlock.toNumber(),
+                    newChallenge.epoch,
+                    newChallenge.activeProofPeriodStartBlock,
                 ),
                 blockchainId,
-                newChallenge.epoch.toNumber(),
-                newChallenge.activeProofPeriodStartBlock.toNumber(),
+                newChallenge.epoch,
+                newChallenge.activeProofPeriodStartBlock,
             );
 
             if (data.public.length === 0) {