operator fee change thru staking page fails

[botnumberseven]

I'm trying to update operator fee on the staking page but tx does not go thru.
For the record - I can update Ask on that node from that wallet. So at a high level things do work. But updating operator fee does not work.
Here is what I see in the console after submitting transaction.
Unfortunately it gives pretty generic error code.

Wallet - Metamask
RPC - astrosat.origintrail.network
Browser - Brave and Chrome show same behavior.

index-BcYPPrvV.js:54 Uncaught (in promise) ContractFunctionExecutionError: The contract function "updateOperatorFee" reverted with the following reason:
Internal JSON-RPC error.

Contract Call:
address: 0x23C891843637aBC722C47BB417EC1D3de4b63547
function: updateOperatorFee(uint72 identityId, uint16 newOperatorFee)
args: (79, 1001)
sender: 0x3E4c39228BfcBfB98EdbC1905A6C7716cD5303f2

Docs: https://viem.sh/docs/contract/writeContract
Version: viem@2.30.0
at yP (index-BcYPPrvV.js:54:2018)
at j9 (index-BcYPPrvV.js:55:25827)
at async mV (index-BcYPPrvV.js:56:14318)Caused by: ContractFunctionRevertedError: The contract function "updateOperatorFee" reverted with the following reason:
Internal JSON-RPC error.

Version: viem@2.30.0
at yP (index-BcYPPrvV.js:54:1914)
at j9 (index-BcYPPrvV.js:55:25827)
at async mV (index-BcYPPrvV.js:56:14318)

[Mihajlo-Pavlovic]

Thanks for reporting, we will investigate & fix it

[zsculac]

@botnumberseven, we attempted to replicate this error, but all our attempts to update the operator fee through the staking UI passed successfully.

"Internal JSON-RPC error" suggests that you may have issues with the RPC on Metamask, so you couldn't submit a transaction. Could you please try again and let me know if you're still experiencing the same issue?

[botnumberseven]

@zsculac still does not work for me.
I'm using Brave + Metamask, rpc - astrosat-parachain-rpc.origin-trail.network
Trying to update op fee.

Attempt 1
base fee - 0.000000025 (custom)
priority fee - 0.000000025 (custom)
gas limit - 21000000 (default)
Transaction fails without execution
The contract function "updateOperatorFee" reverted with the following reason: Internal JSON-RPC error. Contract Call: address: 0x23C891843637aBC722C47BB417EC1D3de4b63547 function: updateOperatorFee(uint72 identityId, uint16 newOperatorFee) args: (79, 1998) sender: 0x3E4c39228BfcBfB98EdbC1905A6C7716cD5303f2 Docs: https://viem.sh/docs/contract/writeContract Version: viem@2.30.0

Attempt 2
base fee - 0.000000025 (custom)
priority fee - 0.000000025 (custom)
gas limit - 5000000 (custom)
Transaction fails with execution - https://neuroweb.subscan.io/tx/0x58fcf3e5aa322b240f5889aa7611b99583d7680de126380583c1a5b28fc48478
Not sure why changing limit from 2.1M to 5M changes anything, I'd expect default 2.1M to be good enough.

Tx gets reverted with reason Cannot update operatorFee if o
Looks like this revert - https://github.com/OriginTrail/dkg-evm-module/blob/1088476e13c3c8b46f087f45cdea103959f2135c/contracts/Profile.sol#L140

Seems like op fees need to be withdrawn before op fee % can be changed. But staking page shows this node has zero op fees:

[zsculac]

@botnumberseven the operatorFeeClaimedForEpoch flag is set to true in Staking.claimDelegatorRewards function. It seems like no delegator claimed rewards for all previous epochs. At least one delegator must claim rewards for all previous epochs before changing the operator fee to ensure that rewards are calculated correctly. Can you claim all possible rewards and try to change again?

[botnumberseven]

@zsculac hmm... but how to do that?
This node was created a long time ago, but in v8 it has been running less than 1 epoch. Would it have any rewards?
There is only on delegator to this node (me) and I see no Claim button on staking page.
It also shows 0 TRAC previous epoch rewards.

[zsculac]

@botnumberseven By design, even the epochs with 0 rewards should be claimed to ensure proper accounting. This is something we should improve on the Staking UI so that it is done in the background in cases like yours, where the rewards are 0.

The best workaround for now (until we adjust this in the Staking UI) is to call Staking.claimDelegatorRewards with the relevant arguments and claim for all previous epochs (even though the reward is 0). Those should be epochs 6 and 7.

[botnumberseven]

@zsculac
I see. Will the node do that automatically at some point (call Staking.claimDelegatorRewards)?
Like at the epoch end, so I can just wait 9 days and skip this manual workaround.