feat: adding new facet with the set setRoleApprovalForAll function and deleted from interfaces

Author: EduardoMelo00

contracts/Aavegotchi/facets/ItemsRolesRegistryFacet.sol

@@ -16,6 +16,7 @@ import {IEventHandlerFacet} from "../WearableDiamond/interfaces/IEventHandlerFac
 import {LibERC1155} from "../../shared/libraries/LibERC1155.sol";
 import {EnumerableSet} from "@openzeppelin/contracts/utils/structs/EnumerableSet.sol";
 import {LibItemsEvents} from "../libraries/LibItemsEvents.sol";
+import {RoleApprovalFacet} from "./RoleApprovalFacet.sol";
 
 contract ItemsRolesRegistryFacet is Modifiers, IERC7589, ERC1155Holder {
     using EnumerableSet for EnumerableSet.UintSet;
@@ -119,7 +120,7 @@ contract ItemsRolesRegistryFacet is Modifiers, IERC7589, ERC1155Holder {
         override
         validGrantRoleData(_expirationDate, _role)
         onlyOwnerOrApproved(s.itemRolesDepositInfo[_depositId].deposit.grantor, s.itemRolesDepositInfo[_depositId].deposit.tokenAddress)
-    {
+    { 
         _grantOrUpdateRole(_depositId, _role, _grantee, _expirationDate, _revocable, _data);
     }
 
@@ -182,9 +183,8 @@ contract ItemsRolesRegistryFacet is Modifiers, IERC7589, ERC1155Holder {
     /// @param _tokenAddress The token address.
     /// @param _operator The user approved to grant and revoke roles.
     /// @param _isApproved The approval status.
-    function setRoleApprovalForAll(address _tokenAddress, address _operator, bool _isApproved) external override {
-        s.itemsRoleApprovals[LibMeta.msgSender()][_tokenAddress][_operator] = _isApproved;
-        emit RoleApprovalForAll(_tokenAddress, _operator, _isApproved);
+    function setRoleApprovalForAll(address _tokenAddress, address _operator, bool _isApproved) external {
+        RoleApprovalFacet(address(this)).setRoleApprovalForAll(_tokenAddress, _operator, _isApproved);
     }
 
     /** View Functions **/

contracts/Aavegotchi/facets/ParcelRolesRegistryFacet.sol

@@ -11,6 +11,8 @@ import {Modifiers, RoleData} from "../libraries/LibAppStorage.sol";
 import {LibItems} from "../libraries/LibItems.sol";
 import {LibSharedMarketplace} from "../libraries/LibSharedMarketplace.sol";
 
+import {RoleApprovalFacet} from "./RoleApprovalFacet.sol";
+
 contract ParcelRolesRegistryFacet is Modifiers, IERC7432 {
     uint256 public constant MAX_EXPIRATION_DATE = 90 days;
 
@@ -131,9 +133,8 @@ contract ParcelRolesRegistryFacet is Modifiers, IERC7432 {
         emit TokenUnlocked(originalOwner, _tokenAddress, _tokenId);
     }
 
-    function setRoleApprovalForAll(address _tokenAddress, address _operator, bool _approved) external override {
-        s.itemsRoleApprovals[msg.sender][_tokenAddress][_operator] = _approved;
-        emit RoleApprovalForAll(_tokenAddress, _operator, _approved);
+    function setRoleApprovalForAll(address _tokenAddress, address _operator, bool _isApproved) external {
+        RoleApprovalFacet(address(this)).setRoleApprovalForAll(_tokenAddress, _operator, _isApproved);
     }
 
     /** View Functions **/

contracts/Aavegotchi/facets/RoleApprovalFacet.sol

@@ -0,0 +1,14 @@
+// SPDX-License-Identifier: MIT
+pragma solidity 0.8.1;
+
+import {LibMeta} from "../../shared/libraries/LibMeta.sol";
+import {Modifiers} from "../libraries/LibAppStorage.sol";
+
+contract RoleApprovalFacet is Modifiers {
+    event RoleApprovalForAll(address indexed tokenAddress, address indexed operator, bool indexed isApproved);
+
+    function setRoleApprovalForAll(address _tokenAddress, address _operator, bool _approved) external {
+        s.itemsRoleApprovals[LibMeta.msgSender()][_tokenAddress][_operator] = _approved;
+        emit RoleApprovalForAll(_tokenAddress, _operator, _approved);
+    }
+}

contracts/Aavegotchi/libraries/LibAppStorage.sol

@@ -375,6 +375,7 @@ struct AppStorage {
     // depositId => userRoleDepositInfo
     mapping(uint256 => ItemRolesInfo) itemRolesDepositInfo;
     // grantor => tokenAddress => operator => isApproved
+    // Is used for more than one NFT type.
     mapping(address => mapping(address => mapping(address => bool))) itemsRoleApprovals;
     // counter to generate depositIds for each new deposit created in Items Roles Registry
     uint256 itemsDepositIdCounter;

contracts/shared/interfaces/IERC7432.sol

@@ -82,12 +82,6 @@ interface IERC7432 is IERC165 {
     /// @param _tokenId The token identifier.
     function unlockToken(address _tokenAddress, uint256 _tokenId) external;
 
-    /// @notice Approves operator to grant and revoke roles on behalf of another user.
-    /// @param _tokenAddress The token address.
-    /// @param _operator The user approved to grant and revoke roles.
-    /// @param _approved The approval status.
-    function setRoleApprovalForAll(address _tokenAddress, address _operator, bool _approved) external;
-
     /** View Functions **/
 
     /// @notice Retrieves the owner of NFT.

contracts/shared/interfaces/IERC7589.sol

@@ -104,12 +104,6 @@ interface IERC7589 {
     /// @param _commitmentId The commitment identifier.
     function releaseTokens(uint256 _commitmentId) external;
 
-    /// @notice Approves operator to grant and revoke roles on behalf of another user.
-    /// @param _tokenAddress The token address.
-    /// @param _operator The user approved to grant and revoke roles.
-    /// @param _approved The approval status.
-    function setRoleApprovalForAll(address _tokenAddress, address _operator, bool _approved) external;
-
     /** View Functions **/
 
     /// @notice Returns the owner of the commitment (grantor).