Skip to content

Commit 051d771

Browse files
committed
Fix issue with empty params initialising to booleans
- Tested with bpipe v0.9.12 - Empty params, e.g., `-p assemblyFasta` are now initialised to a boolean value and thus fail the empty string test, need to remove these params from params.txt (if not using them) - Need to set var_filter and gene_filter params if missing binding
1 parent a77c636 commit 051d771

File tree

3 files changed

+12
-3
lines changed

3 files changed

+12
-3
lines changed

MINTIE.groovy

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,12 @@ if(!binding.variables.containsKey("run_de_step")){
3030
if(!binding.variables.containsKey("splice_motif_mismatch")){
3131
splice_motif_mismatch=0
3232
}
33+
if(!binding.variables.containsKey("var_filter")){
34+
var_filter=""
35+
}
36+
if(!binding.variables.containsKey("gene_filter")){
37+
gene_filter=""
38+
}
3339

3440
fastq_dedupe = {
3541
from("*.gz"){

MINTIE_SE.groovy

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,12 @@ if(!binding.variables.containsKey("run_de_step")){
3030
if(!binding.variables.containsKey("splice_motif_mismatch")){
3131
splice_motif_mismatch=0
3232
}
33+
if(!binding.variables.containsKey("var_filter")){
34+
var_filter=""
35+
}
36+
if(!binding.variables.containsKey("gene_filter")){
37+
gene_filter=""
38+
}
3339

3440
fastq_dedupe = {
3541
from("*.gz"){

test/test_params.txt

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,10 +13,7 @@
1313
-p min_cpm=0.1
1414
-p fdr=0.05
1515
-p sort_ram=2G
16-
-p gene_filter=
17-
-p var_filter=
1816
-p splice_motif_mismatch=4
1917
-p fastqCaseFormat=cases/%_R*.fastq.gz
2018
-p fastqControlFormat=controls/%_R*.fastq.gz
21-
-p assemblyFasta=
2219
-p run_de_step=true

0 commit comments

Comments
 (0)