dynamic field spesicifcation

Author: mcp-release-bot

src/mcp_as_a_judge/models.py

@@ -58,7 +58,8 @@ class JudgeResponse(BaseModel):
     )
 
     # Use a lazy default factory to avoid importing workflow at module import time
-    def _default_workflow_guidance():  # type: ignore[no-redef]
+    @staticmethod
+    def _default_workflow_guidance() -> "WorkflowGuidance":
         from mcp_as_a_judge.workflow import WorkflowGuidance
 
         return WorkflowGuidance(
@@ -261,6 +262,10 @@ class SystemVars(BaseModel):
         default="",
         description="Workflow guidance from task state to use as evaluation criteria (optional)",
     )
+    plan_required_fields_json: str = Field(
+        default="[]",
+        description="JSON array of required fields for judge_coding_plan dynamic validation (optional)",
+    )
 
 
 class JudgeCodingPlanUserVars(BaseModel):

src/mcp_as_a_judge/prompts/system/judge_coding_plan.md

@@ -297,25 +297,31 @@ You must respond with a JSON object that matches this schema:
 
 **CRITICAL: You MUST evaluate ALL requirements in ONE PASS. NO iterative discovery allowed.**
 
-### STEP 1: CHECK REQUIRED FIELDS (Reject immediately if ANY missing)
-- [ ] `plan` field exists and non-empty
-- [ ] `design` field exists and non-empty
-- [ ] `research` field exists and non-empty
-- [ ] `problem_domain` field exists and non-empty
-- [ ] `problem_non_goals` array exists (can be empty)
-- [ ] `library_plan` array exists and non-empty
-- [ ] `internal_reuse_components` array exists (empty with greenfield note OK)
-
-### STEP 2: CHECK CONDITIONAL FIELDS (Based on task metadata)
-- [ ] If `research_required=true` → `research_urls` array must exist and be non-empty
-- [ ] If `risk_assessment_required=true` → `identified_risks` AND `risk_mitigation_strategies` arrays must exist with 1:1 mapping
-- [ ] If `design_patterns_enforcement=true` → `design_patterns` array must exist with name/area objects
-
-### STEP 3: APPROVE OR REJECT WITH COMPLETE FEEDBACK
-- **IF ALL FIELDS PRESENT**: Approve with brief positive feedback
-- **IF ANY FIELDS MISSING**: Reject with ALL missing items listed at once
+### DYNAMIC FIELD VALIDATION
+
+The following fields are required based on the current task metadata:
+
+{{ plan_required_fields_json }}
+
+**VALIDATION STEPS:**
+
+1. **Parse the field requirements** from the JSON specification above
+2. **Check each required field** (where `required: true`) exists and is non-empty
+3. **Check conditional fields** (where `conditional_on` is specified) only when their condition is met
+4. **Validate data types** match the specified `type` for each field
+5. **Approve or reject** with complete feedback listing ALL missing fields at once
+
+### FIELD VALIDATION RULES:
+- **String fields**: Must exist and contain non-whitespace content
+- **Array fields**: Must exist as arrays (can be empty only if explicitly noted in description)
+- **Object arrays**: Must exist and contain properly structured objects as described
+- **Conditional fields**: Only validate when the specified task metadata condition is true
+
+### APPROVAL CRITERIA:
+- ✅ **APPROVE** if all required and applicable conditional fields are populated with reasonable content
+- ❌ **REJECT** only if required or applicable conditional fields are missing or empty
 - **DO NOT**: Ask for additional details, implementation specifics, or code snippets
-- **DO NOT**: Discover new requirements not listed above
+- **DO NOT**: Discover new requirements beyond the specified field list
 
 ### SIMPLIFIED APPROVAL CRITERIA:
 ✅ **APPROVE** if all required/conditional fields are populated with reasonable content

src/mcp_as_a_judge/prompts/system/workflow_guidance.md

@@ -144,13 +144,12 @@ When recommending judge_coding_plan, you MUST:
 2. **Include ALL required fields** (both always-required and conditional based on task metadata)
 3. **Provide clear examples** for complex field types like library_plan and design_patterns
 
-The plan_required_fields array will be automatically populated based on task metadata and should include:
-- Always required: plan, design, research, problem_domain, problem_non_goals, library_plan, internal_reuse_components
-- Conditional on research_required=true: research_urls
-- Conditional on risk_assessment_required=true: identified_risks, risk_mitigation_strategies
-- Conditional on design_patterns_enforcement=true: design_patterns
+The plan_required_fields array will be automatically populated based on task metadata. The dynamic validation system will:
+- Include always-required fields (plan, design, research, problem_domain, problem_non_goals, library_plan, internal_reuse_components)
+- Add conditional fields based on task metadata flags (research_urls, identified_risks, risk_mitigation_strategies, design_patterns)
+- Provide detailed field specifications with types, descriptions, and examples
 
-**FAILURE TO POPULATE CONDITIONAL FIELDS WILL RESULT IN REJECTION**
+**FAILURE TO POPULATE REQUIRED OR APPLICABLE CONDITIONAL FIELDS WILL RESULT IN REJECTION**
 
 ### CRITICAL: judge_code_change Usage Rules
 

src/mcp_as_a_judge/server.py

@@ -39,14 +39,14 @@
     DesignPattern,
     JudgeCodeChangeUserVars,
     JudgeCodingPlanUserVars,
-    JudgeResponse,
     ResearchValidationResponse,
     ResearchValidationUserVars,
     SystemVars,
     WorkflowGuidance,
 )
 from mcp_as_a_judge.models.enhanced_responses import (
     EnhancedResponseFactory,
+    JudgeResponse,
     TaskAnalysisResult,
     TaskCompletionResult,
 )
@@ -1292,11 +1292,20 @@ async def _evaluate_coding_plan(
 
         workflow_guidance_text = "\n".join(guidance_parts)
 
+    # Generate plan required fields for dynamic validation
+    from mcp_as_a_judge.workflow.workflow_guidance import _generate_plan_required_fields
+
+    plan_required_fields = _generate_plan_required_fields(task_metadata)
+    plan_required_fields_json = json.dumps(
+        [field.model_dump() for field in plan_required_fields], indent=2
+    )
+
     # Create system and user messages from templates
     system_vars = SystemVars(
         response_schema=json.dumps(JudgeResponse.model_json_schema()),
         max_tokens=MAX_TOKENS,
         workflow_guidance=workflow_guidance_text,
+        plan_required_fields_json=plan_required_fields_json,
     )
     user_vars = JudgeCodingPlanUserVars(
         user_requirements=user_requirements,