fix: lint

Author: dori

src/mcp_as_a_judge/constants.py

@@ -16,6 +16,3 @@
 MAX_CONTEXT_RECORDS = 20
 CONTEXT_ENRICHMENT_COUNT = 10
 RECORD_RETENTION_DAYS = 1
-
-
-

src/mcp_as_a_judge/db/conversation_history_service.py

@@ -87,9 +87,9 @@ async def save_tool_interaction(
         logger.info(f"✅ Saved conversation record with ID: {record_id}")
         return record_id
 
-
-
-    async def get_conversation_history(self, session_id: str) -> list[ConversationRecord]:
+    async def get_conversation_history(
+        self, session_id: str
+    ) -> list[ConversationRecord]:
         """
         Get conversation history for a session to be injected into user prompts.
 
@@ -103,11 +103,15 @@ async def get_conversation_history(self, session_id: str) -> list[ConversationRe
 
         context_records = await self.load_context_for_enrichment(session_id)
 
-        logger.info(f"📝 Retrieved {len(context_records)} conversation records for session {session_id}")
+        logger.info(
+            f"📝 Retrieved {len(context_records)} conversation records for session {session_id}"
+        )
 
         return context_records
 
-    def format_conversation_history_as_context(self, conversation_history: list[ConversationRecord]) -> str:
+    def format_conversation_history_as_context(
+        self, conversation_history: list[ConversationRecord]
+    ) -> str:
         """
         Convert conversation history list to formatted string for context field.
 
@@ -120,7 +124,9 @@ def format_conversation_history_as_context(self, conversation_history: list[Conv
         if not conversation_history:
             return ""
 
-        logger.info(f"📝 Formatting {len(conversation_history)} conversation records as context string")
+        logger.info(
+            f"📝 Formatting {len(conversation_history)} conversation records as context string"
+        )
 
         context_parts = []
         for record in conversation_history:
@@ -133,5 +139,3 @@ def format_conversation_history_as_context(self, conversation_history: list[Conv
         logger.info(f"📝 Generated context string: {len(formatted_context)} characters")
 
         return formatted_context
-
-

src/mcp_as_a_judge/db/interface.py

@@ -76,5 +76,3 @@ async def get_session_conversations(
             List of ConversationRecord objects
         """
         pass
-
-

src/mcp_as_a_judge/db/providers/sqlite_provider.py

@@ -34,9 +34,7 @@ class SQLiteProvider(ConversationHistoryDB):
     - Session-based conversation retrieval
     """
 
-    def __init__(
-        self, max_context_records: int = 20, url: str = ""
-    ) -> None:
+    def __init__(self, max_context_records: int = 20, url: str = "") -> None:
         """Initialize the SQLModel SQLite database with LRU and time-based cleanup."""
         # Parse URL to get SQLite connection string
         connection_string = self._parse_sqlite_url(url)
@@ -190,5 +188,3 @@ async def get_session_conversations(
 
             records = session.exec(stmt).all()
             return list(records)
-
-

src/mcp_as_a_judge/models.py

@@ -118,9 +118,7 @@ class JudgeCodingPlanUserVars(BaseModel):
     user_requirements: str = Field(
         description="The user's requirements for the coding task"
     )
-    context: str = Field(
-        description="Context including conversation history"
-    )
+    context: str = Field(description="Context including conversation history")
     plan: str = Field(description="The coding plan to be evaluated")
     design: str = Field(description="The design documentation")
     research: str = Field(description="Research findings and analysis")
@@ -147,9 +145,7 @@ class JudgeCodeChangeUserVars(BaseModel):
     file_path: str = Field(description="Path to the file being changed")
     change_description: str = Field(description="Description of what the change does")
     code_change: str = Field(description="The actual code content being reviewed")
-    context: str = Field(
-        description="Context including conversation history"
-    )
+    context: str = Field(description="Context including conversation history")
 
 
 class ResearchValidationSystemVars(BaseModel):
@@ -171,9 +167,7 @@ class ResearchValidationUserVars(BaseModel):
         default_factory=list,
         description="URLs from MANDATORY online research - minimum 3 URLs required",
     )
-    context: str = Field(
-        description="Context including conversation history"
-    )
+    context: str = Field(description="Context including conversation history")
 
 
 class WorkflowGuidanceSystemVars(BaseModel):
@@ -226,7 +220,6 @@ class DynamicSchemaUserVars(BaseModel):
     )
 
 
-
 class ElicitationFallbackUserVars(BaseModel):
     """Variables for elicitation fallback user prompt template."""
 

src/mcp_as_a_judge/server.py

@@ -88,11 +88,17 @@ async def build_workflow(
 
     try:
         # STEP 1: Load conversation history and format as context string
-        conversation_history = await conversation_service.get_conversation_history(session_id)
-        history_context = conversation_service.format_conversation_history_as_context(conversation_history)
+        conversation_history = await conversation_service.get_conversation_history(
+            session_id
+        )
+        history_context = conversation_service.format_conversation_history_as_context(
+            conversation_history
+        )
 
         # Combine user-provided context with conversation history
-        combined_context = f"{context}\n\n{history_context}".strip() if context else history_context
+        combined_context = (
+            f"{context}\n\n{history_context}".strip() if context else history_context
+        )
 
         # STEP 2: Create system and user messages with formatted context
         system_vars = WorkflowGuidanceSystemVars(
@@ -515,7 +521,7 @@ async def judge_coding_plan(
     log_tool_execution(
         "judge_coding_plan",
         session_id,
-        f"Plan: {plan}\nUser Requirements: {user_requirements}"
+        f"Plan: {plan}\nUser Requirements: {user_requirements}",
     )
 
     # Handle default value for research_urls
@@ -554,8 +560,12 @@ async def judge_coding_plan(
 
     try:
         # STEP 1: Load conversation history and format as context string
-        conversation_history = await conversation_service.get_conversation_history(session_id)
-        history_context = conversation_service.format_conversation_history_as_context(conversation_history)
+        conversation_history = await conversation_service.get_conversation_history(
+            session_id
+        )
+        history_context = conversation_service.format_conversation_history_as_context(
+            conversation_history
+        )
 
         # STEP 2: Use helper function for main evaluation with formatted conversation history
         evaluation_result = await _evaluate_coding_plan(
@@ -633,8 +643,12 @@ async def judge_code_change(
 
     try:
         # STEP 1: Load conversation history and format as context string
-        conversation_history = await conversation_service.get_conversation_history(session_id)
-        history_context = conversation_service.format_conversation_history_as_context(conversation_history)
+        conversation_history = await conversation_service.get_conversation_history(
+            session_id
+        )
+        history_context = conversation_service.format_conversation_history_as_context(
+            conversation_history
+        )
 
         # STEP 2: Create system and user messages with formatted context
         system_vars = JudgeCodeChangeSystemVars(

tests/test_db_implementation.py

@@ -54,9 +54,15 @@ async def test_database_operations():
     assert len(all_records) == 2, f"Expected 2 records, got {len(all_records)}"
 
     # Verify record content
-    assert all_records[0].source == "judge_code_change", "Most recent record should be judge_code_change"
-    assert all_records[1].source == "judge_coding_plan", "Older record should be judge_coding_plan"
-    assert all_records[0].input == "Review this code change", "Record content should match"
+    assert all_records[0].source == "judge_code_change", (
+        "Most recent record should be judge_code_change"
+    )
+    assert all_records[1].source == "judge_coding_plan", (
+        "Older record should be judge_coding_plan"
+    )
+    assert all_records[0].input == "Review this code change", (
+        "Record content should match"
+    )
     print("✅ CRUD operations verified successfully")
 
     # Test deletion
@@ -76,7 +82,9 @@ async def test_database_operations():
     # Final verification - ensure cleanup worked
     final_records = await db.get_session_conversations("session_123")
     print(f"Final verification: {len(final_records)} records remaining")
-    assert len(final_records) == 0, f"Expected 0 records after cleanup, got {len(final_records)}"
+    assert len(final_records) == 0, (
+        f"Expected 0 records after cleanup, got {len(final_records)}"
+    )
     print("✅ Cleanup verification successful")
 
     print("\n✅ All tests completed successfully!")

tests/test_sqlite_comprehensive.py

@@ -115,11 +115,15 @@ async def test_large_dataset_performance(self):
         # Test performance verification - ensure LRU cleanup worked correctly
         # Verify that we have exactly the max_context_records (100) and they are the most recent
         all_records = await db.get_session_conversations("perf_test")
-        assert len(all_records) == 100, f"Expected exactly 100 records after LRU cleanup, got {len(all_records)}"
+        assert len(all_records) == 100, (
+            f"Expected exactly 100 records after LRU cleanup, got {len(all_records)}"
+        )
 
         # Verify records are in correct order (most recent first)
         for i in range(len(all_records) - 1):
-            assert all_records[i].timestamp >= all_records[i + 1].timestamp, "Records should be ordered by timestamp desc"
+            assert all_records[i].timestamp >= all_records[i + 1].timestamp, (
+                "Records should be ordered by timestamp desc"
+            )
 
         print("✅ Performance and LRU cleanup verification successful")
 

tests/test_utils/db_test_utils.py

@@ -40,5 +40,3 @@ async def clear_session(db: ConversationHistoryDB, session_id: str) -> int:
                 return len(records)
         else:
             raise NotImplementedError(f"clear_session not implemented for {type(db)}")
-
-