Skip to content

Commit 7933166

Browse files
author
mcp-release-bot
committed
update risk mgmt
1 parent 0ced6b8 commit 7933166

File tree

3 files changed

+14
-5
lines changed

3 files changed

+14
-5
lines changed

src/mcp_as_a_judge/prompts/system/judge_coding_plan.md

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -166,7 +166,16 @@ Output mapping requirement: Populate these fields in current_task_metadata for d
166166

167167
**⚠️ Risk Analysis:**
168168
- Validate that potential risks are properly identified and addressed
169-
- Required risk categories to consider: OAuth/authentication misconfiguration, insecure cookie/session settings, CSRF vulnerabilities, open redirect attacks, session fixation, secret leakage, database migration failures, XSS from external data, dependency vulnerabilities, rate limiting absence, environment mismatches
169+
- Required risk categories to consider:
170+
- **Security risks**: Authentication/authorization vulnerabilities, data exposure, input validation gaps, session management issues, dependency vulnerabilities, configuration security
171+
- **Performance degradation**: Memory leaks, inefficient algorithms, database query performance, resource exhaustion
172+
- **Breaking changes**: API compatibility issues, backward compatibility problems, migration path failures
173+
- **Code maintainability**: Technical debt accumulation, tight coupling, SOLID principle violations, architectural degradation
174+
- **System reliability**: Error handling gaps, race conditions, concurrent access issues, failure recovery problems
175+
- **Data integrity**: Inconsistent state management, validation gaps, data corruption risks
176+
- **User experience**: Response time degradation, accessibility regressions, usability issues
177+
- **Testing coverage**: Reduced test coverage, flaky tests, missing edge cases, test maintenance issues
178+
- **Documentation drift**: Outdated documentation, missing API docs, unclear error messages
170179
- Are identified risks realistic and comprehensive?
171180
- Do mitigation strategies adequately address the risks (one-to-one mapping)?
172181
- Does the plan include appropriate safeguards and rollback mechanisms?

src/mcp_as_a_judge/prompts/system/workflow_guidance.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ When recommending judge_coding_plan, your preparation_needed MUST include compre
103103
**STRUCTURE REQUIREMENTS:**
104104
- "Ensure library_plan includes ALL dependencies: framework, auth, database, styling, testing, linting, validation"
105105
- "Ensure design_patterns specifies concrete patterns: Singleton, Factory, Adapter, Strategy, etc."
106-
- "Ensure identified_risks covers: security, configuration, data loss, authorization, secrets, dependencies"
106+
- "Ensure identified_risks covers: security vulnerabilities, performance degradation, breaking changes, maintainability issues, system reliability, data integrity, user experience, testing coverage, documentation drift"
107107
- "Ensure each risk has corresponding mitigation strategy in same order"
108108
- "Include comprehensive testing strategy with specific test files and mocking approach"
109109
- "Map SOLID principles explicitly to components and files"

src/mcp_as_a_judge/workflow/workflow_guidance.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -943,15 +943,15 @@ def _generate_plan_required_fields(
943943
description="Areas that could be harmed by the proposed changes",
944944
required=True,
945945
conditional_on="risk_assessment_required",
946-
example_value='["OAuth misconfiguration", "CSRF attacks", "Session fixation"]',
946+
example_value='["Authentication vulnerabilities", "Performance degradation from inefficient queries", "Breaking API changes"]',
947947
),
948948
PlanRequiredField(
949949
name="risk_mitigation_strategies",
950950
type="list[str]",
951951
description="Strategies to mitigate identified risks (same order as identified_risks)",
952952
required=True,
953953
conditional_on="risk_assessment_required",
954-
example_value='["Use Auth.js secure defaults", "Enable CSRF protection", "Rotate sessions on login"]',
954+
example_value='["Implement secure authentication patterns", "Add database indexing and query optimization", "Use versioned APIs with deprecation notices"]',
955955
),
956956
]
957957
)
@@ -1105,7 +1105,7 @@ def _load_plan_evaluation_criteria() -> str:
11051105
- Development tooling included (linting, formatting, type checking)
11061106
11071107
### 4. Security & Risk Management
1108-
- Comprehensive risk enumeration: OAuth misconfiguration, secret leakage, insecure cookies, CSRF, session attacks
1108+
- Comprehensive risk enumeration: security vulnerabilities, performance degradation, breaking changes, maintainability issues, system reliability, data integrity
11091109
- One-to-one risk mitigation strategies
11101110
- Security headers and protection mechanisms
11111111
- Environment variable security and validation

0 commit comments

Comments
 (0)