fix url types

Author: Zvi Fried

.gitignore

@@ -159,3 +159,5 @@ Thumbs.db
 *.db
 *.sqlite
 *.sqlite3
+
+.actrc

src/mcp_as_a_judge/prompts/tool_descriptions/judge_coding_plan.md

@@ -11,7 +11,7 @@ Args:
     plan: The detailed coding plan to be reviewed (REQUIRED)
     design: Detailed system design including architecture, components, data flow, and technical decisions (REQUIRED)
     research: Research findings on existing solutions, libraries, frameworks, and best practices (REQUIRED)
-    research_urls: 🌐 URLs from MANDATORY online research - AI assistant MUST provide at least 3 URLs from research (List of URL strings)
+    research_urls: 🌐 URLs from MANDATORY online research - AI assistant MUST provide at least 3 URLs from research (REQUIRED)
     user_requirements: Clear statement of what the user wants to achieve (REQUIRED)
     context: Additional context about the project, requirements, or constraints
 

src/mcp_as_a_judge/server.py

@@ -510,10 +510,10 @@ async def judge_coding_plan(
     plan: str,
     design: str,
     research: str,
+    research_urls: list[str],
     user_requirements: str,
     ctx: Context,
     context: str = "",
-    research_urls: list[str] | None = None,
 ) -> JudgeResponse:
     """Coding plan evaluation tool - description loaded from tool_description_provider."""
     session_id = get_session_id(ctx)
@@ -525,10 +525,6 @@ async def judge_coding_plan(
         f"Plan: {plan}\nUser Requirements: {user_requirements}",
     )
 
-    # Handle default value for research_urls
-    if research_urls is None:
-        research_urls = []
-
     # Store original input for saving later
     original_input = {
         "plan": plan,

tests/test_design_research_validation.py

@@ -34,9 +34,9 @@ def test_judge_coding_plan_signature() -> None:
     assert sig.parameters["research"].default == inspect.Parameter.empty, (
         "research should be required"
     )
-    # research_urls is optional for backward compatibility but strongly encouraged
-    assert sig.parameters["research_urls"].default is None, (
-        "research_urls should have None default for backward compatibility"
+    # research_urls is now required
+    assert sig.parameters["research_urls"].default == inspect.Parameter.empty, (
+        "research_urls should be required"
     )
     print("✓ plan, design, and research are all required parameters")
 

tests/test_enhanced_features.py

@@ -71,6 +71,7 @@ async def test_judge_coding_plan_with_requirements(
             research_urls=[
                 "https://slack.dev/python-slack-sdk/",
                 "https://modelcontextprotocol.io/docs/",
+                "https://github.com/slackapi/python-slack-sdk",
             ],
             user_requirements="Send CI/CD status updates to Slack channels",
             context="CI/CD integration project",