fix: resolve linting errors and codecov configuration

- Fix code formatting with ruff format
- Update codecov action to use 'files' parameter instead of deprecated 'file'
- All linting and formatting checks now pass

Author: Zvi Fried

.github/workflows/ci.yml

@@ -68,7 +68,7 @@ jobs:
     - name: Upload coverage to Codecov
       uses: codecov/codecov-action@v5
       with:
-        file: ./coverage.xml
+        files: ./coverage.xml
         fail_ci_if_error: false
         verbose: true
         token: ${{ secrets.CODECOV_TOKEN }}

src/mcp_as_a_judge/models.py

@@ -111,6 +111,7 @@ class ResearchValidationResponse(BaseModel):
 
 # Prompt variable models for type safety and validation
 
+
 class JudgeCodingPlanSystemVars(BaseModel):
     """Variables for judge_coding_plan system prompt."""
 
@@ -125,21 +126,13 @@ class JudgeCodingPlanUserVars(BaseModel):
     user_requirements: str = Field(
         description="The user's requirements for the coding task"
     )
-    context: str = Field(
-        description="Additional context about the task"
-    )
-    plan: str = Field(
-        description="The coding plan to be evaluated"
-    )
-    design: str = Field(
-        description="The design documentation"
-    )
-    research: str = Field(
-        description="Research findings and analysis"
-    )
+    context: str = Field(description="Additional context about the task")
+    plan: str = Field(description="The coding plan to be evaluated")
+    design: str = Field(description="The design documentation")
+    research: str = Field(description="Research findings and analysis")
     research_urls: list[str] = Field(
         default_factory=list,
-        description="URLs from MANDATORY online research - minimum 3 URLs required"
+        description="URLs from MANDATORY online research - minimum 3 URLs required",
     )
 
 
@@ -157,15 +150,9 @@ class JudgeCodeChangeUserVars(BaseModel):
     user_requirements: str = Field(
         description="The user's requirements for the code change"
     )
-    file_path: str = Field(
-        description="Path to the file being changed"
-    )
-    change_description: str = Field(
-        description="Description of what the change does"
-    )
-    code_change: str = Field(
-        description="The actual code content being reviewed"
-    )
+    file_path: str = Field(description="Path to the file being changed")
+    change_description: str = Field(description="Description of what the change does")
+    code_change: str = Field(description="The actual code content being reviewed")
 
 
 class ResearchValidationSystemVars(BaseModel):
@@ -179,21 +166,13 @@ class ResearchValidationSystemVars(BaseModel):
 class ResearchValidationUserVars(BaseModel):
     """Variables for research_validation user prompt."""
 
-    user_requirements: str = Field(
-        description="The user's requirements for the task"
-    )
-    plan: str = Field(
-        description="The proposed plan"
-    )
-    design: str = Field(
-        description="The design documentation"
-    )
-    research: str = Field(
-        description="Research findings to be validated"
-    )
+    user_requirements: str = Field(description="The user's requirements for the task")
+    plan: str = Field(description="The proposed plan")
+    design: str = Field(description="The design documentation")
+    research: str = Field(description="Research findings to be validated")
     research_urls: list[str] = Field(
         default_factory=list,
-        description="URLs from MANDATORY online research - minimum 3 URLs required"
+        description="URLs from MANDATORY online research - minimum 3 URLs required",
     )
 
 
@@ -208,9 +187,5 @@ class WorkflowGuidanceSystemVars(BaseModel):
 class WorkflowGuidanceUserVars(BaseModel):
     """Variables for get_workflow_guidance user prompt."""
 
-    task_description: str = Field(
-        description="Description of the development task"
-    )
-    context: str = Field(
-        description="Additional context about the task"
-    )
+    task_description: str = Field(description="Description of the development task")
+    context: str = Field(description="Additional context about the task")

src/mcp_as_a_judge/prompt_loader.py

@@ -104,9 +104,7 @@ def create_separate_messages(
     )
 
     # Render user prompt with user variables
-    user_content = prompt_loader.render_prompt(
-        user_template, **user_vars.model_dump()
-    )
+    user_content = prompt_loader.render_prompt(user_template, **user_vars.model_dump())
 
     return [
         # System instructions as assistant message

src/mcp_as_a_judge/server.py

@@ -5,8 +5,6 @@
 coding plans and code changes against software engineering best practices.
 """
 
-
-
 import json
 
 from mcp.server.fastmcp import Context, FastMCP
@@ -64,9 +62,6 @@ def _extract_json_from_response(response_text: str) -> str:
     return json_content
 
 
-
-
-
 @mcp.tool()  # type: ignore[misc,unused-ignore]
 async def get_workflow_guidance(
     task_description: str,
@@ -467,11 +462,11 @@ async def judge_coding_plan(
             required_improvements=[
                 f"Insufficient research URLs: {len(research_urls)} provided, minimum 3 required",
                 "AI assistant MUST perform online research and provide at least 3 URLs",
-                "Research should focus on existing well-known libraries and best practices"
+                "Research should focus on existing well-known libraries and best practices",
             ],
             feedback=f"❌ RESEARCH VALIDATION FAILED: Only {len(research_urls)} URLs provided. "
-                    f"MANDATORY requirement: AI assistant must provide at least 3 URLs from online research "
-                    f"focusing on existing solutions and well-known libraries."
+            f"MANDATORY requirement: AI assistant must provide at least 3 URLs from online research "
+            f"focusing on existing solutions and well-known libraries.",
         )
 
     try:

tests/test_enhanced_features.py

@@ -64,7 +64,10 @@ async def test_judge_coding_plan_with_requirements(
             plan="Create Slack MCP server with message sending",
             design="Use slack-sdk library with FastMCP framework",
             research="Analyzed slack-sdk docs and MCP patterns",
-            research_urls=["https://slack.dev/python-slack-sdk/", "https://modelcontextprotocol.io/docs/"],
+            research_urls=[
+                "https://slack.dev/python-slack-sdk/",
+                "https://modelcontextprotocol.io/docs/",
+            ],
             user_requirements="Send CI/CD status updates to Slack channels",
             context="CI/CD integration project",
             ctx=mock_context_with_sampling,
@@ -112,7 +115,11 @@ async def test_requirements_in_evaluation_prompt(self, mock_context_with_samplin
             plan="Test plan",
             design="Test design",
             research="Test research",
-            research_urls=["https://example.com/docs", "https://github.com/example/repo", "https://stackoverflow.com/questions/example"],
+            research_urls=[
+                "https://example.com/docs",
+                "https://github.com/example/repo",
+                "https://stackoverflow.com/questions/example",
+            ],
             user_requirements="Specific user requirements for testing",
             context="Test context",
             ctx=mock_context_with_sampling,
@@ -225,7 +232,11 @@ async def test_complete_workflow_with_requirements(
             plan="Create Slack MCP server with message capabilities",
             design="Use slack-sdk with FastMCP framework",
             research="Analyzed Slack API and MCP patterns",
-            research_urls=["https://api.slack.com/docs", "https://modelcontextprotocol.io/docs/", "https://github.com/slackapi/python-slack-sdk"],
+            research_urls=[
+                "https://api.slack.com/docs",
+                "https://modelcontextprotocol.io/docs/",
+                "https://github.com/slackapi/python-slack-sdk",
+            ],
             user_requirements="Send automated CI/CD notifications to Slack",
             ctx=mock_context_with_sampling,
         )
@@ -247,7 +258,11 @@ async def test_obstacle_handling_workflow(self, mock_context_without_sampling):
             plan="Test plan",
             design="Test design",
             research="Test research",
-            research_urls=["https://example.com/docs", "https://github.com/example", "https://stackoverflow.com/example"],
+            research_urls=[
+                "https://example.com/docs",
+                "https://github.com/example",
+                "https://stackoverflow.com/example",
+            ],
             user_requirements="Test requirements",
             ctx=mock_context_without_sampling,
         )

tests/test_prompt_loader.py

@@ -52,7 +52,11 @@ def test_render_judge_coding_plan_user(self) -> None:
             plan="Create Python calculator",
             design="Use functions for operations",
             research="Researched Python math",
-            research_urls=["https://docs.python.org/3/library/math.html", "https://numpy.org/doc/", "https://scipy.org/"],
+            research_urls=[
+                "https://docs.python.org/3/library/math.html",
+                "https://numpy.org/doc/",
+                "https://scipy.org/",
+            ],
             context="Educational project",
         )
 
@@ -157,16 +161,18 @@ def test_global_prompt_loader_instance(self) -> None:
 
     def test_create_separate_messages(self) -> None:
         """Test the create_separate_messages function."""
-        system_vars = JudgeCodingPlanSystemVars(
-            response_schema='{"type": "object"}'
-        )
+        system_vars = JudgeCodingPlanSystemVars(response_schema='{"type": "object"}')
         user_vars = JudgeCodingPlanUserVars(
             user_requirements="Build a calculator",
             context="Educational project",
             plan="Create Python calculator",
             design="Use functions for operations",
             research="Researched Python math",
-            research_urls=["https://docs.python.org/3/library/math.html", "https://numpy.org/doc/", "https://scipy.org/"],
+            research_urls=[
+                "https://docs.python.org/3/library/math.html",
+                "https://numpy.org/doc/",
+                "https://scipy.org/",
+            ],
         )
 
         messages = create_separate_messages(
@@ -203,19 +209,23 @@ def test_render_research_validation_system(self) -> None:
 
         assert "Research Quality Validation" in prompt
         assert "expert at evaluating" in prompt
-        assert '{"type": "object", "properties": {"research_adequate": {"type": "boolean"}}}' in prompt
+        assert (
+            '{"type": "object", "properties": {"research_adequate": {"type": "boolean"}}}'
+            in prompt
+        )
         assert "You must respond with a JSON object that matches this schema:" in prompt
 
     def test_research_validation_system_vars_not_empty(self) -> None:
         """Test that ResearchValidationSystemVars is no longer empty."""
-        system_vars = ResearchValidationSystemVars(
-            response_schema='{"type": "object"}'
-        )
+        system_vars = ResearchValidationSystemVars(response_schema='{"type": "object"}')
         assert system_vars.response_schema == '{"type": "object"}'
 
         # Verify it has the expected field
-        assert hasattr(system_vars, 'response_schema')
-        assert ResearchValidationSystemVars.model_fields['response_schema'].description == "JSON schema for the expected response format"
+        assert hasattr(system_vars, "response_schema")
+        assert (
+            ResearchValidationSystemVars.model_fields["response_schema"].description
+            == "JSON schema for the expected response format"
+        )
 
     def test_prompts_directory_access(self) -> None:
         """Test that prompts directory is accessible via importlib.resources."""