chore: Display a Selected Scan Button

Add the user interface for `OSBARCScanButton` when its feature is enabled, similar to what `OSBARCTorchButton` does. This involves creating a new `isOn` property.
Indent `OSBARCTorchButton`'s view modifiers.
Improve Scanning performance by filtering the readable types on `VNDetectBarcodesRequest` creation.
Add vibration effect when a barcode is detected or the Scan button is activated.
Hide status bar on Scanner UI.

Author: OS-ricardomoreirasilva

OSBarcodeLib/Scanner/Interface Elements/OSBARCScanButton.swift

@@ -6,31 +6,44 @@ struct OSBARCScanButton: View {
     let action: () -> Void
     /// Text to be shown on the button.
     let text: String
+    /// Indicates if the feature is enabled or not.
+    let isOn: Bool
 
-    /// Colour to be set to the text.
-    private let foregroundColour: Color = OSBARCScannerViewConfigurationValues.mainColour
-    /// The colour to display outside the text.
-    private let backgroundColour: Color = OSBARCScannerViewConfigurationValues.secondaryColour
+    /// Text colour to use when the button's feature is set to `on`
+    private let selectedForegroundColour: Color = OSBARCScannerViewConfigurationValues.tertiaryColour
+    /// Text colour to use when the button's feature is set to `off`
+    private let notSelectedForegroundColour: Color = OSBARCScannerViewConfigurationValues.mainColour
+    /// Background colour to use when the button's feature is set to `on`.
+    private let selectedBackgroundColour: Color = OSBARCScannerViewConfigurationValues.mainColour
+    /// Background colour to use when the button's feature is set to `off`.
+    private let notSelectedBackgroundColour: Color = OSBARCScannerViewConfigurationValues.secondaryColour
     /// The colour of the button's outer line.
     private let overlayColour: Color = OSBARCScannerViewConfigurationValues.tertiaryColour
     /// Considering the button is displayed as a Rounded Rectangle, this is the radius of the button's vertices.
     private let cornerRadius: CGFloat = OSBARCScannerViewConfigurationValues.defaultRadius
     /// Width of the button's outer line.
     private let stroke: CGFloat = OSBARCScannerViewConfigurationValues.defaultLineStroke
 
+    /// Calculates the text colour to be used based on the `isOn` value.
+    private var foregroundColour: Color { isOn ? selectedForegroundColour : notSelectedForegroundColour }
+    /// Calculates the background colour to be used based on the `isOn` value.
+    private var backgroundColour: Color { isOn ? selectedBackgroundColour : notSelectedBackgroundColour }
+    
     var body: some View {
         Button(action: action) {
             Text(text)
                 .padding()
                 .foregroundStyle(forColour: foregroundColour)
-                .overlay(
-                    RoundedRectangle(cornerRadius: cornerRadius)
-                        .stroke(overlayColour, style: .init(lineWidth: stroke))
-                )
                 .background(
                     RoundedRectangle(cornerRadius: cornerRadius)
                         .foregroundColor(backgroundColour)
                 )
+                .if(!isOn) {
+                    $0.overlay(
+                        RoundedRectangle(cornerRadius: cornerRadius)
+                            .stroke(overlayColour, style: .init(lineWidth: stroke))
+                    )
+                }
         }
     }
 }

OSBarcodeLib/Scanner/Interface Elements/OSBARCTorchButton.swift

@@ -29,11 +29,16 @@ struct OSBARCTorchButton: View {
         Button(action: action) {
             Image(iconName, bundle: .init(for: OSBARCScannerBehaviour.self))    // xcassets item.
                 .frame(width: size, height: size)
-                .background(Circle().foregroundStyle(forColour: backgroundColour))
+                .background(
+                    Circle()
+                        .foregroundStyle(forColour: backgroundColour)
+                )
                 .if(!isOn) {
-                    $0.overlay(Circle().stroke(overlayColour, lineWidth: stroke))
+                    $0.overlay(
+                        Circle()
+                            .stroke(overlayColour, lineWidth: stroke)
+                    )
                 }
-                .foregroundStyle(forColour: .clear)
         }
     }
 }

OSBarcodeLib/Scanner/OSBARCScannerView.swift

@@ -77,8 +77,11 @@ struct OSBARCScannerView: View {
     /// Scanning Button. It needs to enabled to appear.
     private var scanButton: OSBARCScanButton {
         OSBARCScanButton(action: {
-            buttonScanEnabled = true
-        }, text: buttonText)
+            buttonScanEnabled.toggle()
+            if buttonScanEnabled {
+                AudioServicesPlaySystemSound(kSystemSoundID_Vibrate)
+            }
+        }, text: buttonText, isOn: buttonScanEnabled)
     }
 
     /// The scanning zone, containing the aim and the hole.
@@ -237,6 +240,7 @@ struct OSBARCScannerView: View {
             }
         }
         .customIgnoreSafeArea()
+        .statusBarHidden(true)
     }
 }
 

OSBarcodeLib/Scanner/OSBARCScannerViewControllerCoordinator.swift

@@ -33,7 +33,7 @@ final class OSBARCScannerViewControllerCoordinator: NSObject, AVCaptureVideoData
 
     func captureOutput(_ output: AVCaptureOutput, didOutput sampleBuffer: CMSampleBuffer, from connection: AVCaptureConnection) {
         // Output should only be processed when scanning is automatically or it has been enabled through the Scan Button.
-        guard !self.scanThroughButton || scanButtonEnabled else { return }
+        guard !self.scanThroughButton || self.scanButtonEnabled else { return }
         guard let pixelBuffer = CMSampleBufferGetImageBuffer(sampleBuffer) else { return }
 
         var requestOptions: [VNImageOption: Any] = [:]
@@ -48,19 +48,21 @@ final class OSBARCScannerViewControllerCoordinator: NSObject, AVCaptureVideoData
 
     /// Vision request to perform. It gets initialised only once and when needed.
     lazy private var detectBarcodeRequest: VNDetectBarcodesRequest = {
-        .init(completionHandler: { request, error in
+        let barcodeRequest = VNDetectBarcodesRequest(completionHandler: { request, error in
             guard error == nil else { return }
             self.processClassification(for: request)
         })
+        barcodeRequest.symbologies = self.barcodeTypes
+        
+        return barcodeRequest
     }()
 
     /// Processes the Vision request to return the desired barcode value.
     /// - Parameter request: Vision request handler that performs image analysis.
     private func processClassification(for request: VNRequest) {
         DispatchQueue.main.async {
-            if let bestResult = request.results?.first as? VNBarcodeObservation,
-               let payload = bestResult.payloadStringValue,
-               self.barcodeTypes.contains(bestResult.symbology) {
+            if let bestResult = request.results?.first as? VNBarcodeObservation, let payload = bestResult.payloadStringValue {
+                AudioServicesPlaySystemSound(kSystemSoundID_Vibrate)
                 self.scanResult = payload
             }
         }