ROU-12069: Fix error that occured when the map was destroyed (#213)

* setting sonarcloud

* Fixing the issue that caused the exception

* Revert "setting sonarcloud"

This reverts commit bac1839.

* Removing unnecessary code

Author: rugoncalves

src/OutSystems/Maps/MapAPI/MapManager.ts

@@ -157,7 +157,7 @@ namespace OutSystems.Maps.MapAPI.MapManager {
 		map.dispose();
 
 		//Let's remove the empty markers references from the Markers API.
-		MarkerManager.RemoveAllMarkers(mapId, false);
+		MarkerManager.RemoveAllMarkersCreatedByAPI(mapId, false);
 	}
 
 	/**

src/OutSystems/Maps/MapAPI/MarkerManager.ts

@@ -32,6 +32,21 @@ namespace OutSystems.Maps.MapAPI.MarkerManager {
 		return map;
 	}
 
+	/**
+	 * Cleans the markerMap and markerArr from the marker with the given id.
+	 *
+	 * @param {string} markerId Id of the Marker to be removed
+	 */
+	function CleanMarkerArrays(markerId: string): void {
+		markerMap.has(markerId) && markerMap.delete(markerId);
+		markerArr.splice(
+			markerArr.findIndex((marker) => {
+				return marker?.equalsToID(markerId);
+			}),
+			1
+		);
+	}
+
 	/**
 	 * Creates and adds a marker to a map.
 	 *
@@ -275,16 +290,45 @@ namespace OutSystems.Maps.MapAPI.MarkerManager {
 		};
 		try {
 			const marker = GetMarkerById(markerId);
-			const map = marker.map;
-			map && map.removeMarker(markerId);
-
-			markerMap.delete(markerId);
-			markerArr.splice(
-				markerArr.findIndex((p) => {
-					return p && p.equalsToID(markerId);
-				}),
-				1
-			);
+			marker.map?.removeMarker(markerId);
+			CleanMarkerArrays(markerId);
+		} catch (error) {
+			responseObj.isSuccess = false;
+			responseObj.message = error.message;
+			responseObj.code = OSFramework.Maps.Enum.ErrorCodes.API_FailedRemoveMarker;
+		}
+
+		return JSON.stringify(responseObj);
+	}
+
+	/**
+	 * Removes all the markers created by the API.
+	 *
+	 * @export
+	 * @return {*}  {string}
+	 */
+	// eslint-disable-next-line @typescript-eslint/naming-convention
+	export function RemoveAllMarkersCreatedByAPI(mapId: string, removeFromMap = true): string {
+		const responseObj = {
+			isSuccess: true,
+			message: 'Success',
+			code: '200',
+		};
+		try {
+			if (removeFromMap) {
+				// First we try to remove the markers from the map.
+				MapManager.RemoveMarkers(mapId);
+			}
+
+			for (const [storedMarkerId, storedMapId] of markerMap) {
+				if (storedMapId === mapId) {
+					const marker = GetMarkerById(storedMarkerId, false);
+					if (marker && marker.widgetId === undefined) {
+						// If the marker does not have a widgetId, it means it was created by
+						CleanMarkerArrays(storedMarkerId);
+					}
+				}
+			}
 		} catch (error) {
 			responseObj.isSuccess = false;
 			responseObj.message = error.message;
@@ -316,13 +360,7 @@ namespace OutSystems.Maps.MapAPI.MarkerManager {
 			// Second remove the markers to destroy from local variables.
 			markerMap.forEach((storedMapId, storedMarkerId) => {
 				if (mapId === storedMapId) {
-					markerMap.delete(storedMarkerId);
-					markerArr.splice(
-						markerArr.findIndex((p) => {
-							return p && p.equalsToID(storedMarkerId);
-						}),
-						1
-					);
+					CleanMarkerArrays(storedMarkerId);
 				}
 			});
 		} catch (error) {