ft/recomendaciones terminado + extract methods + exception

Author: GermanSchmuker

src/main/java/com/outfitlab/project/domain/exceptions/GarmentNotFoundException.java

@@ -0,0 +1,7 @@
+package com.outfitlab.project.domain.exceptions;
+
+public class GarmentNotFoundException extends Exception {
+    public GarmentNotFoundException(String message) {
+        super(message);
+    }
+}

src/main/java/com/outfitlab/project/domain/interfaces/repositories/GarmentRecomendationRepository.java

@@ -1,11 +1,12 @@
 package com.outfitlab.project.domain.interfaces.repositories;
 
+import com.outfitlab.project.domain.exceptions.GarmentNotFoundException;
 import com.outfitlab.project.domain.model.GarmentRecomendationModel;
 
 import java.util.List;
 
 public interface GarmentRecomendationRepository {
 
-    List<GarmentRecomendationModel> findRecomendationsByGarmentCode(String garmentCode);
+    List<GarmentRecomendationModel> findRecomendationsByGarmentCode(String garmentCode) throws GarmentNotFoundException;
 
 }

src/main/java/com/outfitlab/project/domain/useCases/garment/GetGarmentRecomendation.java

@@ -1,5 +1,6 @@
 package com.outfitlab.project.domain.useCases.garment;
 
+import com.outfitlab.project.domain.exceptions.GarmentNotFoundException;
 import com.outfitlab.project.domain.interfaces.repositories.GarmentRecomendationRepository;
 import com.outfitlab.project.domain.model.GarmentRecomendationModel;
 
@@ -13,7 +14,7 @@ public GetGarmentRecomendation(GarmentRecomendationRepository garmentRecomendati
         this.garmentRecomendationRepository = garmentRecomendationRepository;
     }
 
-    public List<GarmentRecomendationModel> execute(String garmentCode) {
+    public List<GarmentRecomendationModel> execute(String garmentCode) throws GarmentNotFoundException {
         return this.garmentRecomendationRepository.findRecomendationsByGarmentCode(garmentCode);
     }
 }

src/main/java/com/outfitlab/project/infrastructure/config/RecomendationConfig.java

@@ -0,0 +1,23 @@
+package com.outfitlab.project.infrastructure.config;
+
+import com.outfitlab.project.domain.interfaces.repositories.GarmentRecomendationRepository;
+import com.outfitlab.project.domain.useCases.garment.GetGarmentRecomendation;
+import com.outfitlab.project.infrastructure.repositories.RecomendationRepository;
+import com.outfitlab.project.infrastructure.repositories.interfaces.GarmentJpaRepository;
+import com.outfitlab.project.infrastructure.repositories.interfaces.RecomendationJpaRepository;
+import org.springframework.context.annotation.Bean;
+import org.springframework.context.annotation.Configuration;
+
+@Configuration
+public class RecomendationConfig {
+
+    @Bean
+    public GarmentRecomendationRepository RecomendationRepository(RecomendationJpaRepository recomendationJpaRepository, GarmentJpaRepository garmentJpaRepository) {
+        return new RecomendationRepository(recomendationJpaRepository, garmentJpaRepository);
+    }
+
+    @Bean
+    public GetGarmentRecomendation getGarmentRecomendation(GarmentRecomendationRepository garmentRecomendationRepository){
+        return new GetGarmentRecomendation(garmentRecomendationRepository);
+    }
+}

src/main/java/com/outfitlab/project/infrastructure/model/PrendaEntity.java

@@ -29,7 +29,7 @@ public class PrendaEntity {
     @Column(nullable = false)
     private String imagenUrl;
 
-    @Column(nullable = false, unique = true)
+    @Column(unique = true)
     private String garmentCode;
 
     @ManyToOne(fetch = FetchType.LAZY)

src/main/java/com/outfitlab/project/infrastructure/repositories/RecomendationRepository.java

@@ -1,11 +1,13 @@
 package com.outfitlab.project.infrastructure.repositories;
 
+import com.outfitlab.project.domain.exceptions.GarmentNotFoundException;
 import com.outfitlab.project.domain.interfaces.repositories.GarmentRecomendationRepository;
 import com.outfitlab.project.domain.model.GarmentRecomendationModel;
 import com.outfitlab.project.infrastructure.model.GarmentRecomendationEntity;
 import com.outfitlab.project.infrastructure.model.PrendaEntity;
 import com.outfitlab.project.infrastructure.repositories.interfaces.GarmentJpaRepository;
 import com.outfitlab.project.infrastructure.repositories.interfaces.RecomendationJpaRepository;
+import org.jetbrains.annotations.NotNull;
 
 import java.util.List;
 import java.util.stream.Collectors;
@@ -21,20 +23,29 @@ public RecomendationRepository(RecomendationJpaRepository recomendationJpaReposi
     }
 
     @Override
-    public List<GarmentRecomendationModel> findRecomendationsByGarmentCode(String garmentCode) {
-        PrendaEntity garment = this.garmentJpaRepository.findByGarmentCode(garmentCode);
+    public List<GarmentRecomendationModel> findRecomendationsByGarmentCode(String garmentCode) throws GarmentNotFoundException {
+        return getGarmentRecomendationEntities(getPrendaEntity(garmentCode)).stream()
+                .map(GarmentRecomendationEntity::convertToModel)
+                .collect(Collectors.toList());
+    }
 
+    private List<GarmentRecomendationEntity> getGarmentRecomendationEntities(PrendaEntity garment) {
         List<GarmentRecomendationEntity> recomendations;
 
-        if (garment.getTipo().equalsIgnoreCase("SUPERIOR")) {
-            recomendations = this.recomendationJpaRepository.findByTopGarment(garment.getId()); // si es superior, bsco combinaciones buscando por superior
-        } else{
-            recomendations = this.recomendationJpaRepository.findByBottomGarment(garment.getId()); // y si es inferior, al revéz, busco combinaciones por inferior
-        }
+        if (garment.getTipo().equalsIgnoreCase("SUPERIOR"))
+            recomendations = this.recomendationJpaRepository.findByTopGarment(garment); // si es superior, bsco combinaciones buscando por superior
+        else
+            recomendations = this.recomendationJpaRepository.findByBottomGarment(garment); // y si es inferior, al revéz, busco combinaciones por inferior
 
-        return recomendations.stream()
-                .map(GarmentRecomendationEntity::convertToModel)
-                .collect(Collectors.toList());
+        return recomendations;
+    }
+
+    @NotNull
+    private PrendaEntity getPrendaEntity(String garmentCode) throws GarmentNotFoundException {
+        PrendaEntity garment = this.garmentJpaRepository.findByGarmentCode(garmentCode);
+
+        if (garment == null) throw new GarmentNotFoundException("No encontramos la prenda con el código: " + garmentCode);
+        return garment;
     }
 
 }

src/main/java/com/outfitlab/project/infrastructure/repositories/interfaces/RecomendationJpaRepository.java

@@ -1,13 +1,14 @@
 package com.outfitlab.project.infrastructure.repositories.interfaces;
 
 import com.outfitlab.project.infrastructure.model.GarmentRecomendationEntity;
+import com.outfitlab.project.infrastructure.model.PrendaEntity;
 import org.springframework.data.jpa.repository.JpaRepository;
 
 import java.util.List;
 
 public interface RecomendationJpaRepository extends JpaRepository<GarmentRecomendationEntity, Long> {
 
-    List<GarmentRecomendationEntity> findByTopGarment(Long garmentId);
-    List<GarmentRecomendationEntity> findByBottomGarment(Long garmentId);
+    List<GarmentRecomendationEntity> findByTopGarment(PrendaEntity garment);
+    List<GarmentRecomendationEntity> findByBottomGarment(PrendaEntity garment);
 
 }

src/main/java/com/outfitlab/project/presentation/RecomendationController.java

@@ -1,8 +1,6 @@
 package com.outfitlab.project.presentation;
 
 import com.outfitlab.project.domain.useCases.garment.GetGarmentRecomendation;
-import com.outfitlab.project.infrastructure.repositories.RecomendationRepository;
-import lombok.AllArgsConstructor;
 import org.springframework.http.ResponseEntity;
 import org.springframework.web.bind.annotation.GetMapping;
 import org.springframework.web.bind.annotation.PathVariable;