Bump solana-snapshot-finder-go to fix histogram bar panic

Updates the snapshot finder dependency to include the fix for
negative strings.Repeat in version distribution histogram bars.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: 7layermagik

go.mod

@@ -111,7 +111,7 @@ require (
 require (
 	filippo.io/edwards25519 v1.0.0
 	github.com/Overclock-Validator/bgls v0.0.0-20250309141600-b7db1bfbf3fa
-	github.com/Overclock-Validator/solana-snapshot-finder-go v0.0.0-20251229023828-edd283e1db59
+	github.com/Overclock-Validator/solana-snapshot-finder-go v0.0.0-20260223201452-d8363b514fc0
 	github.com/Overclock-Validator/wide v0.0.0-20250221123529-f80959d02044
 	github.com/acarl005/stripansi v0.0.0-20180116102854-5a71ef0e047d // indirect
 	github.com/andres-erbsen/clock v0.0.0-20160526145045-9e14626cd129 // indirect
@@ -145,7 +145,6 @@ require (
 	github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd // indirect
 	github.com/modern-go/reflect2 v1.0.2 // indirect
 	github.com/mostynb/zstdpool-freelist v0.0.0-20201229113212-927304c0c3b1 // indirect
-	github.com/nixberg/chacha-rng-go v0.1.0
 	github.com/oasisprotocol/curve25519-voi v0.0.0-20230904125328-1f23a7beb09a
 	github.com/panjf2000/ants/v2 v2.10.0
 	github.com/pierrec/lz4/v4 v4.1.22

go.sum

@@ -12,8 +12,8 @@ github.com/Overclock-Validator/crypto v0.0.0-20250307094320-aaf52fac5261 h1:Y715
 github.com/Overclock-Validator/crypto v0.0.0-20250307094320-aaf52fac5261/go.mod h1:ZhRHOaVg8I1gg0VK4wmqOQPnlgPgKFT9McZ+TCW/hBA=
 github.com/Overclock-Validator/gnark-crypto v0.0.0-20250309203346-2a67ed08a105 h1:mP6FWHZ8ddcmbE8UTrVVI2Mi2c24aqX/8p12Vn6zokQ=
 github.com/Overclock-Validator/gnark-crypto v0.0.0-20250309203346-2a67ed08a105/go.mod h1:Poczuq3dbt+CwyTKgOjGaEwJOMP7YxQobF7QhgNcguk=
-github.com/Overclock-Validator/solana-snapshot-finder-go v0.0.0-20251229023828-edd283e1db59 h1:feitrhIizLqjrve6eKpW7v5MyRmUIEt/tBS/4EQVzMo=
-github.com/Overclock-Validator/solana-snapshot-finder-go v0.0.0-20251229023828-edd283e1db59/go.mod h1:5Ta/wyu0gfzgktCaW1N9vjSwM81Dy3tdty9ruJgBm88=
+github.com/Overclock-Validator/solana-snapshot-finder-go v0.0.0-20260223201452-d8363b514fc0 h1:elgavEQb8l7Zn3gS3Y+2/98PlUylOWdlM3V1VumQ7mA=
+github.com/Overclock-Validator/solana-snapshot-finder-go v0.0.0-20260223201452-d8363b514fc0/go.mod h1:XbqbvMA2NKeosY0w3WdBOpCg2eYJesBjfE4cNt9HSE8=
 github.com/Overclock-Validator/wide v0.0.0-20250221123529-f80959d02044 h1:ph9gnWIY116AWT/iCfXoPe9/cn2aWx2uJBuLdf/LyEE=
 github.com/Overclock-Validator/wide v0.0.0-20250221123529-f80959d02044/go.mod h1:hEf1+Hyc8cRJzEKo448RtaFGZzpP2RVNrfBTTEvkThs=
 github.com/VividCortex/ewma v1.2.0 h1:f58SaIzcDXrSy3kWaHNvuJgJ3Nmz59Zji6XoJR/q1ow=

pkg/snapshotdl/snapshotdl.go

@@ -3,8 +3,10 @@ package snapshotdl
 import (
 	"context"
 	"fmt"
+	stdlog "log"
 	"strconv"
 	"strings"
+	"sync"
 	"time"
 
 	"github.com/Overclock-Validator/mithril/pkg/mlog"
@@ -13,6 +15,26 @@ import (
 	"github.com/Overclock-Validator/solana-snapshot-finder-go/pkg/snapshot"
 )
 
+// stdlogMu protects global log config changes from racing if multiple
+// snapshot flows run concurrently.
+var stdlogMu sync.Mutex
+
+// suppressStdlogTimestamps temporarily strips stdlib log flags/prefix so
+// snapshot-finder output matches Mithril style. Caller must defer the
+// returned restore function.
+func suppressStdlogTimestamps() func() {
+	stdlogMu.Lock()
+	oldFlags := stdlog.Flags()
+	oldPrefix := stdlog.Prefix()
+	stdlog.SetFlags(0)
+	stdlog.SetPrefix("")
+	return func() {
+		stdlog.SetFlags(oldFlags)
+		stdlog.SetPrefix(oldPrefix)
+		stdlogMu.Unlock()
+	}
+}
+
 // SnapshotInfo contains details about a selected snapshot source.
 // This is returned by GetSnapshotURLWithInfo for display purposes.
 type SnapshotInfo struct {
@@ -176,7 +198,6 @@ func (sc SnapshotConfig) toInternalConfig(path string) config.Config {
 		AllowedNodeVersions:  sc.AllowedNodeVersions,
 		MaxFullSnapshots:  sc.MaxFullSnapshots,
 		SafetyMarginSlots: sc.SafetyMarginSlots,
-		Quiet:                true, // Mithril prints its own summary
 	}
 }
 
@@ -290,6 +311,7 @@ func DownloadSnapshot(ctx context.Context, rpcEndpoints []string, path string) (
 // The returned URL can be passed directly to snapshot processing functions
 // which will stream the data from HTTP (no disk download required).
 func GetSnapshotURL(ctx context.Context, snapCfg SnapshotConfig) (string, int, int, error) {
+	defer suppressStdlogTimestamps()()
 	cfg := snapCfg.toInternalConfig("")
 
 	// Step 1: Get reference slot from multiple RPCs for reliability
@@ -317,7 +339,7 @@ func GetSnapshotURL(ctx context.Context, snapCfg SnapshotConfig) (string, int, i
 
 	// Step 4: Sort and select best nodes by download speed
 	// Note: This also populates filter pipeline stats in ProbeStats
-	bestNodes, _, speedStats := rpc.SortBestNodesWithStats(results, cfg, stats, referenceSlot)
+	bestNodes, _ := rpc.SortBestNodesWithStats(results, cfg, stats, referenceSlot)
 	if len(bestNodes) == 0 {
 		return "", 0, 0, fmt.Errorf("no suitable nodes found with snapshots")
 	}
@@ -331,8 +353,7 @@ func GetSnapshotURL(ctx context.Context, snapCfg SnapshotConfig) (string, int, i
 			MinVersion:      cfg.MinNodeVersion,
 			AllowedVersions: cfg.AllowedNodeVersions,
 		}
-		stats.PrintNodeDiscoveryReport()
-		stats.PrintFilterPipeline(filterCfg, speedStats)
+		stats.PrintReport(filterCfg)
 	}
 
 	// Step 5: Get snapshot URL from best nodes (with configurable fallback)
@@ -399,6 +420,7 @@ func GetSnapshotURL(ctx context.Context, snapCfg SnapshotConfig) (string, int, i
 // This is like GetSnapshotURL but returns a SnapshotInfo struct with additional
 // details useful for display (node IP, version, speed, age).
 func GetSnapshotURLWithInfo(ctx context.Context, snapCfg SnapshotConfig) (*SnapshotInfo, error) {
+	defer suppressStdlogTimestamps()()
 	cfg := snapCfg.toInternalConfig("")
 
 	// Step 1: Get reference slot from multiple RPCs for reliability
@@ -424,11 +446,6 @@ func GetSnapshotURLWithInfo(ctx context.Context, snapCfg SnapshotConfig) (*Snaps
 	// This prevents selecting a fast full snapshot that has no compatible incrementals
 	results, incBaseStats := filterByIncrementalBaseMatch(results)
 
-	// Print Node Discovery Report (before speed testing)
-	if stats != nil {
-		stats.PrintNodeDiscoveryReport()
-	}
-
 	// Print incremental base match stats
 	if incBaseStats.totalWithFull > 0 {
 		mlog.Log.Infof("Incremental base matching: %d/%d full snapshots have compatible incrementals (%d unique base slots)",
@@ -442,49 +459,23 @@ func GetSnapshotURLWithInfo(ctx context.Context, snapCfg SnapshotConfig) (*Snaps
 	// Step 4: Sort and select best nodes by download speed
 	// Note: This also populates filter pipeline stats in ProbeStats
 	mlog.Log.Infof("Testing download speeds (Stage 1 + Stage 2)...")
-	bestNodes, rankedNodes, speedStats := rpc.SortBestNodesWithStats(results, cfg, stats, referenceSlot)
+	bestNodes, rankedNodes := rpc.SortBestNodesWithStats(results, cfg, stats, referenceSlot)
 	if len(bestNodes) == 0 {
 		return nil, fmt.Errorf("no suitable nodes found with snapshots (check incremental base matching)")
 	}
 
-	// Print Stage 2 candidates as a table (no timestamps)
-	maxCandidates := 8
-	if len(rankedNodes) < maxCandidates {
-		maxCandidates = len(rankedNodes)
-	}
-	candidates := make([]rpc.RankedNodeInfo, maxCandidates)
-	for i := 0; i < maxCandidates; i++ {
-		rn := rankedNodes[i]
-		candidates[i] = rpc.RankedNodeInfo{
-			Rank:    i + 1,
-			RPC:     rn.Result.RPC,
-			Version: rn.Result.Version,
-			RTTMs:   int(rn.Result.Latency), // Latency is already in milliseconds
-			SpeedS1: rn.S1.MedianMBs,
-			SpeedS2: rn.S2.MinMBs,
-		}
-	}
-	rpc.PrintStage2CandidatesTable(candidates)
-
-	// Print Filter Pipeline with speed test stats (after speed testing, before source selection)
-	filterCfg := rpc.FilterConfig{
-		MaxRTTMs:        cfg.MaxRTTMs,
-		FullThreshold:   cfg.FullThreshold,
-		IncThreshold:    cfg.IncrementalThreshold,
-		MinVersion:      cfg.MinNodeVersion,
-		AllowedVersions: cfg.AllowedNodeVersions,
-	}
+	// Print statistics report (after filtering is complete)
 	if stats != nil {
-		stats.PrintFilterPipeline(filterCfg, speedStats)
+		filterCfg := rpc.FilterConfig{
+			MaxRTTMs:        cfg.MaxRTTMs,
+			FullThreshold:   cfg.FullThreshold,
+			IncThreshold:    cfg.IncrementalThreshold,
+			MinVersion:      cfg.MinNodeVersion,
+			AllowedVersions: cfg.AllowedNodeVersions,
+		}
+		stats.PrintReport(filterCfg)
 	}
 
-	// Speed test log writing disabled - uncomment to enable
-	// if speedStats != nil && snapCfg.LogDir != "" {
-	// 	if err := speedStats.WriteSpeedTestLog(snapCfg.LogDir, filterCfg); err != nil {
-	// 		mlog.Log.Infof("Warning: failed to write speed test log: %v", err)
-	// 	}
-	// }
-
 	// Step 5: Get snapshot URL from best nodes (with configurable fallback)
 	var snapshotURL string
 	var snapshotSlot int
@@ -574,6 +565,7 @@ func GetSnapshotURLWithInfo(ctx context.Context, snapCfg SnapshotConfig) (*Snaps
 
 // DownloadSnapshotWithConfig is like DownloadSnapshot but accepts custom config
 func DownloadSnapshotWithConfig(ctx context.Context, path string, snapCfg SnapshotConfig) (string, int, int, error) {
+	defer suppressStdlogTimestamps()()
 	cfg := snapCfg.toInternalConfig(path)
 
 	// Step 1: Get reference slot from multiple RPCs for reliability
@@ -601,7 +593,7 @@ func DownloadSnapshotWithConfig(ctx context.Context, path string, snapCfg Snapsh
 
 	// Step 4: Sort and select best nodes by download speed
 	// Note: This also populates filter pipeline stats in ProbeStats
-	bestNodes, _, speedStats := rpc.SortBestNodesWithStats(results, cfg, stats, referenceSlot)
+	bestNodes, _ := rpc.SortBestNodesWithStats(results, cfg, stats, referenceSlot)
 	if len(bestNodes) == 0 {
 		return "", 0, 0, fmt.Errorf("no suitable nodes found with snapshots")
 	}
@@ -615,8 +607,7 @@ func DownloadSnapshotWithConfig(ctx context.Context, path string, snapCfg Snapsh
 			MinVersion:      cfg.MinNodeVersion,
 			AllowedVersions: cfg.AllowedNodeVersions,
 		}
-		stats.PrintNodeDiscoveryReport()
-		stats.PrintFilterPipeline(filterCfg, speedStats)
+		stats.PrintReport(filterCfg)
 	}
 
 	// Step 5: Download snapshot from best nodes (with configurable fallback)
@@ -694,6 +685,7 @@ func DownloadIncrementalSnapshot(rpcEndpoints []string, path string, referenceSl
 
 // DownloadIncrementalSnapshotWithConfig is like DownloadIncrementalSnapshot but accepts custom config
 func DownloadIncrementalSnapshotWithConfig(path string, referenceSlot int, fullSnapshotSlot int, snapCfg SnapshotConfig) (string, int, int, error) {
+	defer suppressStdlogTimestamps()()
 	cfg := snapCfg.toInternalConfig(path)
 	ctx := context.Background()
 
@@ -720,8 +712,7 @@ func DownloadIncrementalSnapshotWithConfig(path string, referenceSlot int, fullS
 			MinVersion:      cfg.MinNodeVersion,
 			AllowedVersions: cfg.AllowedNodeVersions,
 		}
-		stats.PrintNodeDiscoveryReport()
-		stats.PrintFilterPipeline(filterCfg, nil)
+		stats.PrintReport(filterCfg)
 	}
 
 	// Step 3: Filter to only nodes with matching incremental base slot FIRST
@@ -740,7 +731,7 @@ func DownloadIncrementalSnapshotWithConfig(path string, referenceSlot int, fullS
 	}
 
 	// Step 3.5: Apply threshold filtering with two-pass approach
-	bestNodes, rankedNodes, _ := rpc.SortBestRPCsFilteredBySlot(
+	bestNodes, rankedNodes := rpc.SortBestRPCsFilteredBySlot(
 		baseMatchingResults, cfg, stats, int64(fullSnapshotSlot), referenceSlot)
 
 	// Pass 2: If no matches, relax incremental threshold
@@ -751,7 +742,7 @@ func DownloadIncrementalSnapshotWithConfig(path string, referenceSlot int, fullS
 
 		relaxedCfg := cfg
 		relaxedCfg.IncrementalThreshold = relaxedThreshold
-		bestNodes, rankedNodes, _ = rpc.SortBestRPCsFilteredBySlot(
+		bestNodes, rankedNodes = rpc.SortBestRPCsFilteredBySlot(
 			baseMatchingResults, relaxedCfg, nil, int64(fullSnapshotSlot), referenceSlot)
 	}
 
@@ -867,6 +858,7 @@ func extractFullSnapshotSlot(path string) int {
 //    b. Speed (faster downloads preferred when end slots are equal)
 // 4. Try multiple candidates for resilience (uses MaxSnapshotURLAttempts)
 func GetIncrementalSnapshotURL(fullSnapshotURL string, referenceSlot int, fullSnapshotSlot int, snapCfg SnapshotConfig) (string, int, int, error) {
+	defer suppressStdlogTimestamps()()
 	cfg := snapCfg.toInternalConfig("")
 	ctx := context.Background()
 
@@ -927,8 +919,7 @@ func GetIncrementalSnapshotURL(fullSnapshotURL string, referenceSlot int, fullSn
 			MinVersion:      cfg.MinNodeVersion,
 			AllowedVersions: cfg.AllowedNodeVersions,
 		}
-		stats.PrintNodeDiscoveryReport()
-		stats.PrintFilterPipeline(filterCfg, nil)
+		stats.PrintReport(filterCfg)
 	}
 
 	// Step 2.1: Filter to only nodes with matching base slot FIRST (before threshold filtering)
@@ -952,7 +943,7 @@ func GetIncrementalSnapshotURL(fullSnapshotURL string, referenceSlot int, fullSn
 	var matchingNodes []rpc.RankedNode
 
 	// Pass 1: Apply normal incremental threshold
-	_, rankedNodes, _ := rpc.SortBestRPCsFilteredBySlot(
+	_, rankedNodes := rpc.SortBestRPCsFilteredBySlot(
 		baseMatchingResults, cfg, stats, int64(fullSnapshotSlot), referenceSlot)
 	for _, node := range rankedNodes {
 		matchingNodes = append(matchingNodes, node)
@@ -968,7 +959,7 @@ func GetIncrementalSnapshotURL(fullSnapshotURL string, referenceSlot int, fullSn
 		relaxedCfg := cfg
 		relaxedCfg.IncrementalThreshold = relaxedThreshold
 
-		_, rankedNodesRelaxed, _ := rpc.SortBestRPCsFilteredBySlot(
+		_, rankedNodesRelaxed := rpc.SortBestRPCsFilteredBySlot(
 			baseMatchingResults, relaxedCfg, nil, int64(fullSnapshotSlot), referenceSlot)
 		for _, node := range rankedNodesRelaxed {
 			matchingNodes = append(matchingNodes, node)