Skip to content

Commit 317e18e

Browse files
Merge pull request #71 from jeremy-costello/main
fix record_batch_reader params in geodataframe
2 parents a210f55 + 03fb12e commit 317e18e

File tree

1 file changed

+13
-5
lines changed

1 file changed

+13
-5
lines changed

overturemaps/core.py

Lines changed: 13 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,13 +16,12 @@
1616

1717
# Allows for optional import of additional dependencies
1818
try:
19-
import geopandas as gpd
2019
from geopandas import GeoDataFrame
2120

2221
HAS_GEOPANDAS = True
2322
except ImportError:
2423
HAS_GEOPANDAS = False
25-
GeoDataFrame = None
24+
class GeoDataFrame: pass
2625

2726

2827
def _get_stac_catalog() -> dict:
@@ -251,9 +250,11 @@ def record_batch_reader(
251250

252251
def geodataframe(
253252
overture_type: str,
254-
bbox: (float, float, float, float) = None,
253+
bbox: tuple[float, float, float, float] = None,
254+
release: str = None,
255255
connect_timeout: int = None,
256256
request_timeout: int = None,
257+
stac: bool = False
257258
) -> GeoDataFrame:
258259
"""
259260
Loads geoparquet for specified type into a geopandas dataframe
@@ -273,8 +274,15 @@ def geodataframe(
273274
if not HAS_GEOPANDAS:
274275
raise ImportError("geopandas is required to use this function")
275276

276-
reader = record_batch_reader(overture_type, bbox, connect_timeout, request_timeout)
277-
return gpd.GeoDataFrame.from_arrow(reader)
277+
reader = record_batch_reader(
278+
overture_type,
279+
bbox=bbox,
280+
release=release,
281+
connect_timeout=connect_timeout,
282+
request_timeout=request_timeout,
283+
stac=stac
284+
)
285+
return GeoDataFrame.from_arrow(reader)
278286

279287

280288
def geoarrow_schema_adapter(schema: pa.Schema) -> pa.Schema:

0 commit comments

Comments
 (0)