Remove AsRef generics to reduce compilation time & binary size

Replaces all generic `AsRef<X>` uses with `&X` direct references.

Includes all instances of a generic parameter of the form `Y: AsRef<X>` and
`impl AsRef<X>`. Notably, this included many `AsRef<str>` and `AsRef<Path>`,
which are now replaced with `&str` and `&Path`, respectively.

This cuts down on compilation time and binary size considerably. Since
Rust monomorphizes generics: it must compile new variants of each function
for every different concrete type use. Unlike other traits, the codebase's
use of `AsRef` doesn't provide much utility as we nearly never swap-out
different things that could be turned into the reference type. The code is
not only smaller and faster to compile, it is clearer in what, exactly,
it requires and what it exactly operates on.

Author: malcolmgreaves

crates/cli/src/cmd/branch.rs

@@ -196,8 +196,8 @@ impl BranchCmd {
     ) -> Result<(), OxenError> {
         let (scheme, host) = get_scheme_and_host_from_repo(repo)?;
 
-        check_remote_version_blocking(scheme.clone(), host.clone()).await?;
-        check_remote_version(scheme, host).await?;
+        check_remote_version_blocking(&scheme, &host).await?;
+        check_remote_version(&scheme, &host).await?;
 
         let remote = repo
             .get_remote(remote_name)
@@ -219,7 +219,7 @@ impl BranchCmd {
     ) -> Result<(), OxenError> {
         let (scheme, host) = get_scheme_and_host_from_repo(repo)?;
 
-        check_remote_version(scheme, host).await?;
+        check_remote_version(&scheme, &host).await?;
 
         api::client::branches::delete_remote(repo, remote_name, branch_name).await?;
         Ok(())

crates/cli/src/cmd/checkout.rs

@@ -3,6 +3,7 @@ use clap::{Arg, Command};
 use liboxen::error::OxenError;
 use liboxen::model::LocalRepository;
 use liboxen::repositories;
+use std::path::Path;
 
 use crate::cmd::RunCmd;
 pub const NAME: &str = "checkout";
@@ -96,12 +97,12 @@ impl CheckoutCmd {
         repo: &LocalRepository,
         path: &str,
     ) -> Result<(), OxenError> {
-        repositories::checkout::checkout_theirs(repo, path).await?;
+        repositories::checkout::checkout_theirs(repo, Path::new(path)).await?;
         Ok(())
     }
 
     pub async fn checkout_ours(&self, repo: &LocalRepository, path: &str) -> Result<(), OxenError> {
-        repositories::checkout::checkout_ours(repo, path).await?;
+        repositories::checkout::checkout_ours(repo, Path::new(path)).await?;
         Ok(())
     }
 

crates/cli/src/cmd/clone.rs

@@ -147,7 +147,7 @@ impl RunCmd for CloneCmd {
                 StorageOpts::default()
             }
             unsupported_backend => {
-                return Err(OxenError::basic_str(format!(
+                return Err(OxenError::basic_str(&format!(
                     "Unsupported async storage type: {unsupported_backend}"
                 )));
             }
@@ -171,8 +171,8 @@ impl RunCmd for CloneCmd {
         let (scheme, host) = api::client::get_scheme_and_host_from_url(&opts.url)?;
 
         // TODO: Do I need to worry about this for remote repo?
-        check_remote_version_blocking(scheme.clone(), host.clone()).await?;
-        check_remote_version(scheme, host).await?;
+        check_remote_version_blocking(&scheme, &host).await?;
+        check_remote_version(&scheme, &host).await?;
 
         repositories::clone(&opts).await?;
 

crates/cli/src/cmd/commit.rs

@@ -134,7 +134,7 @@ fn get_message_from_editor(maybe_config: Option<&UserConfig>) -> Result<String,
         .status()?;
 
     if !status.success() {
-        return Err(OxenError::basic_str(format!(
+        return Err(OxenError::basic_str(&format!(
             "Editor '{editor}' exited with non-zero status."
         )));
     }

crates/cli/src/cmd/db/count.rs

@@ -30,7 +30,7 @@ impl RunCmd for DbCountCmd {
             return Err(OxenError::basic_str("Must supply path"));
         };
 
-        let count = command::db::count(PathBuf::from(path))?;
+        let count = command::db::count(&PathBuf::from(path))?;
 
         println!("There are {count} entries in the database");
 

crates/cli/src/cmd/db/get.rs

@@ -38,7 +38,7 @@ impl RunCmd for DbGetCmd {
         };
 
         let dtype = args.get_one::<String>("dtype").map(|x| x.as_str());
-        let value = command::db::get(path, key, dtype)?;
+        let value = command::db::get(std::path::Path::new(path), key, dtype)?;
         println!("{value}");
 
         Ok(())

crates/cli/src/cmd/db/list.rs

@@ -40,7 +40,7 @@ impl RunCmd for DbListCmd {
             .get_one::<String>("limit")
             .map(|x| x.parse::<usize>().expect("limit must be valid size"));
 
-        command::db::list(PathBuf::from(path), limit)?;
+        command::db::list(&PathBuf::from(path), limit)?;
 
         Ok(())
     }

crates/cli/src/cmd/delete_remote.rs

@@ -88,7 +88,7 @@ impl RunCmd for DeleteRemoteCmd {
                     return Ok(());
                 }
                 Err(e) => {
-                    return Err(OxenError::basic_str(format!(
+                    return Err(OxenError::basic_str(&format!(
                         "Error confirming deletion: {e}"
                     )));
                 }

crates/cli/src/cmd/df.rs

@@ -1,4 +1,4 @@
-use std::path::PathBuf;
+use std::path::{Path, PathBuf};
 
 use async_trait::async_trait;
 use clap::{Arg, ArgMatches, Command, arg};
@@ -255,13 +255,13 @@ impl RunCmd for DFCmd {
 
         if let Some(revision) = args.get_one::<String>("revision") {
             let repo = LocalRepository::from_current_dir()?;
-            command::df::df_revision(&repo, path, revision, opts).await?;
+            command::df::df_revision(&repo, Path::new(path), revision, opts).await?;
         } else if args.get_flag("schema") || args.get_flag("schema-flat") {
             let flatten = args.get_flag("schema-flat");
-            let result = command::df::schema(path, flatten, opts)?;
+            let result = command::df::schema(Path::new(path), flatten, opts)?;
             println!("{result}");
         } else {
-            command::df(path, opts).await?;
+            command::df(Path::new(path), opts).await?;
         }
 
         Ok(())

crates/cli/src/cmd/diff.rs

@@ -21,12 +21,12 @@ pub struct DiffCmd;
 
 fn write_to_pager(output: &mut Pager, text: &str) -> Result<(), OxenError> {
     write!(output, "{text}")
-        .map_err(|e| OxenError::basic_str(format!("Could not write to pager: {e}")))
+        .map_err(|e| OxenError::basic_str(&format!("Could not write to pager: {e}")))
 }
 
 fn writeln_to_pager(output: &mut Pager, text: &str) -> Result<(), OxenError> {
     writeln!(output, "{text}")
-        .map_err(|e| OxenError::basic_str(format!("Could not write to pager: {e}")))
+        .map_err(|e| OxenError::basic_str(&format!("Could not write to pager: {e}")))
 }
 
 #[async_trait]
@@ -339,7 +339,7 @@ impl DiffCmd {
                 match result {
                     DiffResult::Tabular(result) => {
                         let mut df = result.contents.clone();
-                        tabular::write_df(&mut df, file_path.clone())?;
+                        tabular::write_df(&mut df, &file_path.clone())?;
                     }
                     DiffResult::Text(_) => {
                         println!("Saving to disk not supported for text output");