Merge pull request #8 from OxfordAbstracts/fix-warning

clean up a few warns

Author: seastian

Makefile

@@ -81,7 +81,8 @@ profile:
 	@stack build
 	@cd ../application/purs-projects && \
 		(git diff --quiet && git diff --cached --quiet && git checkout 567cde598728d6a02fd22972c888e5194af383c4 || { echo "❌ dirty working directory on purs-projects, aborting checkout."; exit 1; }) && \
-		spago install && \
+		rm -rf .spago && \
+		spago fetch && \
 	    spago sources > .spago/sources.txt && \
 		rm -rf output
 

profile-admin.txt

@@ -1,27 +1,27 @@
 'purs' 'compile' '--source-globs-file' '.spago/sources.txt' +RTS '-N' '-A256m' '-n16m' '-sprofile.txt' 
- 764,715,301,176 bytes allocated in the heap
-  71,684,539,216 bytes copied during GC
-   5,771,888,480 bytes maximum residency (8 sample(s))
-      57,078,368 bytes maximum slop
-           19290 MiB total memory in use (0 MB lost due to fragmentation)
+ 764,684,334,200 bytes allocated in the heap
+  66,592,890,256 bytes copied during GC
+   5,965,029,568 bytes maximum residency (7 sample(s))
+      55,635,776 bytes maximum slop
+           19931 MiB total memory in use (0 MB lost due to fragmentation)
 
                                      Tot time (elapsed)  Avg pause  Max pause
-  Gen  0       347 colls,   347 par   109.302s  25.584s     0.0737s    0.8975s
-  Gen  1         8 colls,     7 par   33.883s   6.849s     0.8561s    2.4644s
+  Gen  0       344 colls,   344 par   109.657s  24.231s     0.0704s    0.9072s
+  Gen  1         7 colls,     6 par   27.205s   6.308s     0.9011s    2.6484s
 
-  Parallel GC work balance: 87.94% (serial 0%, perfect 100%)
+  Parallel GC work balance: 87.29% (serial 0%, perfect 100%)
 
-  TASKS: 63 (1 bound, 62 peak workers (62 total), using -N10)
+  TASKS: 61 (1 bound, 60 peak workers (60 total), using -N10)
 
   SPARKS: 7516 (7516 converted, 0 overflowed, 0 dud, 0 GC'd, 0 fizzled)
 
-  INIT    time    0.003s  (  0.156s elapsed)
-  MUT     time  340.588s  ( 94.439s elapsed)
-  GC      time  143.185s  ( 32.433s elapsed)
-  EXIT    time    0.108s  (  0.004s elapsed)
-  Total   time  483.883s  (127.032s elapsed)
+  INIT    time    0.003s  (  0.153s elapsed)
+  MUT     time  345.596s  ( 91.867s elapsed)
+  GC      time  136.862s  ( 30.539s elapsed)
+  EXIT    time    0.170s  (  0.001s elapsed)
+  Total   time  482.631s  (122.559s elapsed)
 
-  Alloc rate    2,245,281,654 bytes per MUT second
+  Alloc rate    2,212,653,609 bytes per MUT second
 
-  Productivity  70.4% of total user, 74.3% of total elapsed
+  Productivity  71.6% of total user, 75.0% of total elapsed
 

profile.txt

@@ -1,27 +1,27 @@
 'purs' 'compile' '--source-globs-file' '.spago/sources.txt' +RTS '-N' '-A256m' '-n16m' '-sprofile.txt' 
-1,514,670,705,400 bytes allocated in the heap
- 100,283,741,944 bytes copied during GC
-   3,311,678,824 bytes maximum residency (14 sample(s))
-      47,472,136 bytes maximum slop
-           11326 MiB total memory in use (0 MB lost due to fragmentation)
+1,514,656,409,184 bytes allocated in the heap
+  98,339,524,248 bytes copied during GC
+   3,076,113,760 bytes maximum residency (13 sample(s))
+      48,308,232 bytes maximum slop
+           11349 MiB total memory in use (0 MB lost due to fragmentation)
 
                                      Tot time (elapsed)  Avg pause  Max pause
-  Gen  0       693 colls,   693 par   196.375s  42.165s     0.0608s    0.5568s
-  Gen  1        14 colls,    13 par   37.234s   5.165s     0.3689s    0.5430s
+  Gen  0       697 colls,   697 par   202.812s  43.916s     0.0630s    0.6948s
+  Gen  1        13 colls,    12 par   32.681s   4.654s     0.3580s    0.5375s
 
-  Parallel GC work balance: 84.01% (serial 0%, perfect 100%)
+  Parallel GC work balance: 83.67% (serial 0%, perfect 100%)
 
-  TASKS: 68 (1 bound, 67 peak workers (67 total), using -N10)
+  TASKS: 69 (1 bound, 66 peak workers (68 total), using -N10)
 
   SPARKS: 7516 (7516 converted, 0 overflowed, 0 dud, 0 GC'd, 0 fizzled)
 
-  INIT    time    0.003s  (  0.191s elapsed)
-  MUT     time  692.332s  (136.117s elapsed)
-  GC      time  233.609s  ( 47.330s elapsed)
-  EXIT    time    0.053s  (  0.009s elapsed)
-  Total   time  925.997s  (183.648s elapsed)
+  INIT    time    0.003s  (  0.157s elapsed)
+  MUT     time  702.424s  (133.463s elapsed)
+  GC      time  235.493s  ( 48.571s elapsed)
+  EXIT    time    0.067s  (  0.008s elapsed)
+  Total   time  937.987s  (182.199s elapsed)
 
-  Alloc rate    2,187,780,137 bytes per MUT second
+  Alloc rate    2,156,328,748 bytes per MUT second
 
-  Productivity  74.8% of total user, 74.1% of total elapsed
+  Productivity  74.9% of total user, 73.3% of total elapsed
 

purescript.cabal

@@ -276,7 +276,6 @@ library
     Language.PureScript.CST.Positions
     Language.PureScript.CST.Print
     Language.PureScript.Ide.ToIde
-    Language.PureScript.Ide.ToI
     Language.PureScript.CST.Traversals
     Language.PureScript.CST.Traversals.Type
     Language.PureScript.CST.Types

src/Data/InternedName.hs

@@ -30,4 +30,4 @@ instance Serialise InternedName where
   decode = fmap internName decode
 
 instance NFData InternedName where
-  rnf (InternedName name) = ()
+  rnf (InternedName _) = ()

src/Language/PureScript/Ide.hs

@@ -20,7 +20,7 @@ module Language.PureScript.Ide
 
 import Protolude hiding (moduleName)
 
-import qualified Language.PureScript.Ide.Imports as IDEImports
+import Language.PureScript.Ide.Imports qualified as IDEImports
 import "monad-logger" Control.Monad.Logger (MonadLogger, logWarnN)
 import Data.Map qualified as Map
 import Data.Text qualified as T

src/Language/PureScript/Ide/Rebuild.hs

@@ -38,9 +38,6 @@ import Unsafe.Coerce (unsafeCoerce)
 import Database.SQLite.Simple (Query(fromQuery), ToRow, SQLData (SQLText))
 import Data.String (String)
 import Codec.Serialise (deserialise)
-import Language.PureScript (ModuleName)
-import Language.PureScript.Constants.Prim (primModules)
-import Data.Foldable (concat)
 
 -- | Given a filepath performs the following steps:
 --
@@ -68,7 +65,7 @@ rebuildFile
   -> (ReaderT IdeEnvironment (LoggingT IO) () -> m ())
   -- ^ A runner for the second build with open exports
   -> m Success
-rebuildFile file actualFile codegenTargets runOpenBuild = do
+rebuildFile file actualFile codegenTargets _ = do
   (fp, input) <-
     case List.stripPrefix "data:" file of
       Just source -> pure ("", Text.pack source)
@@ -249,7 +246,7 @@ sortExterns'
   => FilePath
   -> P.Module
   -> m [P.ExternsFile]
-sortExterns' outputDir m = do 
+sortExterns' _ m = do 
   let P.Module _ _ _ declarations _ = m
   let moduleDependencies = declarations >>= \case
               P.ImportDeclaration _ importName _ _ -> [importName]

src/Language/PureScript/Ide/State.hs

@@ -61,7 +61,6 @@ import Language.PureScript.Ide.Types
 import Language.PureScript.Ide.Util (discardAnn, opNameT, properNameT, runLogger)
 import System.Directory (getModificationTime)
 import Database.SQLite.Simple qualified as SQLite
-import Debug.Trace qualified as Debug
 import Data.Text qualified as T
 
 -- | Resets all State inside psc-ide
@@ -258,7 +257,7 @@ toIdeDeclarationAnn :: P.Module -> ExternsFile -> [IdeDeclarationAnn]
 toIdeDeclarationAnn m e = results
   where
   asts = extractAstInformation m
-  (moduleDeclarations, reexportRefs) = convertExterns e
+  (moduleDeclarations, _) = convertExterns e
   results =
         moduleDeclarations
         & resolveDataConstructorsForModule