Skip to content

Commit eac7f27

Browse files
committed
Don't store names - only count and fix limit
1 parent 0798ba5 commit eac7f27

File tree

1 file changed

+6
-13
lines changed

1 file changed

+6
-13
lines changed

datagen/generator.py

Lines changed: 6 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -149,7 +149,7 @@ def _write_meta(self) -> None:
149149
"camera_angles_range_v": self.camera_angles_range_v,
150150
"camera_distance_range": self.camera_distance_range,
151151
"render_per_input": self.render_per_input,
152-
"size": self._names,
152+
"size": self.generated_count,
153153
}
154154

155155
with open(os.path.join(self.dst, "meta.json"), "w") as f:
@@ -159,7 +159,7 @@ def _rendering_loop(self, writer: Union[csv.DictWriter, None]) -> None:
159159
if writer:
160160
writer.writeheader()
161161

162-
self._names = []
162+
self.generated_count = 0
163163
for i, base_name in enumerate(self.img_names):
164164
name, _ = os.path.splitext(base_name)
165165
for j in range(self.render_per_input):
@@ -170,25 +170,18 @@ def _rendering_loop(self, writer: Union[csv.DictWriter, None]) -> None:
170170
except Exception as e:
171171
logging.exception(f"Error with {i}: ", e)
172172
else:
173-
self._names.append(
174-
[
175-
base_name,
176-
os.path.abspath(
177-
os.path.join(self.dst, "images", render_name)
178-
),
179-
]
180-
)
181173
if writer:
182174
writer.writerow(
183-
{"base_img": base_name, "query_img": render_name}
175+
{"base_img": os.path.join(self.src, base_name), "query_img": os.path.join(self.dst, "images", render_name)}
184176
)
177+
self.generated_count += 1
185178

186179
if (
187180
self.max_images_to_render is not None
188-
and len(self._names) > self.max_images_to_render
181+
and self.generated_count >= self.max_images_to_render
189182
):
190183
logging.info("Finished at max images")
191-
break
184+
return
192185

193186
logging.info(f"Generated images for {i + 1} inputs")
194187

0 commit comments

Comments
 (0)