don't strongly capture self when handling messages

Author: lhoward

Sources/SwiftOCA/OCP.1/Ocp1ConnectionMonitor.swift

@@ -142,19 +142,19 @@ extension Ocp1Connection.Monitor {
   func receiveMessages(_ connection: Ocp1Connection) async throws {
     do {
       try await withThrowingTaskGroup(of: Void.self) { group in
-        group.addTask { [self] in
+        group.addTask { [weak self] in
           repeat {
             try Task.checkCancellation()
             do {
-              try await receiveMessage(connection)
+              try await self?.receiveMessage(connection)
             } catch Ocp1Error.invalidHandle {
             } catch Ocp1Error.unknownPduType {
             } catch Ocp1Error.retryOperation {}
           } while true
         }
         if connection.heartbeatTime > .zero {
-          group.addTask { [self] in
-            try await keepAlive(connection)
+          group.addTask { [weak self] in
+            try await self?.keepAlive(connection)
           }
         }
         try await group.next()

Sources/SwiftOCADevice/OCP.1/Ocp1ControllerInternal.swift

@@ -156,9 +156,9 @@ extension Ocp1ControllerInternal {
       endpoint.traceMessage(message, controller: self, direction: .rx)
     }
 
-    let responses = try await messageList.messages.asyncMap { @Sendable message in
+    let responses = try await messageList.messages.asyncMap { @Sendable [weak self] message in
       // note for stream connections this will only throw for invalidMessageType
-      try await _handle(for: endpoint, message: message)
+      try await self?._handle(for: endpoint, message: message)
     }
 
     if messageList.responseRequired {
@@ -180,8 +180,8 @@ extension Ocp1ControllerInternal {
     await withTaskGroup(of: Void.self) { group in
       do {
         for try await messageList in messages {
-          group.addTask {
-            try? await self.handle(for: endpoint, messageList: messageList)
+          group.addTask { [weak self] in
+            try? await self?.handle(for: endpoint, messageList: messageList)
           }
         }
       } catch Ocp1Error.notConnected {