Add unified model_config.ts to make updating default models a little easier.

rasmi · rasmi · commit 620e952a1dea · 2025-12-18T11:06:27.000-05:00
diff --git a/frontend/src/components/experiment_dashboard/agent_participant_configuration_dialog.ts b/frontend/src/components/experiment_dashboard/agent_participant_configuration_dialog.ts
@@ -14,10 +14,10 @@ import {ExperimentManager} from '../../services/experiment.manager';
 import {
   AgentPersonaConfig,
   CohortConfig,
-  ApiKeyType,
-  AgentPersonaType,
   createAgentModelSettings,
   DEFAULT_AGENT_PARTICIPANT_ID,
+  GEMINI_MODELS,
+  ModelOption,
 } from '@deliberation-lab/utils';
 
 import {styles} from './cohort_settings_dialog.scss';
@@ -38,7 +38,7 @@ export class AgentParticipantDialog extends MobxLitElement {
   @property() agentId = '';
   @property() promptContext = '';
   @property() agent: AgentPersonaConfig | undefined = undefined;
-  @property() model: string = '';
+  @property() selectedModel: ModelOption | null = null;
 
   private close() {
     this.dispatchEvent(new CustomEvent('close'));
@@ -78,19 +78,19 @@ export class AgentParticipantDialog extends MobxLitElement {
       ${this.renderAgentModel()} ${this.renderPromptContext()}
       <div class="buttons-wrapper">
         <pr-button
-          ?disabled=${this.model === ''}
+          ?disabled=${this.selectedModel === null}
           ?loading=${this.isLoading}
           @click=${() => {
             this.isLoading = true;
             this.analyticsService.trackButtonClick(
               ButtonClick.AGENT_PARTICIPANT_ADD,
             );
-            if (this.cohort && this.model) {
+            if (this.cohort && this.selectedModel) {
               this.experimentEditor.addAgentParticipant();
               this.agentId = DEFAULT_AGENT_PARTICIPANT_ID;
               const modelSettings = createAgentModelSettings({
-                apiType: ApiKeyType.GEMINI_API_KEY,
-                modelName: this.model,
+                apiType: this.selectedModel.apiType,
+                modelName: this.selectedModel.id,
               });
 
               this.experimentManager.createAgentParticipant(this.cohort.id, {
@@ -130,38 +130,25 @@ export class AgentParticipantDialog extends MobxLitElement {
       <div class="selections">
         <div>Model to use for this specific agent participant:</div>
         <div class="model-selector">
-          ${this.renderModelButton(
-            'gemini-2.5-flash',
-            'Gemini 2.5 Flash',
-            ApiKeyType.GEMINI_API_KEY,
-          )}
-          ${this.renderModelButton(
-            'gemini-2.5-pro',
-            'Gemini 2.5 Pro',
-            ApiKeyType.GEMINI_API_KEY,
-          )}
+          ${GEMINI_MODELS.map((model) => this.renderModelButton(model))}
         </div>
       </div>
     `;
   }
 
-  private renderModelButton(
-    modelId: string,
-    modelName: string,
-    apiType: ApiKeyType,
-  ) {
-    const updateModel = () => {
-      this.model = modelId;
+  private renderModelButton(model: ModelOption) {
+    const selectModel = () => {
+      this.selectedModel = model;
     };
 
-    const isActive = modelId == this.model;
+    const isActive = this.selectedModel?.id === model.id;
     return html`
       <pr-button
         color="${isActive ? 'primary' : 'neutral'}"
         variant=${isActive ? 'tonal' : 'default'}
-        @click=${updateModel}
+        @click=${selectModel}
       >
-        ${modelName}
+        ${model.displayName}
       </pr-button>
     `;
   }
diff --git a/functions/src/api/claude.api.test.ts b/functions/src/api/claude.api.test.ts
@@ -7,10 +7,11 @@ import {
   ModelGenerationConfig,
   ModelResponse,
   ModelResponseStatus,
+  CLAUDE_DEFAULT_MODEL,
 } from '@deliberation-lab/utils';
 import {getClaudeAPIChatCompletionResponse} from './claude.api';
 
-const MODEL_NAME = 'claude-haiku-4-5';
+const MODEL_NAME = CLAUDE_DEFAULT_MODEL;
 const CLAUDE_API_HOST = 'https://api.anthropic.com';
 const CLAUDE_API_PATH = '/v1/messages';
 
diff --git a/functions/src/api/gemini.api.test.ts b/functions/src/api/gemini.api.test.ts
@@ -7,10 +7,11 @@ import {
   ModelResponseStatus,
   StructuredOutputType,
   StructuredOutputDataType,
+  GEMINI_DEFAULT_MODEL,
 } from '@deliberation-lab/utils';
 import {getGeminiAPIResponse} from './gemini.api';
 
-const MODEL_NAME = 'gemini-2.5-flash';
+const MODEL_NAME = GEMINI_DEFAULT_MODEL;
 
 describe('Gemini API', () => {
   beforeEach(() => {
diff --git a/functions/src/api/gemini.api.ts b/functions/src/api/gemini.api.ts
@@ -16,9 +16,9 @@ import {
   ModelResponseStatus,
   ModelResponse,
   addParsedModelResponse,
+  GEMINI_DEFAULT_MODEL,
 } from '@deliberation-lab/utils';
 
-const GEMINI_DEFAULT_MODEL = 'gemini-2.5-flash';
 const MAX_TOKENS_FINISH_REASON = 'MAX_TOKENS';
 const AUTHENTICATION_FAILURE_ERROR_CODE = 403;
 const QUOTA_ERROR_CODE = 429;
diff --git a/functions/src/api/ollama.api.test.ts b/functions/src/api/ollama.api.test.ts
@@ -1,10 +1,13 @@
 // eslint-disable-next-line @typescript-eslint/no-require-imports
 import nock = require('nock');
 
-import {ModelGenerationConfig} from '@deliberation-lab/utils';
+import {
+  ModelGenerationConfig,
+  OLLAMA_DEFAULT_MODEL,
+} from '@deliberation-lab/utils';
 import {ollamaChat} from './ollama.api';
 
-const MODEL_NAME = 'llama3.2';
+const MODEL_NAME = OLLAMA_DEFAULT_MODEL;
 const LLM_SERVER_ENDPOINT = 'http://localhost:11434/api/chat';
 const LLM_SERVER_HOST = 'http://localhost:11434';
 const LLM_SERVER_PATH = '/api/chat';
diff --git a/functions/src/log.utils.test.ts b/functions/src/log.utils.test.ts
@@ -18,11 +18,12 @@ import {
   StructuredOutputConfig,
   StructuredOutputType,
   createModelLogEntry,
+  GEMINI_DEFAULT_MODEL,
 } from '@deliberation-lab/utils';
 import {writeModelLogEntry} from './log.utils';
 import {getGeminiAPIResponse} from './api/gemini.api';
 
-const MODEL_NAME = 'gemini-2.5-flash';
+const MODEL_NAME = GEMINI_DEFAULT_MODEL;
 
 const RULES = `
 rules_version = '2';
diff --git a/utils/src/agent.ts b/utils/src/agent.ts
@@ -12,6 +12,7 @@ import {
   MediatorPromptConfig,
   ParticipantPromptConfig,
 } from './structured_prompt';
+import {GEMINI_DEFAULT_MODEL} from './model_config';
 
 /** Agent types and functions. */
 
@@ -172,7 +173,7 @@ export interface AgentParticipantTemplate {
 // ************************************************************************* //
 export const DEFAULT_AGENT_API_TYPE = ApiKeyType.GEMINI_API_KEY;
 
-export const DEFAULT_AGENT_API_MODEL = 'gemini-2.5-flash';
+export const DEFAULT_AGENT_API_MODEL = GEMINI_DEFAULT_MODEL;
 
 export const DEFAULT_AGENT_MODEL_SETTINGS: AgentModelSettings = {
   apiType: DEFAULT_AGENT_API_TYPE,
diff --git a/utils/src/index.ts b/utils/src/index.ts
@@ -54,6 +54,7 @@ export * from './profile_sets';
 // TODO: Organize these files into 'agent' subdirectory
 export * from './agent';
 export * from './agent.validation';
+export * from './model_config';
 export * from './model_response';
 export * from './structured_output';
 export * from './structured_prompt';
diff --git a/utils/src/model_config.ts b/utils/src/model_config.ts
@@ -0,0 +1,97 @@
+/**
+ * Centralized model configuration for all AI providers.
+ * Update these defaults when new models are released.
+ */
+
+import {ApiKeyType} from './agent';
+
+// Default model names for each provider
+export const GEMINI_DEFAULT_MODEL = 'gemini-2.5-flash';
+export const OPENAI_DEFAULT_MODEL = 'gpt-5-mini-2025-08-07';
+export const CLAUDE_DEFAULT_MODEL = 'claude-haiku-4-5-20251001';
+export const OLLAMA_DEFAULT_MODEL = 'ministral-3';
+
+/**
+ * Model option for UI dropdowns and selection.
+ */
+export interface ModelOption {
+  id: string;
+  displayName: string;
+  apiType: ApiKeyType;
+}
+
+/**
+ * Suggested Gemini models.
+ */
+export const GEMINI_MODELS: ModelOption[] = [
+  {
+    id: 'gemini-2.5-flash',
+    displayName: 'Gemini 2.5 Flash',
+    apiType: ApiKeyType.GEMINI_API_KEY,
+  },
+  {
+    id: 'gemini-2.5-pro',
+    displayName: 'Gemini 2.5 Pro',
+    apiType: ApiKeyType.GEMINI_API_KEY,
+  },
+];
+
+/**
+ * Suggested OpenAI models.
+ */
+export const OPENAI_MODELS: ModelOption[] = [
+  {
+    id: 'gpt-5-mini',
+    displayName: 'GPT-5 mini',
+    apiType: ApiKeyType.OPENAI_API_KEY,
+  },
+];
+
+/**
+ * Suggested Claude models.
+ */
+export const CLAUDE_MODELS: ModelOption[] = [
+  {
+    id: 'claude-haiku-4-5-20251001',
+    displayName: 'Claude Haiku 4.5',
+    apiType: ApiKeyType.CLAUDE_API_KEY,
+  },
+];
+
+/**
+ * Suggested models grouped by provider.
+ */
+export const MODEL_OPTIONS: Record<ApiKeyType, ModelOption[]> = {
+  [ApiKeyType.GEMINI_API_KEY]: GEMINI_MODELS,
+  [ApiKeyType.OPENAI_API_KEY]: OPENAI_MODELS,
+  [ApiKeyType.CLAUDE_API_KEY]: CLAUDE_MODELS,
+  [ApiKeyType.OLLAMA_CUSTOM_URL]: [], // Ollama models are user-configured
+};
+
+/**
+ * Get the default model name for a given API type.
+ */
+export function getDefaultModelForApiType(apiType: ApiKeyType): string {
+  switch (apiType) {
+    case ApiKeyType.GEMINI_API_KEY:
+      return GEMINI_DEFAULT_MODEL;
+    case ApiKeyType.OPENAI_API_KEY:
+      return OPENAI_DEFAULT_MODEL;
+    case ApiKeyType.CLAUDE_API_KEY:
+      return CLAUDE_DEFAULT_MODEL;
+    case ApiKeyType.OLLAMA_CUSTOM_URL:
+      return OLLAMA_DEFAULT_MODEL;
+    default:
+      return GEMINI_DEFAULT_MODEL;
+  }
+}
+
+/**
+ * All default models by provider, for reference.
+ */
+export const DEFAULT_MODELS = {
+  [ApiKeyType.GEMINI_API_KEY]: GEMINI_DEFAULT_MODEL,
+  [ApiKeyType.OPENAI_API_KEY]: OPENAI_DEFAULT_MODEL,
+  [ApiKeyType.CLAUDE_API_KEY]: CLAUDE_DEFAULT_MODEL,
+  [ApiKeyType.OLLAMA_CUSTOM_URL]: OLLAMA_DEFAULT_MODEL,
+} as const;
