Skip to content

Commit f0df073

Browse files
authored
Merge pull request #930 from aldenhallak/zindex
Standardize and fix z-indexes to 10,20,30,40,50
2 parents 9b20d6c + e3e87d4 commit f0df073

File tree

8 files changed

+8
-9
lines changed

8 files changed

+8
-9
lines changed

frontend/src/components/experiment_builder/experiment_builder.scss

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
padding: 0 common.$sidenav-padding;
2727
position: sticky;
2828
top: 0;
29-
z-index: 1;
29+
z-index: 10;
3030
}
3131

3232
.sidenav-items {
@@ -113,7 +113,7 @@
113113
padding: 0 common.$main-content-padding;
114114
position: sticky;
115115
top: 0;
116-
z-index: 1;
116+
z-index: 10;
117117

118118
.left,
119119
.right {

frontend/src/components/experiment_builder/experiment_builder_nav.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@
4141
padding: 0 common.$sidenav-padding;
4242
position: sticky;
4343
top: 0;
44-
z-index: 1;
44+
z-index: 10;
4545
}
4646

4747
.primary {

frontend/src/components/experiment_dashboard/cohort_summary.scss

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020
justify-content: space-between;
2121
padding: common.$spacing-medium common.$spacing-large;
2222
position: relative;
23-
z-index: 2;
2423

2524
&:focus,
2625
&:hover {

frontend/src/components/experimenter/experimenter_panel.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -304,7 +304,7 @@ pr-button pr-icon {
304304
padding: common.$spacing-medium;
305305
position: fixed;
306306
right: common.$spacing-large;
307-
z-index: 1000;
307+
z-index: 40;
308308

309309
.content {
310310
@include common.flex-row-align-center;

frontend/src/components/header/header.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
position: sticky;
88
top: 0;
99
width: 100%;
10-
z-index: 1;
10+
z-index: 10;
1111
}
1212

1313
.banner {

frontend/src/pair-components/menu.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
height: 0;
2020
overflow: hidden;
2121
width: 0;
22-
z-index: 1;
22+
z-index: 30;
2323

2424
&.show-menu {
2525
overflow: visible;

frontend/src/pair-components/tooltip.css

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
/* Tooltip */
22
:host {
3-
--z-index: var(--pr-tooltip-z-index, 1);
3+
--z-index: var(--pr-tooltip-z-index, 30);
44
--anchor-display-mode: var(--pr-tooltip-display, inline-block);
55
}
66

frontend/src/sass/_common.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -199,7 +199,7 @@
199199
justify-content: center;
200200
padding: calc($main-content-padding * 2);
201201
position: absolute;
202-
z-index: 2; // above app header
202+
z-index: 20; // above app header
203203
}
204204

205205
@mixin dialog {

0 commit comments

Comments
 (0)