Remove SphericalDiffuse Green's function

This work lives on in V1 and in the rk4 branch

Author: robertodr

.gitignore

@@ -35,6 +35,7 @@
 .venv
 .direnv
 Pipfile.lock
+.mypy_cache
 
 # Autocmake stuff
 cmake/lib/*.pyc

src/green/CMakeLists.txt

@@ -2,7 +2,6 @@ target_sources(pcm-object
   PRIVATE
     ${CMAKE_CURRENT_SOURCE_DIR}/AnisotropicLiquid.cpp
     ${CMAKE_CURRENT_SOURCE_DIR}/IonicLiquid.cpp
-    ${CMAKE_CURRENT_SOURCE_DIR}/SphericalDiffuse.cpp # Deactivate temporarily when Boost goes away
     ${CMAKE_CURRENT_SOURCE_DIR}/UniformDielectric.cpp
     ${CMAKE_CURRENT_SOURCE_DIR}/Vacuum.cpp
     ${CMAKE_CURRENT_SOURCE_DIR}/SphericalSharp.cpp
@@ -17,9 +16,7 @@ list(APPEND headers_list
   GreenUtils.hpp
   GreensFunction.hpp
   IGreensFunction.hpp
-  InterfacesImpl.hpp
   IonicLiquid.hpp
-  SphericalDiffuse.hpp
   SphericalSharp.hpp
   UniformDielectric.hpp
   Vacuum.hpp

src/green/Green.hpp

@@ -28,22 +28,20 @@
 #include "GreenData.hpp"
 #include "IGreensFunction.hpp"
 #include "IonicLiquid.hpp"
-#include "SphericalDiffuse.hpp"
 #include "SphericalSharp.hpp"
 #include "UniformDielectric.hpp"
 #include "Vacuum.hpp"
-#include "dielectric_profile/OneLayerErf.hpp"
-#include "dielectric_profile/OneLayerTanh.hpp"
+
 #include "utils/Factory.hpp"
 
 /*!
- * \file Solver.hpp
- * \brief Top-level include file for solvers
+ * \file Green.hpp
+ * \brief Top-level include file for Green's functions
  * \author Roberto Di Remigio
  * \date 2016
  *
  * Includes all solver-related headers and defines the bootstrap function
- * for the Factory<ISolver, SolverData>
+ * for the Factory<IGreensFunction, GreenData>
  */
 
 namespace pcm {
@@ -83,13 +81,6 @@ inline Factory<detail::CreateGreensFunction> bootstrapFactory() {
   factory_.subscribe("ANISOTROPICLIQUID_HESSIAN",
                      createAnisotropicLiquid<AD_hessian>);
 
-  factory_.subscribe("SPHERICALDIFFUSE_NUMERICAL_TANH",
-                     createSphericalDiffuse<dielectric_profile::OneLayerTanh>);
-  factory_.subscribe("SPHERICALDIFFUSE_NUMERICAL_ERF",
-                     createSphericalDiffuse<dielectric_profile::OneLayerErf>);
-  factory_.subscribe("SPHERICALDIFFUSE_NUMERICAL_LOG",
-                     createSphericalDiffuse<dielectric_profile::OneLayerLog>);
-
   factory_.subscribe("SPHERICALSHARP_NUMERICAL", createSphericalSharp<Stencil>);
   factory_.subscribe("SPHERICALSHARP_DERIVATIVE",
                      createSphericalSharp<AD_directional>);

src/green/GreenData.hpp

@@ -51,15 +51,12 @@ struct GreenData {
   double epsilon1;
   /*! Permittivity outside the interface */
   double epsilon2;
-  /*! Center of the diffuse/sharp layer aka the radius of diffuse/sharp sphere */
+  /*! Center of the sharp layer aka the radius of sharp sphere */
   double center;
-  /*! Width of the diffuse layer */
-  double width;
-  /*! Origin of the dielectric diffuse/sharp layer aka the center of the
-   * diffuse/sharp sphere.
+  /*! Origin of the dielectric sharp layer aka the center of the sharp sphere.
    */
   Eigen::Vector3d origin;
-  /*! Maximum angular momentum in the spherical diffuse/sharp Green's function
+  /*! Maximum angular momentum in the spherical sharp Green's function
    * summation.
    */
   int maxL;
@@ -72,7 +69,6 @@ struct GreenData {
             double e1 = 1.0,
             double e2 = 1.0,
             double c = 100.0,
-            double w = 5.0,
             const Eigen::Vector3d & o = Eigen::Vector3d::Zero(),
             int l = 50)
       : greensFunctionType(type),
@@ -83,7 +79,6 @@ struct GreenData {
         epsilon1(e1),
         epsilon2(e2),
         center(c),
-        width(w),
         origin(o),
         maxL(l) {}
   EIGEN_MAKE_ALIGNED_OPERATOR_NEW