Skip to content

Commit 7c9bf02

Browse files
committed
Remove dead code for handling quantifier after OP_FAIL
Fixes #541
1 parent 82d1d4b commit 7c9bf02

File tree

1 file changed

+2
-11
lines changed

1 file changed

+2
-11
lines changed

src/pcre2_compile.c

Lines changed: 2 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -7110,15 +7110,6 @@ for (;; pptr++)
71107110
}
71117111
break;
71127112

7113-
/* The ways in which OP_FAIL can be generated, that is by (*FAIL) or
7114-
(?!), disallow a quantifier at parse time. We ought to be able to ignore this. */
7115-
7116-
case OP_FAIL:
7117-
/* TODO: [EC] https://github.com/PCRE2Project/pcre2/issues/541
7118-
Should this be removed, now that '[]' has been changed so it doesn't produce OP_FAIL? */
7119-
PCRE2_UNREACHABLE();
7120-
goto END_REPEAT;
7121-
71227113
/* Prior to 10.30, repeated recursions were wrapped in OP_ONCE brackets
71237114
because pcre2_match() could not handle backtracking into recursively
71247115
called groups. Now that this backtracking is available, we no longer need
@@ -7527,9 +7518,9 @@ for (;; pptr++)
75277518
here because it just makes it horribly messy. */
75287519

75297520
default:
7530-
if (op_previous >= OP_EODN) /* Not a character type - internal error */
7521+
if (op_previous >= OP_EODN || op_previous <= OP_WORD_BOUNDARY)
75317522
{
7532-
*errorcodeptr = ERR10;
7523+
*errorcodeptr = ERR10; /* Not a character type - internal error */
75337524
return 0;
75347525
}
75357526
else

0 commit comments

Comments
 (0)