warning: variable `pageSize` should have a snake case name --> src/api/v1.rs:300:5 | 300 | pageSize: Option<i32>, | ^^^^^^^^ help: convert the identifier to snake case: `page_size`

warning: variable `pageSize` should have a snake case name --> src/api/v1.rs:261:5 | 261 | pageSize: Option<i32>, | ^^^^^^^^ help: convert the identifier to snake case: `page_size` | = note: `#[warn(non_snake_case)]` on by default

warning: equality checks against true are unnecessary --> src/main.rs:67:8 | 67 | if verbose_logging == true { | ^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `verbose_logging` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison = note: `#[warn(clippy::bool_comparison)]` on by default

warning: this `map_or` can be simplified --> src/main.rs:63:9 | 63 | dotenvy::var("VERBOSE_LOGGING").map_or(false, |val| val.to_lowercase().eq("true")); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use is_ok_and instead: `dotenvy::var("VERBOSE_LOGGING").is_ok_and(|val| val.to_lowercase().eq("true"))` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or = note: `#[warn(clippy::unnecessary_map_or)]` on by default

warning: this boolean expression can be simplified --> src/util.rs:22:12 | 22 | if !part.parse::<i64>().is_ok() { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `part.parse::<i64>().is_err()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool = note: `#[warn(clippy::nonminimal_bool)]` on by default

warning: unnecessary closure used to substitute value for `Result::Err` --> src/storage/sync.rs:109:13 | 109 | / rocket::futures::TryStreamExt::try_next(&mut archive_release_stream) 110 | | .await 111 | | .unwrap_or_else(|err| None) | |___________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations help: use `unwrap_or` instead | 111 | .unwrap_or(None) | ~~~~~~~~~~~~~~~

warning: unnecessary closure used to substitute value for `Result::Err` --> src/storage/sync.rs:70:35 | 70 | while let Some(release) = rocket::futures::TryStreamExt::try_next(&mut main_release_stream) | ___________________________________^ 71 | | .await 72 | | .unwrap_or_else(|err| None) | |_______________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations = note: `#[warn(clippy::unnecessary_lazy_evaluations)]` on by default help: use `unwrap_or` instead | 72 | .unwrap_or(None) | ~~~~~~~~~~~~~~~

warning: unneeded `return` statement --> src/storage/sync.rs:129:5 | 129 | return false; | ^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return help: remove `return` | 129 - return false; 129 + false |

warning: manual implementation of `Option::map` --> src/storage/models.rs:104:34 | 104 | published_timestamp: match &github_release.published_at { | __________________________________^ 105 | | Some(published_at) => { 106 | | Some(published_at.to_rfc3339_opts(SecondsFormat::Millis, true)) ... | 109 | | }, | |_____________^ help: try: `github_release.published_at.as_ref().map(|published_at| published_at.to_rfc3339_opts(SecondsFormat::Millis, true))` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map = note: `#[warn(clippy::manual_map)]` on by default

warning: use of `or_insert_with` to construct default value --> src/storage/models.rs:71:18 | 71 | .or_insert_with(Vec::new) | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default = note: `#[warn(clippy::unwrap_or_default)]` on by default

warning: accessing first element with `filename_matches.get(0)` --> src/storage/models.rs:56:37 | 56 | if let Some(captures) = filename_matches.get(0) { | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `filename_matches.first()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first = note: `#[warn(clippy::get_first)]` on by default

warning: this `let...else` may be rewritten with the `?` operator --> src/guards.rs:76:5 | 76 | / let Some(digest) = header.strip_prefix("sha256=") else { 77 | | return None; 78 | | }; | |______^ help: replace it with: `let digest = header.strip_prefix("sha256=")?;` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark = note: `#[warn(clippy::question_mark)]` on by default

warning: this expression creates a reference which is immediately dereferenced by the compiler --> src/guards.rs:70:16 | 70 | mac.update(&content); | ^^^^^^^^ help: change this to: `content` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: redundant closure --> src/guards.rs:50:23 | 50 | .and_then(|header| parse_signature(header)) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `parse_signature` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure

warning: the following explicit lifetimes could be elided: 'r --> src/guards.rs:38:29 | 38 | async fn from_data_impl<'r>( | ^^ 39 | request: &Request<'_>, 40 | data: Data<'r>, | ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes = note: `#[warn(clippy::needless_lifetimes)]` on by default

warning: unneeded `return` statement --> src/external/github.rs:24:5 | 24 | return Ok(release.items.first().unwrap().tag_name.clone()); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return help: remove `return` | 24 - return Ok(release.items.first().unwrap().tag_name.clone()); 24 + Ok(release.items.first().unwrap().tag_name.clone()) |

warning: unneeded `return` statement --> src/external/github.rs:11:5 | 11 | return Ok(release.items.first().unwrap().tag_name.clone()); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return = note: `#[warn(clippy::needless_return)]` on by default help: remove `return` | 11 - return Ok(release.items.first().unwrap().tag_name.clone()); 11 + Ok(release.items.first().unwrap().tag_name.clone()) |

warning: redundant closure --> src/api/v2.rs:145:22 | 145 | .map(|db_release| Release::from_database(db_release)) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `Release::from_database` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure

warning: manual implementation of an assign operation --> src/api/v2.rs:104:25 | 104 | combined_notes = combined_notes + content.as_str(); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `combined_notes += content.as_str()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern = note: `#[warn(clippy::assign_op_pattern)]` on by default

warning: redundant closure --> src/api/v2.rs:71:14 | 71 | .map(|db_release| Release::from_database(db_release)) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `Release::from_database` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure

warning: redundant closure --> src/api/v2.rs:66:14 | 66 | .map(|db_release| Release::from_database(db_release)) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `Release::from_database` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure

warning: redundant closure --> src/api/v1.rs:317:22 | 317 | .map(|db_release| ReleaseV1::from_v2(db_release)) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `ReleaseV1::from_v2` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure

warning: redundant closure --> src/api/v1.rs:279:22 | 279 | .map(|db_release| ReleaseV1::from_v2(db_release)) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `ReleaseV1::from_v2` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure

warning: redundant closure --> src/api/v1.rs:225:14 | 225 | .map(|db_release| ReleaseV1::from_v2(db_release)) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `ReleaseV1::from_v2` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure

warning: redundant closure --> src/api/v1.rs:219:14 | 219 | .map(|db_release| ReleaseV1::from_v2(db_release)) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `ReleaseV1::from_v2` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure = note: `#[warn(clippy::redundant_closure)]` on by default

warning: this expression creates a reference which is immediately dereferenced by the compiler --> src/api/v1.rs:153:31 | 153 | .captures(&v) | ^^ help: change this to: `v` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `#[warn(clippy::needless_borrow)]` on by default

warning: this expression can be written more simply using `.retain()` --> src/api/v1.rs:112:33 | 112 | / ... cleaned_tags = cleaned_tags 113 | | ... .into_iter() 114 | | ... .filter(|tag| { 115 | | ... !tag.to_lowercase().contains("appimage") 116 | | ... && !tag.to_lowercase().contains("flatpak") 117 | | ... }) 118 | | ... .collect(); | |____________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_retain help: consider calling `.retain()` instead | 112 ~ cleaned_tags.retain(|tag| { 113 + !tag.to_lowercase().contains("appimage") 114 + && !tag.to_lowercase().contains("flatpak") 115 ~ }); |

warning: this expression can be written more simply using `.retain()` --> src/api/v1.rs:98:33 | 98 | / ... cleaned_tags = cleaned_tags 99 | | ... .into_iter() 100 | | ... .filter(|tag| { 101 | | ... !tag.to_lowercase().contains("32bit") 102 | | ... && !tag.to_lowercase().contains("64") 103 | | ... }) 104 | | ... .collect(); | |____________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_retain help: consider calling `.retain()` instead | 98 ~ cleaned_tags.retain(|tag| { 99 + !tag.to_lowercase().contains("32bit") 100 + && !tag.to_lowercase().contains("64") 101 ~ }); |

warning: this expression can be written more simply using `.retain()` --> src/api/v1.rs:87:33 | 87 | / ... cleaned_tags = cleaned_tags 88 | | ... .into_iter() 89 | | ... .filter(|tag| !tag.to_lowercase().contains("qt")) 90 | | ... .collect(); | |____________________________________^ help: consider calling `.retain()` instead: `cleaned_tags.retain(|tag| !tag.to_lowercase().contains("qt"))` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_retain = note: `#[warn(clippy::manual_retain)]` on by default

warning: function `insert_new_api_key` is never used --> src/storage/sqlite.rs:177:14 | 177 | pub async fn insert_new_api_key( | ^^^^^^^^^^^^^^^^^^

warning: function `list_releases` is never used --> src/storage/sqlite.rs:121:14 | 121 | pub async fn list_releases( | ^^^^^^^^^^^^^

warning: function `get_release_notes_for_range` is never used --> src/storage/sqlite.rs:105:14 | 105 | pub async fn get_release_notes_for_range( | ^^^^^^^^^^^^^^^^^^^^^^^^^^^

warning: function `get_latest_stable_release` is never used --> src/storage/sqlite.rs:69:14 | 69 | pub async fn get_latest_stable_release(db: &SqlitePool) -> DBResult<ReleaseRow> { | ^^^^^^^^^^^^^^^^^^^^^^^^^

warning: function `get_latest_nightly_release` is never used --> src/storage/sqlite.rs:57:14 | 57 | pub async fn get_latest_nightly_release(db: &SqlitePool) -> DBResult<ReleaseRow> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^

warning: function `archive_release` is never used --> src/storage/sqlite.rs:42:14 | 42 | pub async fn archive_release(db: &SqlitePool, release: &ReleaseRow) -> DBResult<()> { | ^^^^^^^^^^^^^^^

warning: function `update_existing_release` is never used --> src/storage/sqlite.rs:30:14 | 30 | pub async fn update_existing_release(db: &SqlitePool, release: &ReleaseRow) -> DBResult<()> { | ^^^^^^^^^^^^^^^^^^^^^^^

warning: field `0` is never read --> src/guards.rs:17:31 | 17 | pub struct GithubWebhookEvent(pub WebhookEvent); | ------------------ ^^^^^^^^^^^^^^^^ | | | field in this struct | = help: consider removing this field

warning: function `admin_add_new_api_key` is never used --> src/api/v2.rs:237:14 | 237 | pub async fn admin_add_new_api_key( | ^^^^^^^^^^^^^^^^^^^^^

warning: fields `api_key` and `metadata` are never read --> src/api/v2.rs:232:5 | 231 | pub struct AddAPIKeyRequest { | ---------------- fields in this struct 232 | api_key: String, | ^^^^^^^ 233 | metadata: String, | ^^^^^^^^

warning: function `handle_github_webhook_release_event` is never used --> src/api/v2.rs:164:14 | 164 | pub async fn handle_github_webhook_release_event( | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

warning: function `get_release_list` is never used --> src/api/v2.rs:120:14 | 120 | pub async fn get_release_list( | ^^^^^^^^^^^^^^^^

warning: function `get_release_changelog` is never used --> src/api/v2.rs:84:14 | 84 | pub async fn get_release_changelog( | ^^^^^^^^^^^^^^^^^^^^^

warning: function `get_recent_releases` is never used --> src/api/v2.rs:52:14 | 52 | pub async fn get_recent_releases( | ^^^^^^^^^^^^^^^^^^^

warning: function `get_latest_releases` is never used --> src/api/v2.rs:24:14 | 24 | pub async fn get_latest_releases( | ^^^^^^^^^^^^^^^^^^^

warning: associated function `from_database` is never used --> src/api/models.rs:39:12 | 38 | impl Release { | ------------ associated function in this implementation 39 | pub fn from_database(db_row: &ReleaseRow) -> Self { | ^^^^^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default

warning: unused import: `futures::FutureExt` --> src/storage/sync.rs:2:14 | 2 | use rocket::{futures::FutureExt, tokio::pin}; | ^^^^^^^^^^^^^^^^^^ | = note: `#[warn(unused_imports)]` on by default

warning: unused variable: `err` --> src/storage/sync.rs:111:34 | 111 | .unwrap_or_else(|err| None) | ^^^ help: if this is intentional, prefix it with an underscore: `_err`

warning: unused variable: `err` --> src/storage/sync.rs:72:30 | 72 | .unwrap_or_else(|err| None) | ^^^ help: if this is intentional, prefix it with an underscore: `_err`

warning: unused variable: `admin_acess` --> src/api/v2.rs:238:5 | 238 | admin_acess: AdminAccess, | ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_admin_acess` | = note: `#[warn(unused_variables)]` on by default

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/