Merge pull request #7 from Simverge/github-6_address-coverity-faults

Address initial Coverity Scan faults (issue #6)

Author: jimmysoda

.gitignore

@@ -2,12 +2,14 @@
 tests/pdal-stats.las
 tests/data/*.json
 tests/pdal/test_pdalc_*.c
+!tests/pdal/test_pdalc_utils.c
 
 # Ignore doxygen docs
 /doc/doxygen
 /doc/Doxyfile
 
 # Select VS Code configurations
+.vscode/ipch/**
 .vscode/settings.json
 .vscode/c_cpp_properties.json
 

.travis.yml

@@ -22,6 +22,7 @@ before_install:
   - docker pull simverge/pdalc-build-deps:$DISTRO
 
 script:
+  - if [ "$SCAN" = "sonarcloud" ]; then git fetch --unshallow --tags --quiet; fi
   - chmod u+x $TRAVIS_BUILD_DIR/tests/travis/script.sh
   - docker run -e SCAN -e COVERITY_EMAIL -e COVERITY_TOKEN -e TRAVIS_COMMIT -e TRAVIS_BRANCH -e BUILD_TYPE -e DISTRO -v $TRAVIS_BUILD_DIR:/pdalc -t simverge/pdalc-build-deps:$DISTRO /pdalc/tests/travis/script.sh
   - if [ "$SCAN" = "sonarcloud" ]; then sonar-scanner; fi

README.md

@@ -1,10 +1,13 @@
 pdal-c: PDAL C API
 ==================
 
+[//]: # (@cond Hide build status from Doxygen)
+
 [![Build Status](https://travis-ci.com/Simverge/pdal-c.svg?branch=master)](https://travis-ci.com/Simverge/pdal-c)
 [![Coverity Scan](https://scan.coverity.com/projects/17631/badge.svg)](https://scan.coverity.com/projects/simverge-pdal-c)
 [![SonarCloud](https://sonarcloud.io/api/project_badges/measure?project=Simverge_pdal-c&metric=alert_status)](https://sonarcloud.io/dashboard?id=Simverge_pdal-c)
 
+[//]: # (@endcond)
 
 *pdal-c* is a C API for the Point Data Abstraction Library ([PDAL](http:/github.com/PDAL/PDAL))
 and is compatible with PDAL 1.7 and later.

source/pdal/pdalc_config.h

@@ -46,7 +46,7 @@ namespace capi
 extern "C"
 {
 #else
-#include <stdbool.h>
+#include <stddef.h> // for size_t
 #endif
 /**
  * Retrieves the path to the GDAL data directory.

source/pdal/pdalc_dimtype.h

@@ -45,6 +45,8 @@ namespace capi
 {
 extern "C"
 {
+#else
+#include <stddef.h> // for size_t
 #endif
 /**
  * Returns the number of elements in a dimension type list.

source/pdal/pdalc_pipeline.h

@@ -47,6 +47,7 @@ extern "C"
 {
 #else
 #include <stdbool.h> // for bool
+#include <stddef.h> // for size_t
 #include <stdint.h> // for int64_t
 #endif /* __cplusplus */
 

source/pdal/pdalc_pointlayout.h

@@ -46,6 +46,8 @@ namespace capi
 
 extern "C"
 {
+#else
+#include <stddef.h> // for size_t
 #endif
 /**
  * Returns the list of dimension types used by the provided `layout`.

source/pdal/pdalc_pointview.h

@@ -47,6 +47,7 @@ extern "C"
 {
 #else
 #include <stdbool.h> // for bool
+#include <stddef.h> // for size_t
 #include <stdint.h> // for uint64_t
 #endif
 /**

tests/pdal/CMakeLists.txt

@@ -7,9 +7,13 @@ set(CONFIGS )
 set(SOURCES
 	main.c
 	test_pdalc_config.c
+	test_pdalc_utils.c
+)
+
+set(HEADERS 
+	test_pdalc_utils.h
 )
 
-set(HEADERS )
 set(DEPENDENCIES 
 	${PDAL_LIBRARIES}
 	pdalc