Add unit test for layout dim type list retrieval

Author: jimmysoda

source/pdal/capi/PointLayout.cpp

@@ -12,14 +12,38 @@ namespace pdal
 {
 	namespace capi
 	{
+		size_t PDALGetDimTypeListSize(PDALDimTypeListPtr types)
+		{
+			pdal::capi::DimTypeList *wrapper = reinterpret_cast<pdal::capi::DimTypeList *>(types);
+
+			size_t size = 0;
+
+			if (wrapper && wrapper->get())
+			{
+				try
+				{
+					pdal::DimTypeList *list = wrapper->get();
+					size = list->size();
+				}
+				catch (const std::exception &e)
+				{
+					printf("%s\n", e.what());
+				}
+			}
+
+			return size;
+		}
+
 		PDALDimTypeListPtr PDALGetPointLayoutDimTypes(PDALPointLayoutPtr layout)
 		{
 			PDALDimTypeListPtr types = NULL;
 			pdal::PointLayoutPtr nativeLayout = reinterpret_cast<pdal::PointLayoutPtr>(layout);
 
 			if (nativeLayout)
 			{
-				types = new pdal::capi::DimTypeList(new pdal::DimTypeList(nativeLayout->dimTypes()));
+				pdal::DimTypeList *list = new pdal::DimTypeList(nativeLayout->dimTypes());
+
+				types = new pdal::capi::DimTypeList(list);
 			}
 
 			return types;

source/pdal/capi/PointLayout.h

@@ -16,6 +16,8 @@ namespace pdal
 		extern "C"
 		{
 #endif
+			PDAL_C_API size_t PDALGetDimTypeListSize(PDALDimTypeListPtr types);
+
 			PDAL_C_API PDALDimTypeListPtr PDALGetPointLayoutDimTypes(PDALPointLayoutPtr layout);
 
 			PDAL_C_API void PDALDisposeDimTypeList(PDALDimTypeListPtr types);

tests/pdal/capi/PointLayoutTest.c.in

@@ -65,6 +65,25 @@ static void teardownPointLayoutTest(void *arg)
 	PDALDisposePipeline(gPipeline);
 }
 
+TEST testPDALGetPointLayoutDimTypes(void)
+{
+	ASSERT(gLayout);
+	PDALDimTypeListPtr types = PDALGetPointLayoutDimTypes(NULL);
+	ASSERT_EQ(NULL, types);
+
+	types = PDALGetPointLayoutDimTypes(gLayout);
+	ASSERT(types);
+
+	size_t size = PDALGetDimTypeListSize(types);
+	ASSERT(size > 0);
+
+	PDALDisposeDimTypeList(types);
+	size = PDALGetDimTypeListSize(types);
+	ASSERT_EQ(0, size);
+
+	PASS();
+}
+
 TEST testPDALGetDimSize(void)
 {
 	ASSERT(gLayout);
@@ -131,6 +150,7 @@ GREATEST_SUITE(PointLayoutTest)
 	SET_SETUP(setupPointLayoutTest, NULL);
 	SET_TEARDOWN(teardownPointLayoutTest, NULL);
 
+	RUN_TEST(testPDALGetPointLayoutDimTypes);
 	RUN_TEST(testPDALGetDimSize);
 	RUN_TEST(testPDALGetDimPackedOffset);
 	RUN_TEST(testPDALGetPointSize);