Add PDALGetPackedPoint function

Author: jimmysoda

source/pdal/capi/Forward.h

@@ -38,6 +38,8 @@ namespace pdal
 	}
 }
 
+#else
+#include <stdint.h> // for uint64_t
 #endif /* __cplusplus */
 
 /// A pointer to a dimension type list
@@ -46,6 +48,9 @@ typedef void* PDALDimTypeListPtr;
 /// A pointer to a pipeline
 typedef void* PDALPipelinePtr;
 
+/// An index to a point in a list
+typedef uint64_t PDALPointId;
+
 /// A pointer to a point layout
 typedef void* PDALPointLayoutPtr;
 

source/pdal/capi/PointView.cpp

@@ -116,6 +116,33 @@ namespace pdal
 
 				return layout;
 			}
+
+			size_t PDALGetPackedPoint(PDALPointViewPtr view, PDALDimTypeListPtr dims, PDALPointId idx, char *buf)
+			{
+				size_t size = 0;
+
+				if (view && dims && buf)
+				{
+					pdal::capi::PointView *capiView = reinterpret_cast<pdal::capi::PointView *>(view);
+
+					pdal::capi::DimTypeList *capiDims = reinterpret_cast<pdal::capi::DimTypeList *>(dims);
+
+
+					if (*capiView && *capiDims)
+					{
+						pdal::DimTypeList *list = capiDims->get();
+
+						(*capiView)->getPackedPoint(*list, idx, buf);
+
+						for (const auto &dim : *list)
+						{
+							size += pdal::Dimension::size(dim.m_type);
+						}
+					}
+				}
+
+				return size;
+			}
 		}
 	}
 }

source/pdal/capi/PointView.h

@@ -102,12 +102,16 @@ namespace pdal
 
 			/**
 			 * Fill a buffer with point data specified by the dimension list.
-			 * 
+			 *
+			 * @see pdal::PointView::getPackedPoint
+			 *
+			 * @param view The view that contains the point
 			 * @param dims List of dimensions/types to retrieve.
 			 * @param idx Index of point to get.
 			 * @param[out] buf Pointer to buffer to fill.
+			 * @return The size of the point stored in `buf`
 			 */
-			//! PDAL_C_API void getPackedPoint(const DimTypeList& dims, PointId idx, char *buf);
+			PDAL_C_API size_t PDALGetPackedPoint(PDALPointViewPtr view, PDALDimTypeListPtr dims, PDALPointId idx, char *buf);
 
 			//! PDAL_C_API void getPackedPoints(const DimTypeList& dims, PointId idx, char *buf);
 

tests/pdal/capi/PointViewTest.c.in

@@ -235,6 +235,54 @@ TEST testPDALGetPointViewLayout(void)
 	PASS();
 }
 
+TEST testPDALGetPackedPoint(void)
+{
+	//  PDALGetPackedPoint(PDALPointViewPtr view, PDALDimTypeListPtr dims, PDALPointId idx, char *buf)
+	PDALResetPointViewIterator(gPointViewIterator);
+	bool hasNext = PDALHasNextPointView(gPointViewIterator);
+	ASSERT(hasNext);
+
+	PDALPointViewPtr view = PDALGetNextPointView(gPointViewIterator);
+	ASSERT(view);
+
+	PDALPointLayoutPtr layout = PDALGetPointViewLayout(view);
+	ASSERT(layout);
+	PDALDimTypeListPtr dims = PDALGetPointLayoutDimTypes(layout);
+	ASSERT(dims);
+
+	uint64_t numPoints = PDALGetPointViewSize(view);
+	size_t expected = PDALGetPointSize(layout);
+
+	size_t capacity = 512;
+	char buffer[512];
+	ASSERT(expected > 0 && expected <= capacity);
+
+	for (uint64_t i = 0; i < numPoints; ++i)
+	{
+		size_t actual = PDALGetPackedPoint(NULL, NULL, i, NULL);
+		ASSERT_EQ(0, actual);
+		actual = PDALGetPackedPoint(NULL, NULL, i, buffer);
+		ASSERT_EQ(0, actual);
+		actual = PDALGetPackedPoint(NULL, dims, i, NULL);
+		ASSERT_EQ(0, actual);
+		actual = PDALGetPackedPoint(NULL, dims, i, buffer);
+		ASSERT_EQ(0, actual);
+		actual = PDALGetPackedPoint(view, NULL, i, NULL);
+		ASSERT_EQ(0, actual);
+		actual = PDALGetPackedPoint(view, NULL, i, buffer);
+		ASSERT_EQ(0, actual);
+		actual = PDALGetPackedPoint(view, dims, i, NULL);
+		ASSERT_EQ(0, actual);
+
+		actual = PDALGetPackedPoint(view, dims, i, buffer);
+		ASSERT_EQ(expected, actual);
+	}
+
+	PDALDisposePointView(view);
+
+	PASS();
+}
+
 GREATEST_SUITE(PointViewTest)
 {
 	SET_SETUP(setupPointViewTest, NULL);
@@ -247,6 +295,7 @@ GREATEST_SUITE(PointViewTest)
 	RUN_TEST(testPDALGetPointViewProj4);
 	RUN_TEST(testPDALGetPointViewWkt);
 	RUN_TEST(testPDALGetPointViewLayout);
+	RUN_TEST(testPDALGetPackedPoint);
 
 	SET_SETUP(NULL, NULL);
 	SET_TEARDOWN(NULL, NULL);