Acquire the GIL in StreamableExecutor destructor

gsakkis · gsakkis · commit ce36eefa209b · 2021-11-13T15:22:06.000+02:00
diff --git a/pdal/StreamableExecutor.cpp b/pdal/StreamableExecutor.cpp
@@ -206,8 +206,10 @@ StreamableExecutor::~StreamableExecutor()
     if (!m_executed)
     {
         m_table.disable();
+        auto gil = PyGILState_Ensure();
         while (PyArrayObject* arr = m_table.fetchArray())
             Py_XDECREF(arr);
+        PyGILState_Release(gil);
     }
     Py_BEGIN_ALLOW_THREADS
     m_thread->join();

Original file line number	Diff line number	Diff line change
`@@ -206,8 +206,10 @@ StreamableExecutor::~StreamableExecutor()`
`206`	`206`	`if (!m_executed)`
`207`	`207`	`{`
`208`	`208`	`m_table.disable();`
	`209`	`+ auto gil = PyGILState_Ensure();`
`209`	`210`	`while (PyArrayObject* arr = m_table.fetchArray())`
`210`	`211`	`Py_XDECREF(arr);`
	`212`	`+ PyGILState_Release(gil);`
`211`	`213`	`}`
`212`	`214`	`Py_BEGIN_ALLOW_THREADS`
`213`	`215`	`m_thread->join();`