Skip to content

Commit cf00bce

Browse files
committed
Move StreamableExecutor.stop() to its destructor
1 parent 30b603f commit cf00bce

File tree

2 files changed

+1
-6
lines changed

2 files changed

+1
-6
lines changed

pdal/StreamableExecutor.cpp

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -186,9 +186,7 @@ StreamableExecutor::StreamableExecutor(std::string const& json, point_count_t ch
186186

187187
StreamableExecutor::~StreamableExecutor()
188188
{
189-
//ABELL - Hmmm.
190-
if (m_thread)
191-
m_thread->join();
189+
stop();
192190
}
193191

194192
PyArrayObject *StreamableExecutor::executeNext()

pdal/libpdalpython.pyx

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -250,9 +250,6 @@ cdef class PipelineIterator(PipelineResultsMixin):
250250
cdef set_executor(self, StreamableExecutor* executor):
251251
self._executor.reset(executor)
252252

253-
def __dealloc__(self):
254-
self._executor.get().stop()
255-
256253
@property
257254
def schema(self):
258255
return json.loads(self._executor.get().getSchema())

0 commit comments

Comments
 (0)