support pathlib.Path as option types for 'filename' #148 (#149)

Author: hobu

pdal/libpdalpython.cpp

@@ -1,6 +1,7 @@
 #include <pybind11/pybind11.h>
 #include <pybind11/stl.h>
 #include <pybind11/numpy.h>
+#include <pybind11/stl/filesystem.h>
 #include <iostream>
 
 #include <pdal/pdal_config.hpp>
@@ -108,6 +109,16 @@ namespace pdal {
         return dims;
     };
 
+    std::string getReaderDriver(std::filesystem::path const& p)
+    {
+        return StageFactory::inferReaderDriver(p.string());
+    }
+
+    std::string getWriterDriver(std::filesystem::path const& p)
+    {
+        return StageFactory::inferWriterDriver(p.string());
+    }
+
     using pdal::python::PipelineExecutor;
     using pdal::python::StreamableExecutor;
 
@@ -286,8 +297,8 @@ namespace pdal {
     m.def("getDrivers", &getDrivers);
     m.def("getOptions", &getOptions);
     m.def("getDimensions", &getDimensions);
-    m.def("infer_reader_driver", &StageFactory::inferReaderDriver);
-    m.def("infer_writer_driver", &StageFactory::inferWriterDriver);
+    m.def("infer_reader_driver", &getReaderDriver);
+    m.def("infer_writer_driver", &getWriterDriver);
     };
 
 }; // namespace pdal

pdal/pipeline.py

@@ -5,6 +5,7 @@
 from typing import Any, Container, Dict, Iterator, List, Optional, Sequence, Union, cast
 
 import numpy as np
+import pathlib
 
 try:
     from meshio import Mesh
@@ -142,6 +143,9 @@ def toJSON(self) -> str:
         for stage in stages:
             stage2tag[stage] = stage.tag or _generate_tag(stage, stage2tag.values())
             options = stage.options
+            for option in options:
+                if isinstance(options[option], pathlib.Path):
+                    options[option] = str(options[option])
             options["tag"] = stage2tag[stage]
             options["type"] = stage.type
             inputs = _get_input_tags(stage, stage2tag)

test/test_pipeline.py

@@ -7,6 +7,7 @@
 import pytest
 
 import pdal
+import pathlib
 
 DATADIRECTORY = os.path.join(os.path.dirname(__file__), "data")
 
@@ -487,6 +488,14 @@ def test_meshio(self, filename):
         assert len(triangles) == 134
         assert triangles[0][0] == 29
 
+    def test_pathlib(self):
+        """Can we build a pipeline using pathlib.Path as the filenames"""
+        path = pathlib.Path("test/data/autzen-utm.las")
+        read = pdal.Reader(path)
+        pipeline = read.pipeline()
+        pipeline.execute()
+
+
 class TestDataFrame:
 
     @pytest.mark.skipif(