zap temp vars since lvalue subs work

Author: mohawk2

demos/test5.p

@@ -10,7 +10,7 @@ axisvalues($y->slice("(0)")->inplace);
 axisvalues($y->slice("(1)")->transpose->inplace);
 $y /= $size;
 random($y->slice("(2)")->inplace);
-(my $tmp = $y->slice("(2)")) /= 5;
+$y->slice("(2)") /= 5;
 my $c = PDL->zeroes(3,$size,$size);
 random($c->inplace);
 

demos/testimg.p

@@ -14,10 +14,10 @@ my $r = zeroes(4,5,6,7,2,2,2,2)+0.1;
 my $g = zeroes(4,5,6,7,2,2,2,2);
 my $b = zeroes(4,5,6,7,2,2,2,2);
 
-(my $tmp = $r->slice(":,:,2,2")) .= 1;
-($tmp = $r->slice(":,:,:,1")) .= 0.5;
-($tmp = $g->slice("2,:,1,2")) .= 1;
-($tmp = $b->slice("2,3,1,:")) .= 1;
+$r->slice(":,:,2,2") .= 1;
+$r->slice(":,:,:,1") .= 0.5;
+$g->slice("2,:,1,2") .= 1;
+$b->slice("2,3,1,:") .= 1;
 
 $graph->add_dataseries(PDL::Graphics::TriD::Image->new([$r,$g,$b]));
 $graph->scalethings;

lib/PDL/Graphics/TriD/Graph.pm

@@ -152,7 +152,7 @@ sub finish_scale {
 sub transform {
   my($this,$point,$data,$inds) = @_;
   my ($min, $max) = map $this->{Scale}->slice("0:$#$inds,$_"), 0, 1;
-  (my $tmp = $point->slice("0:$#$inds")) +=
+  $point->slice("0:$#$inds") +=
     ($data->dice_axis(0, $inds) - $min) / ($max - $min);
   return $point;
 }
@@ -241,14 +241,14 @@ sub transform {
     exit;
   }
   my $pio180 = 0.017453292;
-  (my $tmp1 = $point->slice("(0)")) +=
+  $point->slice("(0)") +=
     0.5+($data->slice("($inds->[0])")-$this->{Center}[0]) /
       ($this->{Scale}[0][1] - $this->{Scale}[0][0])
 	*cos($data->slice("($inds->[1])")*$pio180);
-  (my $tmp2 = $point->slice("(1)")) +=
+  $point->slice("(1)") +=
     0.5+($data->slice("($inds->[1])")-$this->{Center}[1]) /
       ($this->{Scale}[1][1] - $this->{Scale}[1][0]);
-  (my $tmp3 = $point->slice("(2)")) .=
+  $point->slice("(2)") .=
     log($data->slice("($inds->[2])")/1012.5)/log($this->{Scale}[2][1]/1012.5);
   return $point;
 }
@@ -335,23 +335,23 @@ sub transform {
     exit;
   }
   my $pio180 = 0.017453292;
-  (my $tmp1 = $point->slice("(0)")) +=
+  $point->slice("(0)") +=
     0.5+($data->slice("($inds->[0])")-$this->{Center}[0]) /
       ($this->{Scale}[0][1] - $this->{Scale}[0][0])
 	*cos($data->slice("($inds->[1])")*$pio180);
-  (my $tmp2 = $point->slice("(1)")) +=
+  $point->slice("(1)") +=
     0.5+($data->slice("($inds->[1])")-$this->{Center}[1]) /
       ($this->{Scale}[1][1] - $this->{Scale}[1][0])
 	*cos($data->slice("($inds->[1])")*$pio180);
 # Longitude transformation
-#  (my $tmp = $point->slice("(0)")) =
+#  $point->slice("(0)") =
 #    ($this->{Center}[0]-$point->slice("(0)"))*cos($data->slice("(1)"));
 # Latitude transformation
-#  (my $tmp = $point->slice("(1)")) =
+#  $point->slice("(1)") =
 #    ($this->{Center}[1]-$data->slice("(1)"))*cos($data->slice("(1)"));
 # Vertical transformation
 #  -7.2*log($data->slice("(2)")/1012.5
-  (my $tmp3 = $point->slice("(2)")) .=
+  $point->slice("(2)") .=
     log($data->slice("($inds->[2])")/1012.5)/log($this->{Scale}[2][1]/1012.5);
   return $point;
 }

lib/PDL/Graphics/TriD/Objects.pm

@@ -213,7 +213,6 @@ sub smoothn {
   my $trip = $p->lags(1,1,2)->slice(':,:,:,1:-1') -
 		$p->lags(1,1,2)->slice(':,:,:,0:-2');
   # coords of diagonals with dim 2 having original and reflected diags
-  my $tmp;
   my $trid = ($p->slice(':,0:-2,1:-1')-$p->slice(':,1:-1,0:-2'))
 		    ->dummy(2,2);
   # $ortho is a (3D,x-1,left/right triangle,y-1) array that enumerates
@@ -223,13 +222,13 @@ sub smoothn {
   # now add to vertices to smooth
   my $aver = ref($p)->zeroes($p->dims);
   # step 1, upper right tri0, upper left tri1
-  ($tmp=$aver->lags(1,1,2)->slice(':,:,:,1:-1')) += $ortho;
+  $aver->lags(1,1,2)->slice(':,:,:,1:-1') += $ortho;
   # step 2, lower right tri0, lower left tri1
-  ($tmp=$aver->lags(1,1,2)->slice(':,:,:,0:-2')) += $ortho;
+  $aver->lags(1,1,2)->slice(':,:,:,0:-2') += $ortho;
   # step 3, upper left tri0
-  ($tmp=$aver->slice(':,0:-2,1:-1')) += $ortho->slice(':,:,(0)');
+  $aver->slice(':,0:-2,1:-1') += $ortho->slice(':,:,(0)');
   # step 4, lower right tri1
-  ($tmp=$aver->slice(':,1:-1,0:-2')) += $ortho->slice(':,:,(1)');
+  $aver->slice(':,1:-1,0:-2') += $ortho->slice(':,:,(1)');
   $aver->norm($aver);
   return $aver;
 }

lib/PDL/Graphics/TriD/Polygonize.pm

@@ -18,10 +18,10 @@ sub stupidpolygonize {
 	my $za = ($x->slice("(0)"))->yvals;
 	$za *= $mult/2;
 	$za -= 3.14/2;
-	(my $tmp0 = $x->slice("(0)")) += cos($ya);
-	(my $tmp1 = $x->slice("(1)")) += sin($ya);
-	(my $tmp01 = $x->slice("0:1")) *= cos($za)->dummy(0);
-	(my $tmp2 = $x->slice("(2)")) += sin($za);
+	$x->slice("(0)") += cos($ya);
+	$x->slice("(1)") += sin($ya);
+	$x->slice("0:1") *= cos($za)->dummy(0);
+	$x->slice("(2)") += sin($za);
 	my $add = $x->copy;
 	$x *= $initrad;
 	$x += $center;