AffinePriv implies TwoWay

Author: mohawk2

Changes

@@ -8,6 +8,7 @@
 - add %PDL::{Math,Ops}::got_complex to record whether have complex versions
 - MatrixOps::svd now handles transpose transparently
 - all ops with two-way dataflow now work as lvalues
+- AffinePriv now implies TwoWay
 
 2.103 2026-03-03
 - fix regression in *linvals so takes ndarrays as start and end again

lib/PDL/Core/pdlaffine.c

@@ -16,7 +16,6 @@ pdl_error pdl_writebackdata_affine(pdl_trans *trans) {
 /* generated from:
 pp_def( 'affine',
         P2Child => 1,
-        TwoWay => 1,
         AffinePriv => 1,
         GlobalNew => 'affine_new',
         OtherPars => 'PDL_Indx offset; PDL_Indx dims[]; PDL_Indx incs[]',

lib/PDL/PP.pm

@@ -1484,6 +1484,7 @@ EOF
      }),
    PDL::PP::Rule::Returns->new("OverloadDocValues", []),
 
+   PDL::PP::Rule::Returns::One->new('TwoWay', 'AffinePriv', 'AffinePriv => TwoWay'),
    PDL::PP::Rule::Returns->new("TwoWayFlag", "TwoWay", "PDL_ITRANS_TWOWAY"),
    PDL::PP::Rule::Returns::Zero->new("TwoWayFlag"),
    PDL::PP::Rule::Returns->new("DefaultFlowFlag", "DefaultFlow", "PDL_ITRANS_DO_DATAFLOW_ANY"),

lib/PDL/PP.pod

@@ -1708,7 +1708,6 @@ C<EquivPDimExpr> and maybe a C<EquivDimCheck>:
   pp_def(
     'xchg',
     OtherPars => 'PDL_Indx n1; PDL_Indx n2;',
-    TwoWay => 1,
     P2Child => 1,
     AffinePriv => 1,
     EquivDimCheck => '
@@ -2589,6 +2588,7 @@ transformation back to the parent when C<BackCode> is supplied.
 
 Flag to indicate this is an affine transformation whose C<Priv> (contents
 of the C<pdl_trans>) contains data that will need allocating and freeing.
+As of 2.104, implies C<TwoWay>.
 
 =head3 GlobalNew
 
@@ -2628,6 +2628,7 @@ first argument's C<copy> method will be used.
 If true, sets in the C<pdl_transvtable> (see L<PDL::Internals>) the
 C<iflags> such as to inform the trans's error checks connected to dataflow.
 As of 2.104, also automatically sets C<Lvalue>.
+As of 2.104, implied by C<AffinePriv>.
 
 =head3 Identity
 

lib/PDL/Slices.pd

@@ -1411,7 +1411,6 @@ EOF
 
 pp_def('xchg',
         OtherPars => 'PDL_Indx n1; PDL_Indx n2;',
-        TwoWay => 1,
         P2Child => 1,
         AffinePriv => 1,
         EquivDimCheck =>pp_line_numbers(__LINE__, <<'EOF'),
@@ -1575,7 +1574,6 @@ EOD
 
 pp_def('mv',
         OtherPars => 'PDL_Indx n1; PDL_Indx n2;',
-        TwoWay => 1,
         P2Child => 1,
         AffinePriv => 1,
         CHeader => <<'EOF',
@@ -1718,7 +1716,6 @@ in the usual way (-1 = last dim).
 =cut
 EOD
         P2Child => 1,
-        TwoWay => 1,
         AffinePriv => 1,
         OtherPars => join('', map "PDL_Indx $_;", qw(nthdim step nlags)),
         RedoDims => pp_line_numbers(__LINE__, <<'EOF'),
@@ -1776,7 +1773,6 @@ is always true (C<m> has to be less than 3).
 =cut
 EOD
         P2Child => 1,
-        TwoWay => 1,
         OtherPars => join('', map "PDL_Indx $_;", qw(nthdim nsp)),
         AffinePriv => 1,
         RedoDims => pp_line_numbers(__LINE__, <<'EOF'),
@@ -1850,7 +1846,6 @@ Put some dimensions to a broadcastid.
  $y = $x->broadcastI(0,1,5); # broadcast over dims 1,5 in id 1
 EOD
         P2Child => 1,
-        TwoWay => 1,
         AffinePriv => 1,
         OtherPars => "PDL_Indx id; PDL_Indx whichdims[]",
         Comp => 'PDL_Indx nrealwhichdims',
@@ -1930,7 +1925,6 @@ See [TBD Doc] for details and examples.
 =cut
 EOD
         P2Child => 1,
-        TwoWay => 1,
         AffinePriv => 1,
         OtherPars => 'PDL_Indx atind;',
         RedoDims => pp_line_numbers(__LINE__, <<'EOF'),
@@ -2333,7 +2327,6 @@ EOD-slice
                  PDL_Indx end[$COMP(nargs)];
                  ',
         AffinePriv => 1,
-        TwoWay => 1,
         MakeComp => pp_line_numbers(__LINE__, <<'SLICE-MC'),
                 PDL_Indx nargs = 0;
                 pdl_slice_args *argsptr = arglist;
@@ -2436,7 +2429,6 @@ EOF
 
 pp_def('diagonal',
         P2Child => 1,
-        TwoWay => 1,
         AffinePriv => 1,
         OtherPars => 'PDL_Indx whichdims[]',
         MakeComp => pp_line_numbers(__LINE__-1, '