fixed $slice->inplace->*{lin,log}vals not updating $slice

Author: mohawk2

Changes

@@ -2,6 +2,7 @@
 - pdldoc database now reproducible (#542) - thanks @daym
 - can now do pdl(cplx(1,2)) (#543) - thanks @gladilin for report
 - add convert_flowing method
+- fixed $slice->inplace->*{lin,log}vals not updating $slice
 
 2.100 2025-03-27
 - fix Math function prototypes for GCC 15 (#528) - thanks @jplesnik for report

lib/PDL/Basic.pm

@@ -248,7 +248,9 @@ sub _dimcheck {
 }
 sub _linvals {
   my ($pdl, $v1, $v2, $dim, $method) = @_;
-  $pdl->$method * (($v2 - $v1) / ($dim > 1 ? ($dim-1) : 1)) + $v1;
+  $pdl = $pdl->$method;
+  $pdl *= (($v2 - $v1) / ($dim > 1 ? ($dim-1) : 1));
+  $pdl += $v1;
 }
 sub PDL::xlinvals {
   _linvals(@_[0..2], _dimcheck($_[0], 0, 'xlinvals'), 'xvals');
@@ -264,7 +266,8 @@ sub _logvals {
   my ($pdl, $min, $max, $dim, $method) = @_;
   barf "min and max must be positive" if $min <= 0 || $max <= 0;
   my ($lmin,$lmax) = map log($_), $min, $max;
-  exp($pdl->$method * (($lmax - $lmin) / ($dim > 1 ? ($dim-1) : 1)) + $lmin);
+  $pdl = $pdl->$method;
+  $pdl .= exp($pdl * (($lmax - $lmin) / ($dim > 1 ? ($dim-1) : 1)) + $lmin);
 }
 sub PDL::xlogvals {
   _logvals(@_[0..2], _dimcheck($_[0], 0, 'xlogvals'), 'xvals');

t/basic.t

@@ -41,6 +41,12 @@ my $byte_xvals = ones( byte, 300 )->xvals;
 is $byte_xvals->type, 'double', 'byte->xvals type double';
 is $byte_xvals->at(280), 280,'non-overflow xvals from byte ndarray';
 is xvals(short, 2)->type, 'short', 'xvals respects specified type';
+my ($base, $exp) = (zeroes(3,3), pdl('0;0.5;1'));
+is_pdl $base->slice('0')->inplace->ylinvals(0,1), $exp, 'inplace->linvals returns right';
+is_pdl $base->slice('0'), $exp, 'inplace->linvals updates input';
+($base, $exp) = (zeroes(3,3), pdl('1;3;9'));
+is_pdl $base->slice('0')->inplace->ylogvals(1,9), $exp, 'inplace->logvals returns right';
+is_pdl $base->slice('0'), $exp, 'inplace->logvals updates input';
 }
 
 {