PDOK-18065 Atom-Operator - validation unit-tests

Author: rahmabPublic

internal/webhook/v3/atom_webhook_test.go

@@ -71,6 +71,7 @@ var _ = Describe("Atom Webhook", func() {
 			Expect(errors).To(BeNil())
 			Expect(len(warnings)).To(Equal(0))
 		})
+
 		It("Should deny creation if no labels are available", func() {
 			By("simulating an invalid creation scenario")
 			input, err := os.ReadFile("test_data/input/2-create-error-no-lables.yaml")
@@ -106,6 +107,29 @@ var _ = Describe("Atom Webhook", func() {
 			Expect(errors).To(BeNil())
 			Expect(len(warnings)).To(Equal(0))
 		})
-	})
 
+		It("Should deny update atom with error label names are immutable", func() {
+			By("simulating a valid creation scenario")
+			input, err := os.ReadFile("test_data/input/1-create-no-error-no-warning.yaml")
+			Expect(err).NotTo(HaveOccurred())
+			atomOld := &pdoknlv3.Atom{}
+			err = yaml.Unmarshal(input, atomOld)
+			Expect(err).NotTo(HaveOccurred())
+			warnings, errors := validator.ValidateCreate(ctx, atomOld)
+			Expect(errors).To(BeNil())
+			Expect(len(warnings)).To(Equal(0))
+
+			By("simulating a valid update scenario")
+			input, err = os.ReadFile("test_data/input/4-update-error-labels-immutable.yaml")
+			Expect(err).NotTo(HaveOccurred())
+			atomNew := &pdoknlv3.Atom{}
+			err = yaml.Unmarshal(input, atomNew)
+			Expect(err).NotTo(HaveOccurred())
+			warnings, errors = validator.ValidateUpdate(ctx, atomOld, atomNew)
+
+			expectedError := fmt.Errorf("Atom.pdok.nl \"asis-readonly-prod\" is invalid: [metadata.labels.pdok.nl/dataset-id: Required value: labels cannot be removed, metadata.labels.pdok.nl/dataset-idsssssssss: Forbidden: new labels cannot be added]")
+			Expect(len(warnings)).To(Equal(0))
+			Expect(expectedError.Error()).To(Equal(errors.Error()))
+		})
+	})
 })

internal/webhook/v3/test_data/input/4-update-error-labels-immutable.yaml

@@ -0,0 +1,60 @@
+apiVersion: pdok.nl/v3
+kind: Atom
+metadata:
+  annotations:
+    kangaroo.pdok.nl/lifecycle-phase: prod
+    kangaroo.pdok.nl/service-bundle-ids: 65daed5f-e9e4-5791-a7c9-7e9effcca520
+    kangaroo.pdok.nl/readonly: "true"
+  labels:
+    pdok.nl/dataset-idsssssssss: wetlands
+    pdok.nl/owner-id: rvo
+    pdok.nl/service-type: atom
+  name: asis-readonly-prod
+  namespace: services
+spec:
+  service:
+    baseUrl: http://localhost:32788/rvo/wetlands/atom
+    datasetFeeds:
+      - author:
+          email: [email protected]
+          name: Ministerie van EL&I - GIS Competence Center
+        datasetMetadataLinks:
+          metadataIdentifier: 07d73b60-dfd6-4c54-9c82-9fac70c6c48e
+          templates:
+            - csw
+            - html
+        entries:
+          - content:
+              Wetlands zijn de natte natuurgebieden in Nederland (44 gebieden).
+              Het Wetland verdrag is op 2 februari 1971 te Ramsar in Iran ondertekend.
+              Nederland was een van de zestien landen die het Verdrag toen ondertekende.
+            downloadlinks:
+              - data: public/rvo/wetlands/65daed5f-e9e4-5791-a7c9-7e9effcca520/3/wetlands.gpkg
+            polygon:
+              bbox:
+                maxx: "7.5553527"
+                maxy: "55.66948"
+                minx: "2.354173"
+                miny: "50.71447"
+            srs:
+              name: Amersfoort / RD New
+              uri: https://www.opengis.net/def/crs/EPSG/0/28992
+            technicalName: wetlands
+            title: wetlands
+            updated: "2025-02-28T09:04:17Z"
+        spatialDatasetIdentifierCode: 07d73b60-dfd6-4c54-9c82-9fac70c6c48e
+        spatialDatasetIdentifierNamespace: http://www.pdok.nl
+        subtitle: wetlands
+        technicalName: wetlands
+        title: wetlands
+    lang: nl
+    ownerInfoRef: pdok
+    rights: https://creativecommons.org/publicdomain/zero/1.0/deed.nl
+    serviceMetadataLinks:
+      metadataIdentifier: 2751ba40-5100-4186-81be-b7fdee95b49c
+      templates:
+        - csw
+        - opensearch
+        - html
+    subtitle: Download Service van wetlands new title
+    title: Wetlands new title