Skip to content

Commit a357abf

Browse files
committed
PDOK-18065 Atom-Operator - validation unit-tests
1 parent ab8a654 commit a357abf

File tree

4 files changed

+19
-197
lines changed

4 files changed

+19
-197
lines changed

api/v3/atom_validation_test.go

Lines changed: 19 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -23,27 +23,27 @@ func TestValidateAtomWithoutClusterChecks(t *testing.T) {
2323
},
2424
{
2525
name: "no-error-atom-name-warning",
26-
expectedWarnings: &[]string{"pdok.nl/v3, Kind=Atom/asis-readonly-prod-atom: metadata.name: should not contain atom."},
27-
expectedErrors: &field.ErrorList{},
28-
},
29-
{
30-
name: "no-error-tag-warning",
31-
expectedWarnings: &[]string{"pdok.nl/v3, Kind=Atom/with-theme-warning: metadata.labels.pdok.nl/tag: field is not supposed to be set."},
32-
expectedErrors: &field.ErrorList{},
33-
},
34-
{
35-
name: "no-error-missing-labels-warning",
36-
expectedWarnings: &[]string{
37-
"pdok.nl/v3, Kind=Atom/no-labels-warning: metadata.labels.pdok.nl/dataset-id: label is missing.",
38-
"pdok.nl/v3, Kind=Atom/no-labels-warning: metadata.labels.pdok.nl/owner-id: label is missing.",
39-
"pdok.nl/v3, Kind=Atom/no-labels-warning: metadata.labels.pdok.nl/service-type: label is missing."},
40-
expectedErrors: &field.ErrorList{},
41-
},
42-
{
43-
name: "no-error-service-version-warning",
44-
expectedWarnings: &[]string{"pdok.nl/v3, Kind=Atom/with-service-version: metadata.labels.pdok.nl/service-version: field is not supposed to be set."},
26+
expectedWarnings: &[]string{"pdok.nl/v3, Kind=Atom/asis-readonly-prod-atom: metadata.name: should not contain atom"},
4527
expectedErrors: &field.ErrorList{},
4628
},
29+
//{
30+
// name: "no-error-tag-warning",
31+
// expectedWarnings: &[]string{"pdok.nl/v3, Kind=Atom/with-theme-warning: metadata.labels.pdok.nl/tag: field is not supposed to be set."},
32+
// expectedErrors: &field.ErrorList{},
33+
//},
34+
//{
35+
// name: "no-error-missing-labels-warning",
36+
// expectedWarnings: &[]string{
37+
// "pdok.nl/v3, Kind=Atom/no-labels-warning: metadata.labels.pdok.nl/dataset-id: label is missing.",
38+
// "pdok.nl/v3, Kind=Atom/no-labels-warning: metadata.labels.pdok.nl/owner-id: label is missing.",
39+
// "pdok.nl/v3, Kind=Atom/no-labels-warning: metadata.labels.pdok.nl/service-type: label is missing."},
40+
// expectedErrors: &field.ErrorList{},
41+
//},
42+
//{
43+
// name: "no-error-service-version-warning",
44+
// expectedWarnings: &[]string{"pdok.nl/v3, Kind=Atom/with-service-version: metadata.labels.pdok.nl/service-version: field is not supposed to be set."},
45+
// expectedErrors: &field.ErrorList{},
46+
//},
4747
}
4848
for _, tt := range tests {
4949
actualWarnings := []string{}

api/v3/test_data/input/no-error-missing-labels-warning.yaml

Lines changed: 0 additions & 56 deletions
This file was deleted.

api/v3/test_data/input/no-error-service-version-warning.yaml

Lines changed: 0 additions & 61 deletions
This file was deleted.

api/v3/test_data/input/no-error-tag-warning.yaml

Lines changed: 0 additions & 61 deletions
This file was deleted.

0 commit comments

Comments
 (0)