Merge pull request #44 from PDOK/jd/ttl

Implemented TTL

Author: jelledijkstra97

internal/controller/atom_controller.go

@@ -28,6 +28,7 @@ package controller
 import (
 	"context"
 	"fmt"
+	"time"
 
 	policyv1 "k8s.io/api/policy/v1"
 	"sigs.k8s.io/controller-runtime/pkg/builder"
@@ -131,6 +132,13 @@ func (r *AtomReconciler) Reconcile(ctx context.Context, req ctrl.Request) (resul
 		return result, client.IgnoreNotFound(err)
 	}
 
+	// Check TTL expiry
+	if ttlExpired(atom) {
+		err = r.Client.Delete(ctx, atom)
+
+		return result, err
+	}
+
 	lgr.Info("creating resources for atom", "atom", atom)
 	operationResults, err := r.createOrUpdateAllForAtom(ctx, atom, ownerInfo)
 	if err != nil {
@@ -258,3 +266,13 @@ func getLabels(atom *pdoknlv3.Atom) map[string]string {
 	labels[appLabelKey] = appName
 	return labels
 }
+
+func ttlExpired(atom *pdoknlv3.Atom) bool {
+	if lifecycle := atom.Spec.Lifecycle; lifecycle != nil && lifecycle.TTLInDays != nil {
+		expiresAt := atom.GetCreationTimestamp().Add(time.Duration(*lifecycle.TTLInDays) * 24 * time.Hour)
+
+		return expiresAt.Before(time.Now())
+	}
+
+	return false
+}

internal/controller/atom_controller_test.go

@@ -30,6 +30,8 @@ import (
 	"os"
 	"testing"
 
+	"github.com/pdok/smooth-operator/model"
+
 	"github.com/google/go-cmp/cmp"
 	"github.com/pdok/atom-generator/feeds"
 	apierrors "k8s.io/apimachinery/pkg/api/errors"
@@ -42,6 +44,7 @@ import (
 	. "github.com/onsi/ginkgo/v2" //nolint:revive // ginkgo bdd
 	. "github.com/onsi/gomega"    //nolint:revive // ginkgo bdd
 	smoothoperatorv1 "github.com/pdok/smooth-operator/api/v1"
+	smoothoperatorutils "github.com/pdok/smooth-operator/pkg/util"
 	smoothoperatorvalidation "github.com/pdok/smooth-operator/pkg/validation"
 	"github.com/pkg/errors"
 	"github.com/stretchr/testify/require"
@@ -201,6 +204,40 @@ var _ = Describe("Testing Atom Controller", func() {
 			}, "10s", "1s").Should(BeTrue())
 		})
 
+		It("Respects the TTL of the WMS", func() {
+			By("Creating a new resource for the Kind WMS")
+			controllerReconciler := &AtomReconciler{
+				Client:             k8sClient,
+				Scheme:             k8sClient.Scheme(),
+				AtomGeneratorImage: testImageName1,
+				LighttpdImage:      testImageName2,
+			}
+
+			ttlName := testAtom.GetName() + "-ttl"
+			ttlAtom := testAtom.DeepCopy()
+			ttlAtom.Name = ttlName
+			ttlAtom.Spec.Lifecycle = &model.Lifecycle{TTLInDays: smoothoperatorutils.Pointer(int32(0))}
+			objectKeyTTLAtom := client.ObjectKeyFromObject(ttlAtom)
+
+			err := k8sClient.Get(ctx, objectKeyTTLAtom, ttlAtom)
+			Expect(client.IgnoreNotFound(err)).To(Not(HaveOccurred()))
+			if err != nil && apierrors.IsNotFound(err) {
+				Expect(k8sClient.Create(ctx, ttlAtom)).To(Succeed())
+			}
+
+			// Reconcile
+			_, err = controllerReconciler.Reconcile(ctx, reconcile.Request{NamespacedName: objectKeyTTLAtom})
+			Expect(err).To(Not(HaveOccurred()))
+
+			// Check the WMS cannot be found anymore
+			Eventually(func() bool {
+				err = k8sClient.Get(ctx, objectKeyTTLAtom, ttlAtom)
+				return apierrors.IsNotFound(err)
+			}, "10s", "1s").Should(BeTrue())
+
+			// Not checking owned resources because the test env does not do garbage collection
+		})
+
 		It("Should cleanup the cluster", func() {
 			err := k8sClient.Get(ctx, objectKeyAtom, clusterAtom)
 			Expect(client.IgnoreNotFound(err)).NotTo(HaveOccurred())