Merge pull request #42 from PDOK/jd/allowed-methods

Fixed allowed methods

Author: jelledijkstra97

internal/controller/shared_controller.go

@@ -831,14 +831,12 @@ func mutateCorsHeadersMiddleware[R Reconciler, O pdoknlv3.WMSWFS](r R, obj O, mi
 		Headers: &traefikdynamic.Headers{
 			CustomResponseHeaders: map[string]string{
 				"Access-Control-Allow-Headers": "Content-Type",
-				"Access-Control-Allow-Method":  "GET, HEAD, OPTIONS",
+				"Access-Control-Allow-Method":  "GET, POST, OPTIONS",
 				"Access-Control-Allow-Origin":  "*",
 				"Cache-Control":                "public, max-age=3600, no-transform",
 			},
 		},
 	}
-	// TODO - do we need this in WFS/WMS
-	// middleware.Spec.Headers.FrameDeny = true
 
 	if err := smoothoperatorutils.EnsureSetGVK(reconcilerClient, middleware, middleware); err != nil {
 		return err

internal/controller/wfs_controller_test.go

@@ -491,7 +491,7 @@ var _ = Describe("WFS Controller", func() {
 			checkWFSLabels(middlewareCorsHeaders.GetLabels())
 			// Expect(middlewareCorsHeaders.Spec.Headers.FrameDeny).Should(Equal(true))
 			Expect(middlewareCorsHeaders.Spec.Headers.CustomResponseHeaders["Access-Control-Allow-Headers"]).Should(Equal("Content-Type"))
-			Expect(middlewareCorsHeaders.Spec.Headers.CustomResponseHeaders["Access-Control-Allow-Method"]).Should(Equal("GET, HEAD, OPTIONS"))
+			Expect(middlewareCorsHeaders.Spec.Headers.CustomResponseHeaders["Access-Control-Allow-Method"]).Should(Equal("GET, POST, OPTIONS"))
 			Expect(middlewareCorsHeaders.Spec.Headers.CustomResponseHeaders["Access-Control-Allow-Origin"]).Should(Equal("*"))
 		})
 

internal/controller/wms_controller_test.go

@@ -719,7 +719,7 @@ var _ = Describe("WMS Controller", func() {
 			checkWMSLabels(middlewareCorsHeaders.GetLabels())
 			// Expect(middlewareCorsHeaders.Spec.Headers.FrameDeny).Should(Equal(true))
 			Expect(middlewareCorsHeaders.Spec.Headers.CustomResponseHeaders["Access-Control-Allow-Headers"]).Should(Equal("Content-Type"))
-			Expect(middlewareCorsHeaders.Spec.Headers.CustomResponseHeaders["Access-Control-Allow-Method"]).Should(Equal("GET, HEAD, OPTIONS"))
+			Expect(middlewareCorsHeaders.Spec.Headers.CustomResponseHeaders["Access-Control-Allow-Method"]).Should(Equal("GET, POST, OPTIONS"))
 			Expect(middlewareCorsHeaders.Spec.Headers.CustomResponseHeaders["Access-Control-Allow-Origin"]).Should(Equal("*"))
 		})