Added test for configmap generation

Author: Daimanta

internal/controller/configmaps.go

@@ -117,6 +117,18 @@ func mutateConfigMap[R Reconciler, O pdoknlv3.WMSWFS](r R, obj O, configMap *cor
 	configMap.Immutable = smoothoperatorutils.Pointer(true)
 	configMap.Data = map[string]string{}
 
+	updateConfigMapWithStaticFiles(configMap, obj)
+
+	if err := smoothoperatorutils.EnsureSetGVK(reconcilerClient, configMap, configMap); err != nil {
+		return err
+	}
+	if err := ctrl.SetControllerReference(obj, configMap, getReconcilerScheme(r)); err != nil {
+		return err
+	}
+	return smoothoperatorutils.AddHashSuffix(configMap)
+}
+
+func updateConfigMapWithStaticFiles[O pdoknlv3.WMSWFS](configMap *corev1.ConfigMap, obj O) {
 	staticFileName, contents := static.GetStaticFiles()
 	for _, name := range staticFileName {
 		content := contents[name]
@@ -132,12 +144,4 @@ func mutateConfigMap[R Reconciler, O pdoknlv3.WMSWFS](r R, obj O, configMap *cor
 		}
 		configMap.Data[name] = string(content)
 	}
-
-	if err := smoothoperatorutils.EnsureSetGVK(reconcilerClient, configMap, configMap); err != nil {
-		return err
-	}
-	if err := ctrl.SetControllerReference(obj, configMap, getReconcilerScheme(r)); err != nil {
-		return err
-	}
-	return smoothoperatorutils.AddHashSuffix(configMap)
 }

internal/controller/configmaps_test.go

@@ -0,0 +1,30 @@
+package controller
+
+import (
+	"os"
+	"testing"
+
+	pdoknlv3 "github.com/pdok/mapserver-operator/api/v3"
+	"github.com/pdok/mapserver-operator/internal/controller/constants"
+	"github.com/stretchr/testify/assert"
+	v1 "k8s.io/api/core/v1"
+	"sigs.k8s.io/yaml"
+)
+
+func TestMapserverConfigMaps(t *testing.T) {
+	wfsBytes, err := os.ReadFile("test_data/wfs/complete/input/wfs.yaml")
+	assert.NoError(t, err)
+	o := &pdoknlv3.WFS{}
+	err = yaml.Unmarshal(wfsBytes, o)
+	assert.NoError(t, err)
+	generatedConfigMap := getBareConfigMap(o, constants.MapserverName)
+	generatedConfigMap.Data = make(map[string]string)
+	updateConfigMapWithStaticFiles(generatedConfigMap, o)
+
+	expectedConfigMap := v1.ConfigMap{}
+	expectedBytes, err := os.ReadFile("test_data/wfs/complete/expected/configmap-mapserver.yaml")
+	err = yaml.Unmarshal(expectedBytes, &expectedConfigMap)
+	assert.NoError(t, err)
+
+	assert.Equal(t, expectedConfigMap.Data, generatedConfigMap.Data)
+}

internal/controller/test_data/wfs/complete/expected/configmap-mapserver.yaml

@@ -9,7 +9,7 @@ data:
         MAP "/srv/data/config/mapfile/service.map"
       END
     END
-  include.conf: |-
+  include.conf: |
     server.modules += ( "mod_status" )
 
     $HTTP["remoteip"] =~ "^(127\.0\.0\.1|172\.(1[6-9]|2[0-9]|3[01])\.|10\.|192\.168\.)" {
@@ -18,7 +18,9 @@ data:
 
     url.rewrite-once = (
       "/datasetOwner/dataset/theme/wfs/v1_0/legend(.*)" => "/legend$1",
-      "/datasetOwner/dataset/theme/wfs/v1_0(.*)" => "/mapserver$1"
+      "/datasetOwner/dataset/theme/wfs/v1_0/(.*)" => "/mapserver$1",
+      "/other/path/legend(.*)" => "/legend$1",
+      "/other/path/(.*)" => "/mapserver$1"
     )
 
     magnet.attract-raw-url-to += ( "/srv/mapserver/config/ogc.lua" )
@@ -110,7 +112,7 @@ data:
             end
         end
     end
-  scraping-error.xml: |-
+  scraping-error.xml: |
     <?xml version="1.0" encoding="UTF-8"?>
     <ows:ExceptionReport xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:ows="http://www.opengis.net/ows/1.1" version="2.0.0" xml:lang="en-US" xsi:schemaLocation="http://www.opengis.net/ows/1.1 http://schemas.opengis.net/ows/1.1.0/owsExceptionReport.xsd">
         <ows:Exception exceptionCode="InvalidParameterValue" locator="typename">